Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0038632

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] A. Platform

minor

have not tried

2018-05-25 13:19

2019-01-11 12:45

Reporter

caristu

View Status

public

Assigned To

caristu

Priority

normal

Resolution

no change required

Fixed in Version

3.0PR18Q4

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

caristu

Web browser

Modules

Core

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0038632: Change log level to warning when using OBDal.registerSQLFunction method

Description

With the changes introduced with issue 0038520, the OBDal.registerSQLFunction method was deprecated, and a message is shown in the log using the INFO level. The reason of using that level instead of WARN is to avoid breaking CI (some tests are downloading modules from CR whose latest version is still using that method).

The log level should be changed to WARN in 18Q4 release (once the method is not used in the latest version of the modules published in CI) unless the Hibernate library is upgraded in that version. In that case, the method will be completely removed.

Steps To Reproduce

In description

Tags

No tags attached.

warn.diff [^] (668 bytes) 2018-05-25 13:20 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/dal/service/OBDal.java b/src/org/openbravo/dal/service/OBDal.java
--- a/src/org/openbravo/dal/service/OBDal.java
+++ b/src/org/openbravo/dal/service/OBDal.java
@@ -136,7 +136,7 @@
    */
   @Deprecated
   public void registerSQLFunction(String name, SQLFunction function) {
-    log.info("Using deprecated way of registering SQL functions in Hibernate", new Exception(
+    log.warn("Using deprecated way of registering SQL functions in Hibernate", new Exception(
         "Current Stack Trace"));
     final DalSessionFactory dalSessionFactory = (DalSessionFactory) SessionFactoryController
         .getInstance().getSessionFactory();

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	defect	0038520		closed	caristu	Deprecate OBDal.registerSQLFunction
related to	feature request	0037064		closed	caristu	upgrade hibernate to 5.3.2

Notes
(0108924) caristu (developer) 2019-01-11 12:45	The method was finally removed in PR18Q4[1] [1] https://code.openbravo.com/erp/devel/pi/diff/3a81005e6124/src/org/openbravo/dal/service/OBDal.java [^]

Issue History
Date Modified	Username	Field	Change
2018-05-25 13:19	caristu	New Issue
2018-05-25 13:19	caristu	Assigned To	=> platform
2018-05-25 13:19	caristu	Modules	=> Core
2018-05-25 13:19	caristu	Triggers an Emergency Pack	=> No
2018-05-25 13:19	caristu	Assigned To	platform => caristu
2018-05-25 13:19	caristu	Status	new => acknowledged
2018-05-25 13:19	caristu	Relationship added	related to 0038520
2018-05-25 13:20	caristu	Relationship added	related to 0037064
2018-05-25 13:20	caristu	File Added: warn.diff
2018-05-25 13:22	caristu	Description Updated	View Revisions
2018-05-25 13:22	caristu	Description Updated	View Revisions
2019-01-11 10:59	caristu	Assigned To	caristu => platform
2019-01-11 10:59	caristu	Assigned To	platform => caristu
2019-01-11 12:44	caristu	Status	acknowledged => scheduled
2019-01-11 12:45	caristu	Review Assigned To	=> caristu
2019-01-11 12:45	caristu	Note Added: 0108924
2019-01-11 12:45	caristu	Status	scheduled => closed
2019-01-11 12:45	caristu	Resolution	open => no change required
2019-01-11 12:45	caristu	Fixed in Version	=> 3.0PR18Q4

Copyright © 2000 - 2009 MantisBT Group