Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0038001
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementmajoralways2018-02-26 14:012018-03-13 17:23
ReporterngarciaView Statuspublic 
Assigned ToAtulOpenbravo 
PriorityurgentResolutionfixedFixed in Version3.0PR18Q2
StatusclosedFix in branchFixed in SCM revision024449fcae93
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket337
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0038001: Tax Payment process is not filtering the GL Item account by General Ledger when creating the GL Journal

DescriptionTax Payment process is not filtering the GL Item account by General Ledger when creating the GL Journal, it takes the one with highest identifier
Steps To ReproduceAs group admin role:
   Go to G/L Item window and select International funds transfer (defined at *)
   Set the following values in Accounting tab:
      General Ledger: F&B International Group US/A/US Dollar
      Glitem debit acct: 1110 - Checking Account
      Glitem credit acct: 1110 - Checking Account

      General Ledger: F&B España, S.A. US/A/Euro
      Glitem debit acct: 10000 - Capital social
      Glitem credit acct: 10000 - Capital social

   Check through database that 1110 - Checking Account has a higher identifier than 10000 - Capital social

   Create the following Tax Register Type:
      Organization: F&B España, S.A
      G/L Item: International funds transfer
      Sales Transaction: N
   Add a line:
      Tax: Adquisiciones IVA 21% - IVA Normal
      Document Type: AP Invoice

   Create another Tax Register Type:
      Organization: F&B España, S.A
      G/L Item: International funds transfer
      Sales Transaction: Y
   Add a line:
      Tax: Entregas IVA 21% - IVA Normal
      Document Type: AR Invoice

   Create a Tax Payment:
      Organization: F&B España, S.A
      Business Partner: Bebidas Alegres, S.L.
      General Ledger: F&B España, S.A. US/A/Euro
      Starting date: 01-01-2017
      Ending date: 31-12-2017
      Generate Payment: Y
   Create Vat Registers
   Process it

   Navigate to the Journal Entry and check although G/L Journal header shows F&B España, S.A. US/A/Euro general ledger an account combination from a different general ledger is used in lines (1110 - Checking Account)
Proposed SolutionReview the following query in c_taxpayment_post database function:

      select case when tt.issotrx='Y' then max(glitem_credit_acct) else max(glitem_debit_acct) end, max(tt.c_glitem_id)
      into v_glitem_acct, v_glitem_id
      from c_taxregister_type tt
      inner join c_glitem_acct gia on gia.c_glitem_id=tt.c_glitem_id
      where tt.isactive='Y' and gia.isactive='Y' and tt.issotrx= case when v_totalcredit - v_totaldebit > 0 then 'N' else 'Y' end
      group by tt.issotrx;
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0103104)
AtulOpenbravo (viewer)
2018-03-08 21:51
edited on: 2018-03-08 21:51

 Test Plan

- Login as F&B International Group Admin role.
- Go to G/L Item window and select International funds transfer (defined at *)
   Set the following values in Accounting tab:
      General Ledger: F&B International Group US/A/US Dollar
      Glitem debit acct: 1110 - Checking Account
      Glitem credit acct: 1110 - Checking Account

      General Ledger: F&B España, S.A. US/A/Euro
      Glitem debit acct: 10000 - Capital social
      Glitem credit acct: 10000 - Capital social

- Check through database that 1110 - Checking Account has a higher identifier than 10000 - Capital social

- Create the following Tax Register Type:
      Organization: F&B España, S.A
      G/L Item: International funds transfer
      Sales Transaction: N
   Add a line:
      Tax: Adquisiciones IVA 21% - IVA Normal
      Document Type: AP Invoice

- Create another Tax Register Type:
      Organization: F&B España, S.A
      G/L Item: International funds transfer
      Sales Transaction: Y
   Add a line:
      Tax: Entregas IVA 21% - IVA Normal
      Document Type: AR Invoice

- Create a Tax Payment:
      Organization: F&B España, S.A
      Business Partner: Bebidas Alegres, S.L.
      General Ledger: F&B España, S.A. US/A/Euro
      Starting date: 01-01-2017
      Ending date: 31-12-2017
      Generate Payment: Y
- Run Create Vat Registers button process
- Process it

- Navigate to the Journal Entry and check G/L Journal header shows F&B España, S.A. US/A/Euro general ledger an account combination from same General Ledger Configuration is being used in lines i.e 10000 - Capital social.
(0103131)
hgbot (developer)
2018-03-09 12:01

 Repository: erp/devel/pi
Changeset: 024449fcae93290bc0d2ccb8a431daec82a9c83a
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Fri Mar 09 02:23:55 2018 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/024449fcae93290bc0d2ccb8a431daec82a9c83a [^]

Fixes Issue 38001: Tax Payment process is not filtering the GL Item
account by General Ledger when creating the GL Journal

** Added General Ledger from Tax Payment in where condition to pick
account element value id associated with the GL Item

---
M src-db/database/model/functions/C_TAXPAYMENT_POST.xml
---
(0103132)
dmiguelez (viewer)
2018-03-09 12:02

 Code Review + Testing Ok
(0103208)
hudsonbot (viewer)
2018-03-13 17:23

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1d3ccc92fab6 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2018-02-26 14:01 ngarcia New Issue
2018-02-26 14:01 ngarcia Assigned To => Triage Finance
2018-02-26 14:01 ngarcia OBNetwork customer => Yes
2018-02-26 14:01 ngarcia Modules => Core
2018-02-26 14:01 ngarcia Support ticket => 337
2018-02-26 14:01 ngarcia Resolution time => 1521414000
2018-02-26 14:01 ngarcia Triggers an Emergency Pack => No
2018-02-26 14:01 ngarcia Issue Monitored: networkb
2018-03-02 14:08 dmiguelez Assigned To Triage Finance => AtulOpenbravo
2018-03-08 21:51 AtulOpenbravo Status new => scheduled
2018-03-08 21:51 AtulOpenbravo Note Added: 0103104
2018-03-08 21:51 AtulOpenbravo Note Edited: 0103104 View Revisions
2018-03-09 12:01 hgbot Checkin
2018-03-09 12:01 hgbot Note Added: 0103131
2018-03-09 12:01 hgbot Status scheduled => resolved
2018-03-09 12:01 hgbot Resolution open => fixed
2018-03-09 12:01 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/024449fcae93290bc0d2ccb8a431daec82a9c83a [^]
2018-03-09 12:02 dmiguelez Review Assigned To => dmiguelez
2018-03-09 12:02 dmiguelez Note Added: 0103132
2018-03-09 12:02 dmiguelez Status resolved => closed
2018-03-09 12:02 dmiguelez Fixed in Version => 3.0PR18Q2
2018-03-13 17:23 hudsonbot Checkin
2018-03-13 17:23 hudsonbot Note Added: 0103208

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker