0037264: Returning change in a payment method with payment data generates a wrong payment plan

Description

If you generate change in a ticket and the cash payment method is not grouped (because it is created with payment data), when the ticket is finally synchronized the payment plan is wrongly generated.

Steps To Reproduce

- Add this hook to your code:
OB.UTIL.HookManager.registerHook('OBPOS_preAddPayment', function (args, callbacks) {
  if (args.paymentToAdd.get('amount') < 0) {
    args.paymentToAdd.set('paid', args.paymentToAdd.get('amount'));
    args.paymentToAdd.set('origAmount', args.paymentToAdd.get('amount'))
    args.paymentToAdd.set('paymentData', {
      change: 'change payment'
    });
  }
  OB.UTIL.HookManager.callbackExecutor(args, callbacks);
});

- Load WebPOS
- Add an Avalanche transceiver
- Add 5€ as cash
- Pay 150.5€ with card

Go to the Sales Order window in backend and verify that the Payment Plan is wrong,

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	defect	0036622		closed	ranjith_qualiantech_com	Add a not needed payment can generate wrong data
related to	defect	0038038		closed	ranjith_qualiantech_com	Wrong payment documents registered in backoffice when giving change in another currency from WebPOS

Notes
(0111081) marvintm (manager) 2019-04-11 13:12	This issue has been fixed as part of the multichange project

Issue History
Date Modified	Username	Field	Change
2017-11-08 15:28	aaroncalero	New Issue
2017-11-08 15:28	aaroncalero	Assigned To	=> Retail
2017-11-08 15:28	aaroncalero	Triggers an Emergency Pack	=> No
2017-11-08 15:28	aaroncalero	Relationship added	related to 0036622
2018-03-22 08:15	ranjith_qualiantech_com	Relationship added	related to 0038048
2018-03-22 08:24	ranjith_qualiantech_com	Relationship added	related to 0038038
2018-03-22 08:24	ranjith_qualiantech_com	Relationship deleted	related to 0038048
2018-03-22 14:01	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2018-03-26 07:55	ranjith_qualiantech_com	Status	new => scheduled
2019-04-11 13:12	marvintm	Review Assigned To	=> marvintm
2019-04-11 13:12	marvintm	Note Added: 0111081
2019-04-11 13:12	marvintm	Status	scheduled => closed
2019-04-11 13:12	marvintm	Resolution	open => fixed