0036944: Would be nice if OBQuery allows to set a timeout for a certain query

Description

Currently it is posible to set a timeout for HQLQuery object but it is not possible to do it for OBQuery object

Steps To Reproduce

currently this code works

        final Query query = querybuilder.getDalQuery();
        setParameterValues(query, parameterValues);
        if (timeout != null) {
          query.setTimeout(timeout);
        }

I would like to do the same with OBQuery

    OBQuery<Order> obQueryPO = OBDal.getInstance().createQuery(Order.class, hqlPOQuery.toString());
    obQueryPO.setNamedParameter("warehouseId", warehouseId);
....
....
    obQueryPO.setMaxResult(limit);
>>>>>// obQueryPO.setQueryTimeout(timeout);

Proposed Solution

Patch attached

Tags

No tags attached.

Attached Files

obQueryTimeout.diff [^] (2,050 bytes) 2017-09-25 17:06 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/dal/service/OBQuery.java b/src/org/openbravo/dal/service/OBQuery.java
--- a/src/org/openbravo/dal/service/OBQuery.java
+++ b/src/org/openbravo/dal/service/OBQuery.java
@@ -78,6 +78,8 @@
 
   private String poolName;
 
+  private int queryTimeout = -1;
+
   // package visible
   OBQuery() {
   }
@@ -250,14 +252,18 @@
       if (maxResult > -1) {
         qry.setMaxResults(maxResult);
       }
-      String queryProfile = null;
-      if (this.getQueryType() != null) {
-        queryProfile = this.getQueryType();
-      } else if (SessionInfo.getQueryProfile() != null) {
-        queryProfile = SessionInfo.getQueryProfile();
-      }
-      if (queryProfile != null) {
-        QueryTimeOutUtil.getInstance().setQueryTimeOut(qry, queryProfile);
+      if (queryTimeout != -1) {
+        QueryTimeOutUtil.getInstance().setQueryTimeOut(qry, queryTimeout);
+      } else {
+        String queryProfile = null;
+        if (this.getQueryType() != null) {
+          queryProfile = this.getQueryType();
+        } else if (SessionInfo.getQueryProfile() != null) {
+          queryProfile = SessionInfo.getQueryProfile();
+        }
+        if (queryProfile != null) {
+          QueryTimeOutUtil.getInstance().setQueryTimeOut(qry, queryProfile);
+        }
       }
       return qry;
     } catch (final Exception e) {
@@ -718,4 +724,8 @@
   void setPoolName(String poolName) {
     this.poolName = poolName;
   }
+
+  public void setQueryTimeout(int queryTimeout) {
+    this.queryTimeout = queryTimeout;
+  }
 }
diff --git a/src/org/openbravo/service/db/QueryTimeOutUtil.java b/src/org/openbravo/service/db/QueryTimeOutUtil.java
--- a/src/org/openbravo/service/db/QueryTimeOutUtil.java
+++ b/src/org/openbravo/service/db/QueryTimeOutUtil.java
@@ -140,6 +140,12 @@
     }
   }
 
+  public void setQueryTimeOut(Query query, int milliseconds) {
+    if (canApplyTimeOut) {
+      query.setTimeout(milliseconds);
+    }
+  }
+
   /**
    * Sets a timeout for a hibernate criteria (i.e. OBCriteria), if possible
    *

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2017-09-25 17:06	guilleaer	New Issue
2017-09-25 17:06	guilleaer	Assigned To	=> platform
2017-09-25 17:06	guilleaer	File Added: obQueryTimeout.diff
2017-09-25 17:06	guilleaer	Modules	=> Core
2017-09-25 17:06	guilleaer	Triggers an Emergency Pack	=> No
2017-09-25 17:10	guilleaer	Issue Monitored: guilleaer
2022-02-01 08:08	alostale	Assigned To	platform => Triage Platform Base