Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0036146 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | major | have not tried | 2017-05-31 10:01 | 2017-06-08 17:12 | |||
| Reporter | marvintm | View Status | public | |||||
| Assigned To | alostale | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR17Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | e342b5a12e30 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | caristu | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | Pre packaging ( pi ) | |||||||
| Regression date | 2017-05-08 | |||||||
| Regression introduced in release | pi | |||||||
| Regression introduced by commit | http://code.openbravo.com/erp/devel/pi/rev/554d8c055ea2e7cb078c405634e41c14079bd61e [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0036146: Static resources file may become corrupted if asked concurrently | |||||||
| Description | After the refactor of the static resources functionality, the writing of the static resources file is no longer synchronized. This can create problems if multiple terminals request the static resources at the same time, because two threads may be writing the file at the same time, and it can become corrupted | |||||||
| Steps To Reproduce | We have reproduced this problem when using the Web POS, because the application asks for the static resources twice when accessing the page (one for the main page, and one through the generation of the ApplicationCache manifest), and in many cases, these requests arrive almost at the same time, and they then generate a corrupted file. | |||||||
| Proposed Solution | The generation of the file should be synchronized. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0097045) hgbot (developer) 2017-05-31 10:31 |
Repository: erp/devel/pi Changeset: e342b5a12e30cf4ae4dc86fddfa85daee2051b85 Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Wed May 31 10:27:47 2017 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/e342b5a12e30cf4ae4dc86fddfa85daee2051b85 [^] fixed bug 36146: static resources may be corrupted if requested concurrently Requests for static javascript resources generate a js file and cache its value in memory. Concurrent initial requests to generate it before having it cached, can cause the file to be incorrecctly generated. Now in case the file is not yet cached, it is generated in a synchronized block preventing thus concurrent modifications on it. --- M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/StaticResourceComponent.java --- |
|
(0097113) caristu (developer) 2017-06-02 18:12 |
Code reviewed |
|
(0097224) hudsonbot (developer) 2017-06-08 17:12 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/fda0f16ab470 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-05-31 10:01 | marvintm | New Issue | |
| 2017-05-31 10:01 | marvintm | Assigned To | => platform |
| 2017-05-31 10:01 | marvintm | Modules | => Core |
| 2017-05-31 10:01 | marvintm | Regression level | => Pre packaging ( pi ) |
| 2017-05-31 10:01 | marvintm | Regression date | => 2017-05-08 |
| 2017-05-31 10:01 | marvintm | Regression introduced in release | => pi |
| 2017-05-31 10:01 | marvintm | Regression introduced by commit | => http://code.openbravo.com/erp/devel/pi/rev/554d8c055ea2e7cb078c405634e41c14079bd61e [^] |
| 2017-05-31 10:01 | marvintm | Triggers an Emergency Pack | => No |
| 2017-05-31 10:02 | marvintm | Relationship added | depends on 0035852 |
| 2017-05-31 10:02 | marvintm | Relationship replaced | caused by 0035852 |
| 2017-05-31 10:19 | alostale | Assigned To | platform => alostale |
| 2017-05-31 10:25 | alostale | Review Assigned To | => caristu |
| 2017-05-31 10:31 | hgbot | Checkin | |
| 2017-05-31 10:31 | hgbot | Note Added: 0097045 | |
| 2017-05-31 10:31 | hgbot | Status | new => resolved |
| 2017-05-31 10:31 | hgbot | Resolution | open => fixed |
| 2017-05-31 10:31 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/e342b5a12e30cf4ae4dc86fddfa85daee2051b85 [^] |
| 2017-06-02 18:12 | caristu | Note Added: 0097113 | |
| 2017-06-02 18:12 | caristu | Status | resolved => closed |
| 2017-06-02 18:12 | caristu | Fixed in Version | => 3.0PR17Q3 |
| 2017-06-08 17:12 | hudsonbot | Checkin | |
| 2017-06-08 17:12 | hudsonbot | Note Added: 0097224 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |