0035118: Wiki explains that default behavior for discount key of the keyboard is Discretionary discounts but old discounts is active

Description

Wiki explains that default behavior for discount key of the keyboard is Discretionary discounts but "basic" discounts is active

http://wiki.openbravo.com/wiki/Retail:Web_POS_User_Guide#Numerical_pad [^]

Steps To Reproduce

Create a clean instance of retail (including sample data)

You will see that the preference which enables this behavior is the preference "OBPOS_retail.discountkeyboard" but it is not part of the source data (check in ad_preference xml file [src-db/database/sourcedata/AD_PREFERENCE.xml]) there is nothing there related to this preference.

There is one entry in the retail sample data which set this preference to True, but it should be removed since it is not part of a default installation.

delete from ad_preference where property = 'OBPOS_retail.discountkeyboard'
(one line should be removed)

Having this configuration, open web POS. You will see that the behavior of the button is the "basic" discount which is not the expected. however, if you execute this query [
INSERT INTO AD_PREFERENCE
(AD_PREFERENCE_ID,AD_CLIENT_ID,AD_ORG_ID,ISACTIVE,CREATED,CREATEDBY,UPDATED,UPDATEDBY,
AD_WINDOW_ID,AD_USER_ID,ATTRIBUTE,VALUE,PROPERTY,ISPROPERTYLIST,VISIBLEAT_CLIENT_ID,
VISIBLEAT_ORG_ID,VISIBLEAT_ROLE_ID,SELECTED,AD_MODULE_ID)
VALUES (get_uuid(),'0','0','Y',now(),'100',now(),'100',
null,null,null,'Y','OBPOS_retail.discountkeyboard','Y',null,null,
null,'N',null)
]

the expected behavior will happen.

Apart from that, there is a modulescript (very old) which creates this preference with value 'N' for instances which are not new. This module script is not doing nothing right now, because the behavior of Web POS is the same when this preference exists with 'N' value and when it does not exist.

Proposed Solution

- Add preference to source data with value Y
(It can create a behavior change in our customers, because without doing nothing, discretionary discounts will start to work). A possible solution to this change of behavior would be to create a module script which will add a preference with value 'N' for those organizations which have terminals. Doing it, instances which are currently running will not change this behavior.

Issue History
Date Modified	Username	Field	Change
2017-02-01 10:00	guilleaer	New Issue
2017-02-01 10:00	guilleaer	Assigned To	=> Retail
2017-02-01 10:00	guilleaer	Triggers an Emergency Pack	=> No
2017-02-01 10:03	guilleaer	Steps to Reproduce Updated	View Revisions
2017-02-01 10:11	guilleaer	Description Updated	View Revisions
2017-02-01 10:11	guilleaer	Steps to Reproduce Updated	View Revisions
2017-02-01 10:12	guilleaer	Steps to Reproduce Updated	View Revisions

Relationships [ Relation Graph ] [ Dependency Graph ]