Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0035076
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2017-01-30 09:202017-03-15 20:18
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in Version3.0PR17Q2
StatusclosedFix in branchFixed in SCM revisiona97688739247
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0035076: if test leaves admin mode, following test cases fail

DescriptionIf a test extending ObserverBaseTest leaves context as admin, it expectedly fails. But the subsequent test cases fail also if they don't handle this situation.



Steps To Reproduce- Add attached test cases: AdminModeHandleInTest
- Execute them
  -> 1st one correctly fails
  -> 2nd one shouldn't fail but it does

Note this test case cannot be included in standard suite as there is no way to prevent 1st one to fail as exception is thrown by TestWatcher after test finalization.
Proposed SolutionFollowing test cases shouldn't fail.
TagsNo tags attached.
Attached Files? file icon AdminModeHandleInTest.java [^] (543 bytes) 2017-01-30 09:21

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0035075 closedalostale PersistanceObserver can fail if other observers for OrderLine are present 

-  Notes
(0093915)
hgbot (developer)
2017-01-30 09:24

 Repository: erp/devel/pi
Changeset: a9768873924713fa9ae1a2fd704c766a97f70b1d
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Jan 30 09:23:12 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a9768873924713fa9ae1a2fd704c766a97f70b1d [^]

fixed bug 35076: if test leaves admin mode, following test cases fail

  Restore previous mode when this situation occurs so that following test cases
  start in a clean situation.

---
M src-test/src/org/openbravo/test/base/OBBaseTest.java
---
(0093923)
caristu (developer)
2017-01-30 11:03

 Code reviewed + testing OK: admin mode is reset properly, therefore 2nd test case does not fail.
(0095136)
hudsonbot (developer)
2017-03-15 20:18

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2017-01-30 09:20 alostale New Issue
2017-01-30 09:20 alostale Assigned To => platform
2017-01-30 09:20 alostale Modules => Core
2017-01-30 09:20 alostale Triggers an Emergency Pack => No
2017-01-30 09:20 alostale Relationship added related to 0035075
2017-01-30 09:20 alostale Review Assigned To => caristu
2017-01-30 09:20 alostale Assigned To platform => alostale
2017-01-30 09:21 alostale File Added: AdminModeHandleInTest.java
2017-01-30 09:24 hgbot Checkin
2017-01-30 09:24 hgbot Note Added: 0093915
2017-01-30 09:24 hgbot Status new => resolved
2017-01-30 09:24 hgbot Resolution open => fixed
2017-01-30 09:24 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a9768873924713fa9ae1a2fd704c766a97f70b1d [^]
2017-01-30 11:03 caristu Note Added: 0093923
2017-01-30 11:03 caristu Status resolved => closed
2017-01-30 11:03 caristu Fixed in Version => 3.0PR17Q2
2017-03-15 20:18 hudsonbot Checkin
2017-03-15 20:18 hudsonbot Note Added: 0095136

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker