Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0034984 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Modules] Cash VAT Management | critical | always | 2017-01-17 16:57 | 2017-01-19 10:04 | |||
| Reporter | aferraz | View Status | public | |||||
| Assigned To | vmromanos | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | a96bfb231d06 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Linux 64 bit | Database | PostgreSQL | Java version | 1.6.0_18 | |||
| OS Version | Professional Appliance | Database version | 8.3.9 | Ant version | 1.7.1 | |||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Regression date | ||||||||
| Regression introduced by commit | ||||||||
| Regression level | ||||||||
| Review Assigned To | aferraz | |||||||
| Support ticket | ||||||||
| OBNetwork customer | No | |||||||
| Regression introduced in release | ||||||||
| Summary | 0034984: AddMissingCashVATPayments modulescript does not release the connection | |||||||
| Description | AddMissingCashVATPayments modulescript does not release the connection. AddMissingCashVATPayments.selectMissedPaymentDetails query retrieves a scrollable which is not closed in the modulescript. Thus, the connection is not released and install.source task is not completed. | |||||||
| Steps To Reproduce | Install Cash VAT Management module (version >= 1.0.200). Run ant install.source task. Realize task does not end and it is locked in following step: Enabling constraints. | |||||||
| Proposed Solution | Add the following code at the end of the modulescript: finally { if (data != null){ data.close(); } } | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0093669) vmromanos (viewer) 2017-01-17 19:47 |
Test plan I: 1. Clone the https://code.openbravo.com/erp/mods/org.openbravo.module.cashvat/ [^] (which includes the fix for this issue) into the modules folder 2. Runs ant install.source. Verify the process completes successfully Test plan II: 1. Create a new Tax Rate, rate = 21%, Cash VAT = Y 2. Create a Sales Invoice with 1 line. Manually select the previously created tax rate 3. Complete the invoice 4. Add a full payment 5. Verify Sales Invoice | Tax | Cash VAT is populated with 100% 6. As System Admin, delete the preference "CashVATCreditMemoPartialModuleScriptExecuted" (if available) 7. Run delete from c_invoicetax_cashvat directly into the database [Cash VAT table] 8. Run ant smartbuild -Dlocal=no. Verify the log for the module script says: Fixed Invoice Tax Cash VAT lines: 1 9. Back to Openbravo, search for the previous Sales Invoice, and go to Tax | Cash VAT. Verify a record with 100% is there |
|
(0093670) hgbot (developer) 2017-01-17 19:49 |
Repository: erp/mods/org.openbravo.module.cashvat Changeset: a96bfb231d0697aed4d517ba23594e9b4d0a6147 Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> Date: Tue Jan 17 19:50:49 2017 +0100 URL: http://code.openbravo.com/erp/mods/org.openbravo.module.cashvat/rev/a96bfb231d0697aed4d517ba23594e9b4d0a6147 [^] Fixed issue 34984: AddMissingCashVATPayments does not release the connection Surround logic in try-finally, adding the closing stuff in the finally. Compile module with Java 6 for backwards compatibility --- M build/classes/org/openbravo/module/cashvat/modulescript/AddMissingCashVATPayments.class M src-db/database/sourcedata/AD_MODULE.xml M src-util/modulescript/src/org/openbravo/module/cashvat/modulescript/AddMissingCashVATPayments.java --- |
|
(0093723) aferraz (viewer) 2017-01-19 10:04 |
Code review + Testing OK |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-01-17 16:57 | aferraz | New Issue | |
| 2017-01-17 16:57 | aferraz | Assigned To | => Triage Finance |
| 2017-01-17 16:57 | aferraz | OBNetwork customer | => No |
| 2017-01-17 17:00 | aferraz | Proposed Solution updated | |
| 2017-01-17 19:13 | vmromanos | Status | new => scheduled |
| 2017-01-17 19:13 | vmromanos | Assigned To | Triage Finance => vmromanos |
| 2017-01-17 19:47 | vmromanos | Note Added: 0093669 | |
| 2017-01-17 19:49 | hgbot | Checkin | |
| 2017-01-17 19:49 | hgbot | Note Added: 0093670 | |
| 2017-01-17 19:49 | hgbot | Status | scheduled => resolved |
| 2017-01-17 19:49 | hgbot | Resolution | open => fixed |
| 2017-01-17 19:49 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/mods/org.openbravo.module.cashvat/rev/a96bfb231d0697aed4d517ba23594e9b4d0a6147 [^] |
| 2017-01-17 19:50 | vmromanos | Review Assigned To | => aferraz |
| 2017-01-19 10:04 | aferraz | Note Added: 0093723 | |
| 2017-01-19 10:04 | aferraz | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |