Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034638
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Y. DBSourceManagermajorhave not tried2016-11-26 13:562016-12-16 18:39
ReporterAugustoMauchView Statuspublic 
Assigned ToAugustoMauch 
PriorityimmediateResolutionfixedFixed in Version3.0PR17Q1
StatusclosedFix in branchFixed in SCM revision127865df93dd
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression levelAutomated tests
Regression date2016-11-25
Regression introduced in releasepi
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/f169cafac730141372142a78fbc68e040c12b7c1 [^]
Triggers an Emergency PackNo
Summary

0034638: Changing the visibility of DatabaseDataIO.writeDataForTableToXML has broken a job

DescriptionChanging the visibility of DatabaseDataIO.writeDataForTableToXML from public to private has broken this job: http://ci.openbravo.com/job/mod-simple/7573/ [^]
...
compileSqlc:
    [javac] Compiling 1815 source files to /srv/ci/workspace/mod-simple-ci23.142/build/classes
    [javac] /srv/ci/workspace/mod-simple-ci23.142/modules/org.openbravo.ezattributes/src/org/openbravo/ezattributes/processes/GenerateProcess.java:1265: error: cannot find symbol
    [javac] final boolean b = dbdio.writeDataForTableToXML(platform, db, table, out, getEncoding(),
    [javac] ^
    [javac] symbol: method writeDataForTableToXML(Platform,Database,OBDatasetTable,OutputStream,String,String)
    [javac] location: variable dbdio of type DatabaseDataIO
    [javac] 1 error
Steps To ReproduceSee http://ci.openbravo.com/job/mod-simple/7573/ [^]
Proposed SolutionMake the DatabaseDataIO.writeDataForTableToXML method public again
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
caused by feature request 0033875 closedAugustoMauch Importing/Exporting sample data using PostgreSQL's COPY instead of current XML 

-  Notes
(0091865)
hgbot (developer)
2016-11-26 14:03

 Repository: erp/devel/dbsm-main
Changeset: 9ee6ed582c36f9a342f3afd2324dfc890ef34239
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Sat Nov 26 14:02:36 2016 +0100
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/9ee6ed582c36f9a342f3afd2324dfc890ef34239 [^]

Fixes issue 34638, related with issue 33875: Reverts method visibility change

The DatabaseDataIO.writeDataForTableToXML method was made private because it was not being used by any class other than DatabaseDataIO inside dbsm, but I failed to notice that it was being used in an external module (Easy Extensible Attributes).

---
M src/org/apache/ddlutils/io/DatabaseDataIO.java
---
(0091867)
hgbot (developer)
2016-11-26 14:04

 Repository: erp/devel/pi
Changeset: 127865df93ddcdb773414120a0bbcae1bb7736c8
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Sat Nov 26 14:03:59 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/127865df93ddcdb773414120a0bbcae1bb7736c8 [^]

Fixes issue 34638, related with issue 33875: Reverts method visibility change

The DatabaseDataIO.writeDataForTableToXML method was made private because it was not being used by any class other than DatabaseDataIO inside dbsm, but I failed to notice that it was being used in an external module (Easy Extensible Attributes).

---
M src-db/database/lib/dbsourcemanager.jar
---
(0091876)
alostale (viewer)
2016-11-28 09:08

 code reviewed
(0092664)
hudsonbot (viewer)
2016-12-16 18:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2016-11-26 13:56 AugustoMauch New Issue
2016-11-26 13:56 AugustoMauch Assigned To => AugustoMauch
2016-11-26 13:56 AugustoMauch OBNetwork customer => No
2016-11-26 13:56 AugustoMauch Modules => Core
2016-11-26 13:56 AugustoMauch Triggers an Emergency Pack => No
2016-11-26 13:57 AugustoMauch Description Updated View Revisions
2016-11-26 13:57 AugustoMauch Relationship added caused by 0033875
2016-11-26 13:58 AugustoMauch Regression level => Automated tests
2016-11-26 13:58 AugustoMauch Regression date => 2016-11-25
2016-11-26 13:58 AugustoMauch Regression introduced in release => pi
2016-11-26 13:58 AugustoMauch Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/f169cafac730141372142a78fbc68e040c12b7c1 [^]
2016-11-26 14:03 hgbot Checkin
2016-11-26 14:03 hgbot Note Added: 0091865
2016-11-26 14:03 hgbot Status new => resolved
2016-11-26 14:03 hgbot Resolution open => fixed
2016-11-26 14:03 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/dbsm-main/rev/9ee6ed582c36f9a342f3afd2324dfc890ef34239 [^]
2016-11-26 14:04 AugustoMauch Review Assigned To => alostale
2016-11-26 14:04 hgbot Checkin
2016-11-26 14:04 hgbot Note Added: 0091867
2016-11-26 14:04 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/dbsm-main/rev/9ee6ed582c36f9a342f3afd2324dfc890ef34239 [^] => http://code.openbravo.com/erp/devel/pi/rev/127865df93ddcdb773414120a0bbcae1bb7736c8 [^]
2016-11-28 09:08 alostale Note Added: 0091876
2016-11-28 09:08 alostale Status resolved => closed
2016-11-28 09:08 alostale Fixed in Version => 3.0PR17Q1
2016-12-16 18:39 hudsonbot Checkin
2016-12-16 18:39 hudsonbot Note Added: 0092664

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker