0034606: [SER-QA 2049] Cannot cancel a partially paid layaway created in another terminal

Description

Trying to cancel a partially paid layaway created in a terminal that has no payment methods raises an exception in handlePayments() method of OrderLoader process. This error is not noticed by the cashier, it goes to the Errors while importing POS data table

Steps To Reproduce

* Consider two different terminals. For example in live builds have VBS1001 with all the payment methods and VBS1002 without any payment method. All payment methods must be removed in this terminal.
* Log in in VBS1002 and create a layaway
* Log in in VBS1001 and load the previously created layaway
* Pay it partially, not completely and layaway again
* Load again the partially paid layaway and tap on "Cancel this layaway" and complete the process.
* Log in in the backend and observe that the reversed order has not been created and in "Errors while importing POS Data" an error appears: org.openbravo.base.exception.OBException: CancelLayawayLoader.cancelOrder:

Proposed Solution

Exception is raised in this line: https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/e00544cc1618/src/org/openbravo/retail/posterminal/OrderLoader.java#l1876 [^]
The problem is that no Payment Type has been found because the function is looking for payment methods in the terminal where the original order was created that in our example is 1002, but here there is not any payment method.

Tags

SER-QA

Attached Files

Issue34606.diff [^] (955 bytes) 2016-11-25 23:19 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/erpCommon/businessUtility/CancelAndReplaceUtils.java b/src/org/openbravo/erpCommon/businessUtility/CancelAndReplaceUtils.java
--- a/src/org/openbravo/erpCommon/businessUtility/CancelAndReplaceUtils.java
+++ b/src/org/openbravo/erpCommon/businessUtility/CancelAndReplaceUtils.java
@@ -1016,7 +1016,8 @@
     FIN_FinancialAccount financialAccount = null;
     OrganizationStructureProvider osp = OBContext.getOBContext().getOrganizationStructureProvider(
         oldOrder.getOrganization().getClient().getId());
-    if (jsonorder != null) {
+    if (jsonorder != null && jsonorder.has("defaultPaymentType")
+        && jsonorder.getJSONObject("defaultPaymentType") != null) {
       paymentPaymentMethod = OBDal.getInstance().get(FIN_PaymentMethod.class,
           (String) jsonorder.getJSONObject("defaultPaymentType").get("paymentMethodId"));
       financialAccount = OBDal.getInstance().get(FIN_FinancialAccount.class,

Relationships [ Relation Graph ] [ Dependency Graph ]

duplicate of

defect

0034634

closed

asiermartirena

When doing a Cancel Layaway, the new order must have the terminal ID of the current terminal

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2016-11-23 13:41	adrianromero	New Issue
2016-11-23 13:41	adrianromero	Assigned To	=> Retail
2016-11-23 13:41	adrianromero	Resolution time	=> 1481065200
2016-11-23 13:41	adrianromero	Triggers an Emergency Pack	=> No
2016-11-23 13:46	adrianromero	Steps to Reproduce Updated	View Revisions
2016-11-23 13:46	adrianromero	Proposed Solution updated
2016-11-23 13:46	adrianromero	Proposed Solution updated
2016-11-23 13:46	adrianromero	Tag Attached: SER-QA
2016-11-23 13:59	adrianromero	Proposed Solution updated
2016-11-25 16:37	mario_castello	Assigned To	Retail => mario_castello
2016-11-25 16:38	mario_castello	Status	new => acknowledged
2016-11-25 16:38	mario_castello	Status	acknowledged => scheduled
2016-11-25 23:19	mario_castello	File Added: Issue34606.diff
2016-11-28 12:13	marvintm	Relationship added	duplicate of 0034634
2016-11-28 12:13	marvintm	Status	scheduled => closed
2016-11-28 12:13	marvintm	Resolution	open => duplicate