Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034465
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] StoreServermajorsometimes2016-11-10 16:512017-06-07 00:40
ReporterioritzCiaView Statuspublic 
Assigned ToAugustoMauch 
PrioritynormalResolutionfixedFixed in VersionRR17Q3
StatusclosedFix in branchFixed in SCM revision6c79086191e0
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava version8
OS VersionUbuntu 14.04Database version9.5Ant version1.9
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0034465: Initialize.bp.segmentation.tables does not take into account BPartners of gift card instances

DescriptionRegarding: http://wiki.openbravo.com/wiki/Projects:Store_Server_BP_Data_Segmentation [^]

You might have Business Partners you want to export to a store that do not have an order but they have a gift card

To check if more entities require this
Steps To Reproduce- Create a new Business Partner
- Create a Gift Card for a store and assign previous Business Partner
- Validate previous store

More precise steps can be detailed if required
Proposed SolutionAdd the following insert query into the InitializeBusinessPartnerSegmentationTables.java process


insert into obstsyn_server_bpartner(obstsyn_server_bpartner_id, ad_client_id, ad_org_id, isactive,
                                   createdby, updatedby, obmobc_server_definition_id, c_bpartner_id)
select get_uuid(), min(gc.ad_client_id), min(gc.ad_org_id), 'Y',
       '100', '100', so.obmobc_server_definition_id, gc.c_bpartner_id
from gcnv_giftcard_inst gc
  inner join obmobc_server_orgs so on (gc.ad_org_id = so.server_org_id)
  left join obstsyn_server_bpartner sbp on (sbp.c_bpartner_id = gc.c_bpartner_id)
where sbp.c_bpartner_id is null
group by gc.c_bpartner_id, so.obmobc_server_definition_id;
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0033727 newAugustoMauch Improve the initialization of the tables related with business partner segmentation 
related to defect 0035645 closedAugustoMauch Prevent invoking a commitAndClose inside an event handler 

-  Notes
(0093194)
dmitry_mezentsev (viewer)
2017-01-04 17:33

 Could you react to this issue, please?
1.5 months without any action.
(0094230)
mtaal (viewer)
2017-02-12 23:52

 Needed discussion with customer, reaction received in week of 8 February. Solution to be provided during February.
(0094231)
hgbot (developer)
2017-02-13 07:27

 Repository: erp/pmods/org.openbravo.retail.giftcards.synchronization
Changeset: bbb34f393c1062d14fc47afd146a8d3b4a3b9d17
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Feb 13 07:27:19 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards.synchronization/rev/bbb34f393c1062d14fc47afd146a8d3b4a3b9d17 [^]

Related to issue 34465: Initialize.bp.segmentation.tables does not take into account BPartners of gift card instances
Added a task to initialize bp segmentations from gift cards

---
A build.xml
A src/org/openbravo/retail/giftcards/synchronization/BusinessPartnerSegmentationPopulator_data.xsql
A src/org/openbravo/retail/giftcards/synchronization/InitializeBusinessPartnerSegmentationTables.java
---
(0095678)
hgbot (developer)
2017-03-29 19:31

 Repository: erp/pmods/org.openbravo.retail.giftcards.synchronization
Changeset: 6c79086191e0f45311c35925e0612c74cbc5afbd
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Mar 29 19:30:32 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards.synchronization/rev/6c79086191e0f45311c35925e0612c74cbc5afbd [^]

Related with issue 34465: Adds bp to store when giftcard instance is created

When a business partner is referenced in a giftcard instance, the new event handler will add the business partner to the referenced store if it is not already a customer.

Pending: do the same when the giftcard instance is created from the POS.

---
A src/org/openbravo/retail/giftcards/synchronization/eventhandler/GiftCardInstanceEventHandler.java
---
(0095694)
hgbot (developer)
2017-03-30 11:25

 Repository: erp/pmods/org.openbravo.retail.giftcards.synchronization
Changeset: 4be0e3d0c83f876b3cee2a5d2c31a4f1a13e7589
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Mar 30 11:24:40 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards.synchronization/rev/4be0e3d0c83f876b3cee2a5d2c31a4f1a13e7589 [^]

Related with issue 34465: Backs out previous changeset

The changeset 13:6c79086191e0 has been backed out, because it depends on another changeset that is not present on some environments when the giftcards.replication module is used.

---
R src/org/openbravo/retail/giftcards/synchronization/eventhandler/GiftCardInstanceEventHandler.java
---
(0096705)
hgbot (developer)
2017-05-22 12:36

 Repository: erp/pmods/org.openbravo.retail.giftcards.synchronization
Changeset: 364bb1affe07299590a496d61fdde86a85ee54b7
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Mar 29 19:30:32 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards.synchronization/rev/364bb1affe07299590a496d61fdde86a85ee54b7 [^]

Related with issue 34465: Adds bp to store when giftcard instance is created

When a business partner is referenced in a giftcard instance, the new event handler will add the business partner to the referenced store if it is not already a customer.

Pending: do the same when the giftcard instance is created from the POS.

---
A src/org/openbravo/retail/giftcards/synchronization/eventhandler/GiftCardInstanceEventHandler.java
---
(0097180)
mtaal (viewer)
2017-06-07 00:40

 Reviewed and tested

- Issue History
Date Modified Username Field Change
2016-11-10 16:51 ioritzCia New Issue
2016-11-10 16:51 ioritzCia Assigned To => StoreServer
2016-11-10 16:51 ioritzCia OBNetwork customer => Yes
2016-11-10 16:51 ioritzCia Triggers an Emergency Pack => No
2016-11-10 16:51 ioritzCia Description Updated View Revisions
2016-11-21 11:57 mtaal Assigned To StoreServer => AugustoMauch
2016-11-21 15:47 ioritzCia Resolution time => 1481756400
2017-01-04 17:33 dmitry_mezentsev Note Added: 0093194
2017-01-05 10:07 AugustoMauch Relationship added related to 0033727
2017-01-30 17:51 mtaal Assigned To AugustoMauch => mtaal
2017-02-12 23:51 mtaal Resolution time 1481756400 => 1488322800
2017-02-12 23:52 mtaal Note Added: 0094230
2017-02-13 07:27 hgbot Checkin
2017-02-13 07:27 hgbot Note Added: 0094231
2017-03-29 11:09 AugustoMauch Assigned To mtaal => AugustoMauch
2017-03-29 19:25 AugustoMauch Relationship added related to 0035645
2017-03-29 19:31 hgbot Checkin
2017-03-29 19:31 hgbot Note Added: 0095678
2017-03-30 11:25 hgbot Checkin
2017-03-30 11:25 hgbot Note Added: 0095694
2017-05-22 12:16 mtaal Review Assigned To => mtaal
2017-05-22 12:36 hgbot Checkin
2017-05-22 12:36 hgbot Note Added: 0096705
2017-05-22 18:28 AugustoMauch Status new => scheduled
2017-05-22 18:28 AugustoMauch Status scheduled => resolved
2017-05-22 18:28 AugustoMauch Resolution open => fixed
2017-05-22 18:28 AugustoMauch Fixed in SCM revision => https://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards.synchronization/rev/6c79086191e0f45311c35925e0612c74cbc5afbd [^]
2017-06-07 00:40 mtaal Note Added: 0097180
2017-06-07 00:40 mtaal Status resolved => closed
2017-06-07 00:40 mtaal Fixed in Version => RR17Q3

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker