Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034424
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2016-11-08 13:062016-12-16 08:41
ReporterxabiermerinoView Statuspublic 
Assigned Tomario_castello 
PriorityurgentResolutionfixedFixed in VersionRR17Q1
StatusclosedFix in branchFixed in SCM revision3e50299938f1
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2015-12-15
Regression introduced in releaseRR16Q1
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8b79e190a66eeea8fb8c2267ac219d3c1f47f690 [^]
Triggers an Emergency PackNo
Summary

0034424: [SERQA 2038] The admin role has no access to payment method

DescriptionThe admin role has no access to payment method
Steps To ReproduceThe admin role has no access to payment method. Steps:
- Log into backoffice
- Go to User window
- Select Openbravo
- Introduce a new role for Openbravo
- Go to Preference window
- Create a new preferece:
* Web POS payment Cash
* Value: N
* Role: New role introduced for Openbravo
- Log into webPOS with Openbravo
- Realize that Openbravo has access to the new role
- Try to pay a ticket
- Realize that you are not able to use Cash.
TagsSER-QA
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0034622RR16Q4 closedmario_castello [SERQA 2038] The admin role has no access to payment method 
depends on backport 0034623RR16Q3.4 closedmarvintm [SERQA 2038] The admin role has no access to payment method 

-  Notes
(0091565)
hgbot (developer)
2016-11-15 14:58
edited on: 2016-11-15 15:05

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2ca010346ce2db2b32cdc99846022f1376a9038c
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Mon Nov 14 09:06:23 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2ca010346ce2db2b32cdc99846022f1376a9038c [^]

Fixed issue 34424: Remove hql filter in query and validate each payment method with the preferences class

---
M src/org/openbravo/retail/posterminal/term/Payments.java
---
(0091794)
asiermartirena (viewer)
2016-11-24 18:15

 In this solution you have removed the p.$activeCriteria, being able now to load payment methods that are disabled.

Please, add it again and review if there is another missing criteria.
(0091795)
marvintm (viewer)
2016-11-24 18:28

 As Asier mentions in his comment, the readableSimpleCriteria and the activeCriteria were removed from the query, and this is wrong. They need to be added again.
(0091854)
hgbot (developer)
2016-11-25 15:21

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3e50299938f1e4d945ce4fde69dfa95f8bfe02ec
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Thu Nov 24 16:05:30 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3e50299938f1e4d945ce4fde69dfa95f8bfe02ec [^]

Fixed issue 34424: Added the readableSimpleCriteria and the activeCriteria in the hql query.

- Those hql filter were removed in the last changes.

---
M src/org/openbravo/retail/posterminal/term/Payments.java
---
(0091855)
hgbot (developer)
2016-11-25 15:26

 Repository: tools/automation/pi-mobile
Changeset: 93d62144745216628d4cc82f37ce1a68696882dd
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Tue Nov 22 14:29:07 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/93d62144745216628d4cc82f37ce1a68696882dd [^]

Verifies issue 34424: Added automated test I34424_VerifyRoleOrgAccessPaymentMethod and test I33730_VerifyRoleOrgAccess

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/loginout/I33730_VerifyRoleOrgAccess.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/loginout/I34424_VerifyRoleOrgAccessPaymentMethod.java
R src-test/org/openbravo/test/mobile/quarantine/pack/MCA/receipts/I33730_VerifyRoleOrgAccess.java
---
(0092119)
hgbot (developer)
2016-12-06 10:54

 Repository: retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal
Changeset: 4ba03aee27bfcf25e047e484d4037aaa1a9ec5e9
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Mon Nov 14 09:06:23 2016 -0600
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal/rev/4ba03aee27bfcf25e047e484d4037aaa1a9ec5e9 [^]

Related to issue 34622, backport of issue 34424: Remove hql filter in query and validate each payment metho with the preferences

---
M src/org/openbravo/retail/posterminal/term/Payments.java
---
(0092121)
hgbot (developer)
2016-12-06 10:54

 Repository: retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal
Changeset: 53473cabfc9c72678857c8b1498dea3b788534ca
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Thu Nov 24 16:05:30 2016 -0600
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal/rev/53473cabfc9c72678857c8b1498dea3b788534ca [^]

Related to issue 34622, backport of issue 34424: Added the readableSimpleCriteria and the activeCriteria in the hql query.

- Those hql filter were removed in the last changes.

---
M src/org/openbravo/retail/posterminal/term/Payments.java
---
(0092259)
hgbot (developer)
2016-12-09 15:20

 Repository: retail/backports/3.0RR16Q4/pi-mobile
Changeset: da7f66e2d13b860c3af7b788c45ad740ef52ab4e
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Wed Dec 07 11:39:16 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/pi-mobile/rev/da7f66e2d13b860c3af7b788c45ad740ef52ab4e [^]

Fixed issue 34622, backport of issue 34424: Add test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/offline/I33730_VerifyRoleOrgAccess.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/offline/I34424_VerifyRoleOrgAccessPaymentMethod.java
R src-test/org/openbravo/test/mobile/quarantine/pack/MCA/receipts/I33730_VerifyRoleOrgAccess.java
---
(0092451)
hgbot (developer)
2016-12-16 08:41

 Repository: tools/automation/pi-mobile
Changeset: da7f66e2d13b860c3af7b788c45ad740ef52ab4e
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Wed Dec 07 11:39:16 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/da7f66e2d13b860c3af7b788c45ad740ef52ab4e [^]

Fixed issue 34622, backport of issue 34424: Add test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/offline/I33730_VerifyRoleOrgAccess.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/offline/I34424_VerifyRoleOrgAccessPaymentMethod.java
R src-test/org/openbravo/test/mobile/quarantine/pack/MCA/receipts/I33730_VerifyRoleOrgAccess.java
---

- Issue History
Date Modified Username Field Change
2016-11-08 13:06 xabiermerino New Issue
2016-11-08 13:06 xabiermerino Assigned To => Retail
2016-11-08 13:06 xabiermerino OBNetwork customer => Yes
2016-11-08 13:06 xabiermerino Resolution time => 1479164400
2016-11-08 13:06 xabiermerino Triggers an Emergency Pack => No
2016-11-08 13:06 xabiermerino Tag Attached: SER-QA
2016-11-08 16:03 mario_castello Assigned To Retail => mario_castello
2016-11-08 21:48 mario_castello Status new => acknowledged
2016-11-15 14:58 hgbot Checkin
2016-11-15 14:58 hgbot Note Added: 0091565
2016-11-15 14:58 hgbot Status acknowledged => resolved
2016-11-15 14:58 hgbot Resolution open => fixed
2016-11-15 14:58 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2ca010346ce2db2b32cdc99846022f1376a9038c [^]
2016-11-15 15:05 mario_castello Note Edited: 0091565 View Revisions
2016-11-15 15:20 mario_castello Regression date => 2015-12-15
2016-11-15 15:20 mario_castello Regression introduced in release => RR16Q1
2016-11-15 15:20 mario_castello Regression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8b79e190a66eeea8fb8c2267ac219d3c1f47f690 [^]
2016-11-24 18:15 asiermartirena Note Added: 0091794
2016-11-24 18:28 marvintm Note Added: 0091795
2016-11-24 18:28 marvintm Status resolved => new
2016-11-24 18:28 marvintm Resolution fixed => open
2016-11-24 20:22 marvintm Status new => scheduled
2016-11-25 15:21 hgbot Checkin
2016-11-25 15:21 hgbot Note Added: 0091854
2016-11-25 15:21 hgbot Status scheduled => resolved
2016-11-25 15:21 hgbot Resolution open => fixed
2016-11-25 15:21 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2ca010346ce2db2b32cdc99846022f1376a9038c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3e50299938f1e4d945ce4fde69dfa95f8bfe02ec [^]
2016-11-25 15:26 hgbot Checkin
2016-11-25 15:26 hgbot Note Added: 0091855
2016-11-25 15:31 marvintm Review Assigned To => marvintm
2016-11-25 15:31 marvintm Status resolved => closed
2016-11-25 15:31 marvintm Fixed in Version => RR17Q1
2016-12-06 10:54 hgbot Checkin
2016-12-06 10:54 hgbot Note Added: 0092119
2016-12-06 10:54 hgbot Checkin
2016-12-06 10:54 hgbot Note Added: 0092121
2016-12-07 11:46 marvintm Regression level => Production - Confirmed Stable
2016-12-09 15:20 hgbot Checkin
2016-12-09 15:20 hgbot Note Added: 0092259
2016-12-16 08:41 hgbot Checkin
2016-12-16 08:41 hgbot Note Added: 0092451

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker