0033979: Taxes in the cashup invoice are not calculated properly if the tax is marked as document level

Description

Since 16Q2, the Web POS can calculate taxes at document level. This works correctly in the client side, when computing taxes for individual orders.

However, in the cashup, there is currently a problem in the way the taxes at header level are computed. These taxes should be calculated by summing the taxes at header level from the orders, and instead, they are being calculated by summing the taxes at line level. This can lead to inconsistencies derived from the fact that rounding is different if done in this way.

Steps To Reproduce

- Configure taxes to be calculated at document level.
- Log in the Web POS. Create some orders. Do the cashup.
- Verify that the taxes computed at header level for the generated invoice do not sum the same amount as the taxes at header level of the orders. This is wrong.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0033978

closed

marvintm

Taxes in the cashup invoice are not calculated properly if the tax is marked as document level

Notes
(0090188) hgbot (developer) 2016-09-23 09:41	Repository: retail/backports/3.0RR16Q3.2/org.openbravo.retail.posterminal Changeset: 2e71c3279bdcc9e0bd89f6ee00b3e5e14cd46e07 Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Fri Sep 23 09:40:45 2016 +0200 URL: http://code.openbravo.com/retail/backports/3.0RR16Q3.2/org.openbravo.retail.posterminal/rev/2e71c3279bdcc9e0bd89f6ee00b3e5e14cd46e07 [^] Fixed issue 33979. Taxes configured to be calculated at document level will be computed correctly. The root cause of the problem was that the taxes at document level of the invoice generated during the cashup were computed by summing the taxes from the orders at line level, and this was not correct. Now the taxes at document level of the invoice are computed by summing the taxes at document level of the orders. --- M src/org/openbravo/retail/posterminal/OrderGroupingProcessor_data.xsql ---

Issue History
Date Modified	Username	Field	Change
2016-09-14 08:56	marvintm	Type	defect => backport
2016-09-14 08:56	marvintm	Target Version	=> RR16Q3.2
2016-09-23 09:41	hgbot	Checkin
2016-09-23 09:41	hgbot	Note Added: 0090188
2016-09-23 09:41	hgbot	Status	scheduled => resolved
2016-09-23 09:41	hgbot	Resolution	open => fixed
2016-09-23 09:41	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/retail/backports/3.0RR16Q3.2/org.openbravo.retail.posterminal/rev/2e71c3279bdcc9e0bd89f6ee00b3e5e14cd46e07 [^]
2016-09-26 19:00	guilleaer	Review Assigned To	=> guilleaer
2016-09-26 19:00	guilleaer	Status	resolved => closed
2016-09-26 19:00	guilleaer	Fixed in Version	=> RR16Q3.2