Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0033792 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Openbravo ERP] A. Platform | major | always | 2016-08-24 13:03 | 2016-12-16 18:39 | |||
Reporter | caristu | View Status | public | |||||
Assigned To | inigosanchez | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR17Q1 | |||
Status | closed | Fix in branch | Fixed in SCM revision | de50252ad892 | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | ||||||||
Review Assigned To | caristu | |||||||
OBNetwork customer | No | |||||||
Web browser | ||||||||
Modules | Core | |||||||
Support ticket | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0033792: In P&E windows, filter drop down options disappear under some circumstances | |||||||
Description | In P&E windows, filter drop down options disappear after removing an existing filter, having selected records. | |||||||
Steps To Reproduce | 0) Go to the [Return From Customer] window and create a new return with one line at least. 1) Book the created record. 2) Go to the [Return Material Receipt] window. 3) Create a new record in the header and click in the P&E lines button. 4) Select one record and push "Done" button. 5) Select the same record in the header and click in the P&E lines button again. 6) Choice an option in the Product filter drop-down. 7) Click on the funnel to remove the filter. 8) Click again on the Product filter drop-down, notice that no results are returned. | |||||||
Proposed Solution | The request fired on step 8) is not correct. It is causing the generation of a wrong query in the datasource (the main alias is changed, see attached). The request must be correct, it should be decided if: a) The selected records are included in the request fired by the filter drop-down b) The _OrExpression parameter should be removed from this kind of requests (this parameter is causing the change in the main alias name in the backend) | |||||||
Tags | No tags attached. | |||||||
Attached Files | ![]() ![]() | |||||||
![]() |
|
![]() |
|
(0091730) inigosanchez (viewer) 2016-11-22 10:53 |
Testcases (Tested in P&E Lines of Return Material Receipt window): -Open the filter dropdown of the Product field with a value selected in Product field (Product ==Cerveza Ale 0,5L). -Open the filter dropdown of the Product field with a value selected in other field without filter dropdown (Line No. ==10). -Open the filter dropdown of the Product field with a value selected in other field with filter dropdown (Storage Bin ==RN-Dev). Three cases should displayed filter dropdown options. |
(0091765) hgbot (developer) 2016-11-23 15:39 |
Repository: erp/devel/pi Changeset: de50252ad892299861a3120e97502cd74e96c4d9 Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com> Date: Wed Nov 23 15:32:15 2016 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/de50252ad892299861a3120e97502cd74e96c4d9 [^] Fixed issue 33792:In P&E windows, filter drop down options disappear sometimes The problem was in P&E windows using filter dropdown. First time all were working fine but the second time, when filter dropdown was open and a filter option was previously selected, filter dropdown options were disappear. To reproduce this problem it was necessary to have a selected record in P&E. When filter dropdown options were disappear, the request had some extra parameters. This extra parameters were a problem in order to build the query properly. These were the extra parameters: _constructor:AdvancedCriteria _OrExpression:true operator:or At the end these parameters build a bad query because main alias was not managed properly in the server side. As a result of the operator parameter (operator:or) main alias was not use properly. The query was built poorly due to the aliases. To solve the problem now, when cleanCriteria function is executed, it is also executed cleanOrCriterion function in order to clean criteria properly. --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-fk-filter.js --- |
(0091766) hgbot (developer) 2016-11-23 15:42 |
Repository: erp/devel/pi Changeset: ce7a1af484d7d12db3aea516d73d526ec63dd02d Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com> Date: Wed Nov 23 15:41:24 2016 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/ce7a1af484d7d12db3aea516d73d526ec63dd02d [^] Related with issue 33792: Applied JSBeautifier properly --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-fk-filter.js --- |
(0091818) hgbot (developer) 2016-11-25 10:02 |
Repository: erp/devel/pi Changeset: 5befe78d2de5f63abf1970a1bc7d679011d7e3e5 Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com> Date: Fri Nov 25 10:01:39 2016 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/5befe78d2de5f63abf1970a1bc7d679011d7e3e5 [^] Related with issue 33792: Improve a comment and update copyright --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-fk-filter.js --- |
(0091819) inigosanchez (viewer) 2016-11-25 10:29 |
A test suite in testlink is created. See tests in Platform > Summary, Grouping and Filter > Filter > [FPE] Filter dropdown options in P&E. |
(0091833) caristu (viewer) 2016-11-25 11:47 |
Code reviewed + testing OK: filter drop-down options are correctly displayed. |
(0092651) hudsonbot (viewer) 2016-12-16 18:38 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^] Maturity status: Test |
(0092652) hudsonbot (viewer) 2016-12-16 18:38 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^] Maturity status: Test |
(0092659) hudsonbot (viewer) 2016-12-16 18:39 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^] Maturity status: Test |
![]() |
|||
Date Modified | Username | Field | Change |
2016-08-24 13:03 | caristu | New Issue | |
2016-08-24 13:03 | caristu | Assigned To | => platform |
2016-08-24 13:03 | caristu | OBNetwork customer | => No |
2016-08-24 13:03 | caristu | Modules | => Core |
2016-08-24 13:03 | caristu | Triggers an Emergency Pack | => No |
2016-08-24 13:04 | caristu | File Added: queryGood.txt | |
2016-08-24 13:04 | caristu | File Added: queryBad.txt | |
2016-08-24 13:05 | caristu | Description Updated | View Revisions |
2016-08-24 13:05 | caristu | Description Updated | View Revisions |
2016-10-24 16:01 | inigosanchez | Assigned To | platform => inigosanchez |
2016-10-24 16:01 | inigosanchez | Status | new => scheduled |
2016-10-24 17:01 | inigosanchez | Steps to Reproduce Updated | View Revisions |
2016-10-24 17:01 | inigosanchez | Proposed Solution updated | |
2016-11-22 10:53 | inigosanchez | Note Added: 0091730 | |
2016-11-23 15:36 | inigosanchez | Review Assigned To | => caristu |
2016-11-23 15:39 | hgbot | Checkin | |
2016-11-23 15:39 | hgbot | Note Added: 0091765 | |
2016-11-23 15:39 | hgbot | Status | scheduled => resolved |
2016-11-23 15:39 | hgbot | Resolution | open => fixed |
2016-11-23 15:39 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/de50252ad892299861a3120e97502cd74e96c4d9 [^] |
2016-11-23 15:42 | hgbot | Checkin | |
2016-11-23 15:42 | hgbot | Note Added: 0091766 | |
2016-11-25 10:02 | hgbot | Checkin | |
2016-11-25 10:02 | hgbot | Note Added: 0091818 | |
2016-11-25 10:29 | inigosanchez | Note Added: 0091819 | |
2016-11-25 11:47 | caristu | Note Added: 0091833 | |
2016-11-25 11:47 | caristu | Status | resolved => closed |
2016-11-25 11:47 | caristu | Fixed in Version | => 3.0PR17Q1 |
2016-12-16 18:38 | hudsonbot | Checkin | |
2016-12-16 18:38 | hudsonbot | Note Added: 0092651 | |
2016-12-16 18:38 | hudsonbot | Checkin | |
2016-12-16 18:38 | hudsonbot | Note Added: 0092652 | |
2016-12-16 18:39 | hudsonbot | Checkin | |
2016-12-16 18:39 | hudsonbot | Note Added: 0092659 |
Copyright © 2000 - 2009 MantisBT Group |