Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0033704
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2016-08-12 17:072016-08-24 15:35
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in Version3.0PR16Q4
StatusclosedFix in branchFixed in SCM revision4289cc0c5136
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0033704: Accidental double query in 'selector dropdown' of new style selectors

DescriptionThe SelectorDataSourceFilter class does call .count() + then .list() on a OBCriteria running the sql query twice once with count(*) + then again to list the fields
Steps To Reproduce1.) Sales Order window
2.) new in form view
3.) open selector 'dropdown' of business partner selector
4.) review queries done in step 3
Proposed Solution-
TagsPerformance
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0033706 closedshuehner SelectorDataSourceFilter does accidental extra queries in 'Add Payment' flow of Sales Orders 
related to feature request 0033767 closedplatform Add code to auto-detect 'accidental double query' on same OBQuery or OBCriteria object 
related to defect 0033772 closedshuehner Accidental double query in SelectorDefaultFilterActionHandler 
related to design defect 0036898 newTriage Finance Performance issues when using DAL 

-  Notes
(0089302)
hgbot (developer)
2016-08-23 14:32

 Repository: erp/devel/pi
Changeset: 4289cc0c51368d9fc41140ccb650f6130cdefc84
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Fri Aug 12 17:08:13 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4289cc0c51368d9fc41140ccb650f6130cdefc84 [^]

Fixed 33704. Remove double query by saving .list() result

instead of calling .count() and then .list() which does 2 selects for the same.

---
M modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorDataSourceFilter.java
---
(0089351)
caristu (viewer)
2016-08-24 15:35

 Code review + testing OK: when opening the drop-down selector now one query is used to retrieve the selector fields when applying the default expressions.

- Issue History
Date Modified Username Field Change
2016-08-12 17:07 shuehner New Issue
2016-08-12 17:07 shuehner Assigned To => shuehner
2016-08-12 17:07 shuehner OBNetwork customer => No
2016-08-12 17:07 shuehner Modules => Core
2016-08-12 17:07 shuehner Triggers an Emergency Pack => No
2016-08-12 17:36 shuehner Relationship added related to 0033706
2016-08-12 18:09 shuehner Tag Attached: Performance
2016-08-23 14:32 hgbot Checkin
2016-08-23 14:32 hgbot Note Added: 0089302
2016-08-23 14:32 hgbot Status new => resolved
2016-08-23 14:32 hgbot Resolution open => fixed
2016-08-23 14:32 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4289cc0c51368d9fc41140ccb650f6130cdefc84 [^]
2016-08-23 14:34 shuehner Review Assigned To => caristu
2016-08-23 14:44 shuehner Relationship added related to 0033767
2016-08-23 17:20 shuehner Relationship added related to 0033772
2016-08-24 15:35 caristu Note Added: 0089351
2016-08-24 15:35 caristu Status resolved => closed
2016-08-24 15:35 caristu Fixed in Version => 3.0PR16Q4
2017-09-19 18:49 markmm82 Relationship added related to 0036898

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker