Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0033703 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2016-08-12 17:00 | 2016-08-24 15:28 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR16Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | b05271bc5119 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | caristu | |||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0033703: Accidental double query in View generation | |||||||
| Description | View generation (i.e. first open of Sales Order window) trigger double query by calling .list() twice in DatasourceServiceProvider: - if (!qTable.list().isEmpty()) { - Table table = qTable.list().get(0); | |||||||
| Steps To Reproduce | - | |||||||
| Tags | Performance | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0089301) hgbot (developer) 2016-08-23 14:32 |
Repository: erp/devel/pi Changeset: b05271bc5119125620ebed83117b57a7c42729af Author: Stefan Hühner <stefan.huehner <at> openbravo.com> Date: Fri Aug 12 17:02:22 2016 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/b05271bc5119125620ebed83117b57a7c42729af [^] Fixed 33703. Avoid double query by using .uniqueResult instead of twice .list() --- M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServiceProvider.java --- |
|
(0089350) caristu (viewer) 2016-08-24 15:28 |
Code review + testing OK: now using just one query to retrieve the table using its name on getDataSourceFromTableName() method |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2016-08-12 17:00 | shuehner | New Issue | |
| 2016-08-12 17:00 | shuehner | Assigned To | => shuehner |
| 2016-08-12 17:00 | shuehner | OBNetwork customer | => No |
| 2016-08-12 17:00 | shuehner | Modules | => Core |
| 2016-08-12 17:00 | shuehner | Triggers an Emergency Pack | => No |
| 2016-08-12 17:01 | shuehner | Tag Attached: Performance | |
| 2016-08-23 14:32 | hgbot | Checkin | |
| 2016-08-23 14:32 | hgbot | Note Added: 0089301 | |
| 2016-08-23 14:32 | hgbot | Status | new => resolved |
| 2016-08-23 14:32 | hgbot | Resolution | open => fixed |
| 2016-08-23 14:32 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/b05271bc5119125620ebed83117b57a7c42729af [^] |
| 2016-08-23 14:33 | shuehner | Review Assigned To | => caristu |
| 2016-08-23 14:44 | shuehner | Relationship added | related to 0033767 |
| 2016-08-24 15:28 | caristu | Note Added: 0089350 | |
| 2016-08-24 15:28 | caristu | Status | resolved => closed |
| 2016-08-24 15:28 | caristu | Fixed in Version | => 3.0PR16Q4 |
| 2017-09-19 18:48 | markmm82 | Relationship added | related to 0036898 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |