Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0033104 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | major | always | 2016-06-01 14:34 | 2016-06-28 11:28 | |||
| Reporter | guillermogil | View Status | public | |||||
| Assigned To | mario_castello | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 6b6a0d63155d | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | marvintm | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0033104: Import Entry Post Processor does not get called if the entity goes to errors while importing | |||||||
| Description | If you click "Save Again" button on Errors while importing and the Order/Cash Up/Cash Management gets imported properly it should call to that Entity Post Processor. Right now there are several workflows implemented that are not getting sync due to this bug. | |||||||
| Steps To Reproduce | On a local environment with debugging enabled: * Close the current period * Login on WebPOS * Add an Avalanche Transceiver * Pay it totally * Go to errors while importing window on the backend Verify that the Order is there * Go to Eclipse * Put a Breakpoint on Import Entry Post Processor * Go to the backend select the previously created error and click "Save Again" button Verify that Import Entry Post Processor does not get call. | |||||||
| Proposed Solution | On Save call to Import Entry Post Processor. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||
|
|||||||||
 Relationships |
|
Notes |
|
|
(0087638) hgbot (developer) 2016-06-17 20:32 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 6b6a0d63155d0e41c4bcecabd6b49632c6c13ea2 Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Thu Jun 16 08:52:09 2016 -0600 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6b6a0d63155d0e41c4bcecabd6b49632c6c13ea2 [^] Fixed issue 33104: Added ImportEntryPostProcessor in saveDataAction process to execute the entry post process --- M src/org/openbravo/retail/posterminal/SaveDataActionHandler.java --- |
|
(0088019) hgbot (developer) 2016-06-28 11:21 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: d81183367c8ff1474294ded8d8ae7aa4a0917c11 Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Tue Jun 28 08:44:27 2016 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d81183367c8ff1474294ded8d8ae7aa4a0917c11 [^] Related to issue 33104. Two changes have been made: - ImportEntry will not be committed before the record is processed. This means in turn that if the record fails with error, then it will be rolled back. If it is processed correctly, it will be finally committed directly in processed status. - Hooks will not be executed if the process fails with error. --- M src/org/openbravo/retail/posterminal/SaveDataActionHandler.java --- |
|
(0088020) hgbot (developer) 2016-06-28 11:28 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: a13bead4c824861b783c49af93b64190b52bf791 Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Tue Jun 28 11:28:27 2016 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a13bead4c824861b783c49af93b64190b52bf791 [^] Related to issue 33104. Two additional changes: - Removed outdated comment. - Now import entry will be marked as processed before the record is executed. This will avoid the problem of having a very short but real amount of time in which the record has been processed, and the import entry is committed with status Initial, which could theoretically trigger a second processing action of the import entry by the thread. This problem would have happened because the execution of the process already commits the transaction at the end, if everything works well. --- M src/org/openbravo/retail/posterminal/SaveDataActionHandler.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2016-06-01 14:34 | guillermogil | New Issue | |
| 2016-06-01 14:34 | guillermogil | Assigned To | => Retail |
| 2016-06-01 14:34 | guillermogil | Resolution time | => 1465941600 |
| 2016-06-01 14:34 | guillermogil | Triggers an Emergency Pack | => No |
| 2016-06-01 15:44 | Orekaria | Status | new => acknowledged |
| 2016-06-15 18:20 | mario_castello | Assigned To | Retail => mario_castello |
| 2016-06-17 20:32 | hgbot | Checkin | |
| 2016-06-17 20:32 | hgbot | Note Added: 0087638 | |
| 2016-06-17 20:32 | hgbot | Status | acknowledged => resolved |
| 2016-06-17 20:32 | hgbot | Resolution | open => fixed |
| 2016-06-17 20:32 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6b6a0d63155d0e41c4bcecabd6b49632c6c13ea2 [^] |
| 2016-06-19 11:31 | marvintm | Review Assigned To | => marvintm |
| 2016-06-19 11:31 | marvintm | Status | resolved => closed |
| 2016-06-28 11:21 | hgbot | Checkin | |
| 2016-06-28 11:21 | hgbot | Note Added: 0088019 | |
| 2016-06-28 11:28 | hgbot | Checkin | |
| 2016-06-28 11:28 | hgbot | Note Added: 0088020 | |
| 2019-06-17 17:15 | caristu | Relationship added | related to 0041109 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |