Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0033003 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | always | 2016-05-19 17:47 | 2016-08-11 18:40 | |||
| Reporter | JONHM | View Status | public | |||||
| Assigned To | NaroaIriarte | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR16Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | f95207ec63c8 | ||||
| Projection | none | ETA | none | Target Version | 3.0PR16Q4 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | alostale | |||||||
| OBNetwork customer | OBPS | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | 41918 | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0033003: Wrong titles exported to CSV when using a property field | |||||||
| Description | When using a property field to define a column on a window, the names of the columns with this properties are exported incorrectly. | |||||||
| Steps To Reproduce | 1) Create a window associated with C_OrderLine table and add two columns with the properties "salesOrder.partnerAddress.name" and "salesOrder.invoiceAddress.name", named "Ship Order Details" and "Sales Order Details" respectively, and name this window "Sales Order Details". 2) Add that window to the menu. 3) Go to "Sales Order Details" window 4) Export to CSV Notice that some names related to property fields are exported incorrectly. *** Window created in attached module | |||||||
| Proposed Solution | The problem is caused because finally both property fields are referencing exactly the same physical column. Because of the following line[1], the second property field is retrieving exactly the same name as the first one. At that point perhaps a special check for the property fields should be performed. [1] https://code.openbravo.com/erp/devel/pi/file/18ae3b2d8cb2/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java#l442 [^] | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  org.openbravo.changenames-1.0.0.obx [^] (6,812 bytes) 2016-05-19 17:47 issue33003.export [^] (2,656 bytes) 2016-06-29 18:11 | |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0086714) johnfandl (viewer) 2016-05-24 18:36 |
This is not minor from the customer perspective - appears as incorrect data and erodes confidence in the system. |
|
(0088172) hgbot (developer) 2016-07-04 12:36 |
Repository: erp/devel/pi Changeset: f95207ec63c82ea1dcdb06a3ee8556d8a7d451c4 Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com> Date: Wed Jun 29 18:10:10 2016 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/f95207ec63c82ea1dcdb06a3ee8556d8a7d451c4 [^] Fixed issue 33003: The titles in the CSV were wrong If there was a property field, the titles of those columns were wrong when exporting to csv. The problem was in the QueryJSONWriterToCSV inner class of the DataSourceServlet class. Here wher exporting to csv there was only taking into account if the column of the field was the same of the column checked in the iteration. The problem occurs when there are two or more fields which have the same column. Now the condition has been changed, first it checks if the current field is a property field and if the property is the one we really want. --- M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java --- |
|
(0088315) hgbot (developer) 2016-07-08 08:53 |
Repository: erp/devel/pi Changeset: 1b092d650f495d6111bcca837b0d39d93a3f5f03 Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Fri Jul 08 08:52:33 2016 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/1b092d650f495d6111bcca837b0d39d93a3f5f03 [^] related to bug 33003: small code style changes - Renamed formatedPropKey to formattedPropKey - formattedPropKey does not need to be initialized with "" if it is always assigned with the correct value --- M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java --- |
|
(0088316) alostale (viewer) 2016-07-08 08:54 |
tested code reviewed: applied 2 small refactors |
|
(0088985) hudsonbot (viewer) 2016-08-11 18:40 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/edaa05b1fb18 [^] Maturity status: Test |
|
(0089000) hudsonbot (viewer) 2016-08-11 18:40 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/edaa05b1fb18 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2016-05-19 17:47 | JONHM | New Issue | |
| 2016-05-19 17:47 | JONHM | Assigned To | => platform |
| 2016-05-19 17:47 | JONHM | File Added: org.openbravo.changenames-1.0.0.obx | |
| 2016-05-19 17:47 | JONHM | OBNetwork customer | => Yes |
| 2016-05-19 17:47 | JONHM | Modules | => Core |
| 2016-05-19 17:47 | JONHM | Support ticket | => 41918 |
| 2016-05-19 17:47 | JONHM | Triggers an Emergency Pack | => No |
| 2016-05-24 18:36 | johnfandl | Note Added: 0086714 | |
| 2016-06-21 16:58 | caristu | Proposed Solution updated | |
| 2016-06-21 16:58 | caristu | Status | new => acknowledged |
| 2016-06-23 10:10 | NaroaIriarte | Assigned To | platform => NaroaIriarte |
| 2016-06-27 13:11 | NaroaIriarte | Status | acknowledged => scheduled |
| 2016-06-29 12:32 | NaroaIriarte | File Added: issue33003.export | |
| 2016-06-29 16:14 | caristu | Target Version | => 3.0PR16Q4 |
| 2016-06-29 18:11 | NaroaIriarte | File Deleted: issue33003.export | |
| 2016-06-29 18:11 | NaroaIriarte | File Added: issue33003.export | |
| 2016-07-04 12:36 | hgbot | Checkin | |
| 2016-07-04 12:36 | hgbot | Note Added: 0088172 | |
| 2016-07-04 12:36 | hgbot | Status | scheduled => resolved |
| 2016-07-04 12:36 | hgbot | Resolution | open => fixed |
| 2016-07-04 12:36 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/f95207ec63c82ea1dcdb06a3ee8556d8a7d451c4 [^] |
| 2016-07-07 09:17 | NaroaIriarte | Review Assigned To | => alostale |
| 2016-07-08 08:53 | hgbot | Checkin | |
| 2016-07-08 08:53 | hgbot | Note Added: 0088315 | |
| 2016-07-08 08:54 | alostale | Note Added: 0088316 | |
| 2016-07-08 08:54 | alostale | Status | resolved => closed |
| 2016-07-08 08:54 | alostale | Fixed in Version | => 3.0PR16Q4 |
| 2016-08-11 18:40 | hudsonbot | Checkin | |
| 2016-08-11 18:40 | hudsonbot | Note Added: 0088985 | |
| 2016-08-11 18:40 | hudsonbot | Checkin | |
| 2016-08-11 18:40 | hudsonbot | Note Added: 0089000 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |