0032929: Wrong approval message when returning services using verified returns

Description

When the user tries to return a ticket which includes services, and the user requires an approval to return these services, the following message is shown:
"A supervisor needs to approve the return of the following services:%0"

Instead of the %0, the service to be returned should be shown.

Steps To Reproduce

Configure the preference Web POS Service Return Approval with value N for the vallblanca user.
Configure the preference Web POS Service Return Approval with value Y for the Openbravo user.
Login in web pos with user vallblanca and create a ticket with the following products:
*Avalanche transceiver classic.
*Phone consulting MK-2 (related to the first line).
Pay the ticket.
Go to the menu > Verified returns and select the ticket created previously.
Select both products and click on apply.
Verify that the approval is required and the message shown is not correct.

Tags

No tags attached.

Attached Files

Issue32929.diff [^] (992 bytes) 2016-06-27 12:52 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.posterminal/js/model/order.js b/web/org.openbravo.retail.posterminal/js/model/order.js
--- a/web/org.openbravo.retail.posterminal/js/model/order.js
+++ b/web/org.openbravo.retail.posterminal/js/model/order.js
@@ -1468,7 +1468,11 @@
       if (((options && options.line) ? options.line.get('qty') + qty : qty) < 0 && p.get('productType') === 'S') {
         OB.UTIL.showLoading(false);
         OB.UTIL.Approval.requestApproval(
-        OB.MobileApp.view.$.containerWindow.getRoot().model, 'OBPOS_approval.returnService', function (approved, supervisor, approvalType) {
+        OB.MobileApp.view.$.containerWindow.getRoot().model, [{
+          approval: 'OBPOS_approval.returnService',
+          message: 'OBPOS_approval.returnService',
+          params: ['<br>· ' + p.get('_identifier')]
+        }], function (approved, supervisor, approvalType) {
           OB.UTIL.showLoading(true);
           if (approved) {
             addProductToOrder();

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0033364

closed

ranjith_qualiantech_com

[SERQA 1297] Returning services using verified returns is not working fine

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2016-05-11 12:46	aaroncalero	New Issue
2016-05-11 12:46	aaroncalero	Assigned To	=> aaroncalero
2016-05-11 12:46	aaroncalero	OBNetwork customer	=> No
2016-05-11 12:46	aaroncalero	Triggers an Emergency Pack	=> No
2016-05-11 13:01	aaroncalero	Steps to Reproduce Updated	View Revisions
2016-06-27 12:49	aaroncalero	Relationship added	blocks 0033364
2016-06-27 12:49	aaroncalero	Assigned To	aaroncalero => Retail
2016-06-27 12:52	aaroncalero	File Added: Issue32929.diff