Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0032812
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajoralways2016-04-29 10:182016-06-17 19:37
ReporteraferrazView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in Version3.0PR16Q3
StatusclosedFix in branchFixed in SCM revision675c7958899a
ProjectionnoneETAnoneTarget Version3.0PR16Q3
OSLinux 64 bitDatabasePostgreSQLJava version1.6.0_18
OS VersionProfessional ApplianceDatabase version8.3.9Ant version1.7.1
Product VersionSCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0032812: When filtering in a process definition selector, ad_org_id parameter should be used if exists instead of login organization

DescriptionWhen a parameter inside a process definition has a validation referencing ad_org_id parameter of the same process definition, datasource is also filtering by login organization (In the request an _org parameter is sent with the context organization UUID). This affects to the validation as it changes its original condition.
Steps To Reproduce- Login as System Admin.
- Install "Multi-Dimensional Profit And Loss Report" module and dependencies.
- Navigate to "Multi-Dimensional Profit And Loss Process" process definition.
- Select "General Ledger" parameter.
- Navigate to "ElementsAccessibleByOrganization" validation and check the code:
"(ad_isorgincluded('" + OB.getParameters().get('AD_Org_ID') + "',e.organization.id, e.client.id) <> -1 or ad_isorgincluded(e.organization.id,'" + OB.getParameters().get('AD_Org_ID') + "', e.client.id) <> -1)"

- Login as F&B Admin and "F&B España - Región Norte" organization.
- Launch "Multi-Dimensional Profit And Loss" report.
- Select "F&B España - Región Norte" organization and realize both "F&B España, S.A. US/A/Euro" and "F&B International Group US/A/US Dollar" general ledgers appear in the combo. This is correct.
- Select "F&B US East Coast" organization and realize only "F&B International Group US/A/US Dollar" general ledger appears in the combo. This is correct.

- Login as F&B Admin and "F&B US East Coast" organization.
- Launch Multi-Dimensional Profit And Loss report.
- Select "F&B US East Coast" organization and realize only "F&B International Group US/A/US Dollar" general ledger appears in the combo. This is correct.
- Select "F&B España - Región Norte" organization and realize only "F&B International Group US/A/US Dollar" general ledger appears in the combo. This is NOT correct as it should appear both "F&B España, S.A. US/A/Euro" and "F&B International Group US/A/US Dollar" general ledgers.
Proposed SolutionProblem is that a filter by login organization is being added to general ledger validation code.

In case an ad_org_id parameter exists in the process definition, it should be used instead of login organization.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00325353.0PR16Q3 closedmarkmm82 Report's currency and report's general ledger should be defaulted to organization's currency and organization's general ledger 

-  Notes
(0086155)
hgbot (developer)
2016-05-03 14:02

 Repository: erp/devel/pi
Changeset: 675c7958899ad6cf970fa1347ce4123446ec1fda
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue May 03 09:31:56 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/675c7958899ad6cf970fa1347ce4123446ec1fda [^]

fixed bug 32812: selector filter in P&E should use AD_Org_ID param if present

  When filtering data for a selector in a P&E window and this window has an AD_Org_ID
  param, it should be used for filtering instead of current session's organization.

  Logic to do it was already pressent, but it was looking for the parameter name in lower
  case, which is correct for standard windows but might not be for P&E depending on how
  the parameter was defined.

---
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
(0086213)
caristu (developer)
2016-05-05 13:37

 Code review + testing OK.
(0087511)
hudsonbot (developer)
2016-06-17 19:37

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2016-04-29 10:18 aferraz New Issue
2016-04-29 10:18 aferraz Assigned To => platform
2016-04-29 10:18 aferraz Modules => Core
2016-04-29 10:18 aferraz Triggers an Emergency Pack => No
2016-04-29 10:22 aferraz Relationship added related to 0032535
2016-04-29 10:24 caristu Description Updated View Revisions
2016-04-29 10:24 caristu Description Updated View Revisions
2016-05-02 12:25 maite Resolution time => 1462399200
2016-05-03 09:36 alostale Status new => scheduled
2016-05-03 09:36 alostale Assigned To platform => alostale
2016-05-03 14:02 hgbot Checkin
2016-05-03 14:02 hgbot Note Added: 0086155
2016-05-03 14:02 hgbot Status scheduled => resolved
2016-05-03 14:02 hgbot Resolution open => fixed
2016-05-03 14:02 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/675c7958899ad6cf970fa1347ce4123446ec1fda [^]
2016-05-03 14:03 alostale Review Assigned To => caristu
2016-05-05 13:37 caristu Note Added: 0086213
2016-05-05 13:37 caristu Status resolved => closed
2016-05-05 13:37 caristu Fixed in Version => 3.0PR16Q3
2016-06-17 19:37 hudsonbot Checkin
2016-06-17 19:37 hudsonbot Note Added: 0087511

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker