Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0032729
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 07. Sales managementmajoralways2016-04-20 14:072018-02-22 18:18
ReportermaiteView Statuspublic 
Assigned ToAtulOpenbravo 
PriorityurgentResolutionfixedFixed in Version3.0PR16Q3
StatusclosedFix in branchFixed in SCM revision0a36e7951257
ProjectionnoneETAnoneTarget Version3.0PR16Q3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket41411
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0032729: Invoices not properly grouped by order in case shipment lines are not ordered by order in shipment document

DescriptionWhen 2 sales orders (from a business partner defined with "Invoice grouping= by order") are related with 1 goods shipment, more invoices than order are generated in case lines from same order are not consecutive in shipment lines
Steps To Reproduce1. Access, as System Administrator, to "Reference" window and search "Scheduled invoice grouping" reference. Access "List" tab and add option "010000000000000" with name "group by order"
2. Access, as System Administrator, to Business Partner window | Customer tab and set "Invoice grouping" field as "Displayed"
3. Compile application using "ant smartbuild" and restart tomcat
4. Access to Business Partner window and configure any customer with "Invoice grouping= group by order"
5. Register Sales Order for this bp, add 2 lines setting different products and process
6. Register another sales order for same bp, add another 2 lines setting different products and process
7. Access Goods Shipment window, run "Create Lines from" process and select previous orders. Realize that 4 lines are added: first 2 lines belong to order1 and rest to order2
8. Modify first line to set "Line no"=40. Modify last line to set "Line no"=10. (Ensuring that lines from same order are not consecutive). Process shipment
9. Access "Create invoices from orders" form, select both orders and process

Realize that 4 invoices are created instead of 2 invoices
TagsNo tags attached.
Attached Filesdiff file icon c_invoice_create.diff [^] (677 bytes) 2016-04-21 18:08 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0038238 closedcollazoandy4 Error in Create Invoices From Orders for orders shipped in different organizations and business partner with invoice grouping 

-  Notes
(0086004)
AtulOpenbravo (viewer)
2016-04-27 04:24
edited on: 2016-05-02 15:25

 Test Plan
- Login as System Administrator, to "Reference" window and search "Scheduled invoice grouping" reference. Access "List" tab and add option "010000000000000" with name "Group by order"
- In Application Dictionary >> Windows Tabs and Fields >> Business Partner window | Customer tab and set "Invoice grouping" field as "Displayed"
- Compile application using "ant smartbuild" and restart tomcat.
- Login as F&B International Group Admin.
- Go to Business Partner window and configure customer "Moon Light" with "Invoice grouping= Group by order"
- Register Sales Order for this bp, add 2 lines setting different products and process. Products: Ale Beer, Lager Beer
- Register another sales order for same bp, add another 2 lines setting different products and process. Products: Red Wine, Rose Windw
- Access Goods Shipment window, run "Create Lines from" process and select previous orders and EC-0-0-0 as Storage Locator. Check that 4 lines are added: first 2 lines belong to order1 and rest to order2.
- Modify first line to set "Line no"=40. Modify last line to set "Line no"=10. (Ensuring that lines from same order are not consecutive).
- Process shipment
- Go to "Create invoices from orders" form, select both orders and process
- Check only that 2 invoices are created instead of 4 as prior to fix.
(0086122)
psanjuan (viewer)
2016-05-02 14:23
edited on: 2016-05-02 15:25

 Issue can be reproduced if Business Partner selected is configured this way:
Invoice Terms : After delivery
Invoice Grouping: Group by order
(0086123)
psanjuan (viewer)
2016-05-02 15:27
edited on: 2016-05-02 18:25

 Test Plan 1

- Login as System Administrator, to "Reference" window and search "Scheduled invoice grouping" reference. Access "List" tab and add option "010000000000000" with name "Group by order"

- In Application Dictionary >> Windows Tabs and Fields >> Business Partner window | Customer tab and set "Invoice grouping" field as "Displayed"

- Compile application using "ant smartbuild" and restart tomcat.

- Login as F&B International Group Admin.

- Go to Business Partner window and configure customer "Moon Light" with "Invoice grouping= Group by order" and "Invoice Terms = After delivery".

- Register Sales Order for this bp, add 2 lines setting different products and process. Products: Ale Beer, Lager Beer

- Register another sales order for same bp, add another 2 lines setting different products and process. Products: Red Wine, Rose Wine

- Access Goods Shipment window, run "Create Lines from" process and select previous orders and EC-0-0-0 as Storage Locator. Check that 4 lines are added: first 2 lines belong to order 1 and rest to order 2.

- Modify first line to set "Line no"=40. Modify last line to set "Line no"=10. (Ensuring that lines from same order are not consecutive).

- Process shipment

- Go to "Create invoices from orders" form, search by Moon Light Restaurants, and select both orders. Enter an invoice date and process

- Check only that 2 invoices are created instead of 4 as prior to fix.

Test Plan 2

- Go to Business Partner window and configure customer "Moon Light" with "Invoice grouping= By Customer" and "Invoice Terms = After delivery".

- Repeat test plan I above.

- Make sure only one invoice is created.


Test Plan 3

- Go to Business Partner window and configure customer "Moon Light" with "Invoice grouping= By Ship Location" and "Invoice Terms = After delivery".

- Repeat test plan I above by making sure the same location (storage bin) is selected in goods shipment lines.

- Make sure only one invoice is created.
(0086134)
psanjuan (viewer)
2016-05-02 18:28

 Test Plan above verified.

Issue can be code reviewed and closed.
(0086157)
hgbot (developer)
2016-05-03 15:10

 Repository: erp/devel/pi
Changeset: 0a36e7951257c2ce31f550721c3bf1ed748fa95a
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Apr 26 21:25:13 2016 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/0a36e7951257c2ce31f550721c3bf1ed748fa95a [^]

Fixes Issue 32729:In Create Invoice From Orders, Group by Order does not
working properly in case related shipment have lines from different order
not in consequent sequence of order

In case there are lines from different order in same Goods Shipment,
order field in shipment header is set as blank and order information
should be fetched from shipment lines order line field

Additional change done in this fix related with Group by Currency No of
zeros were set as 8 prior to 1 which was for used for grouping Payment Term.
9 is correct for Currency.

---
M src-db/database/model/functions/C_INVOICE_CREATE.xml
---
(0086158)
aferraz (viewer)
2016-05-03 15:10

 Code review + Testing OK
(0087513)
hudsonbot (viewer)
2016-06-17 19:37

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test
(0101761)
hgbot (developer)
2018-01-17 17:08

 Repository: erp/devel/pi
Changeset: a773422cce1f4bc3c9aa737e7ab3436dd1bdd33b
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Wed Jan 17 16:56:19 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a773422cce1f4bc3c9aa737e7ab3436dd1bdd33b [^]

Added test for issue 32729

---
M src-test/src/org/openbravo/test/costing/TestCosting.java
---
(0101762)
hgbot (developer)
2018-01-17 17:08

 Repository: erp/devel/pi
Changeset: 7918fd33ee2351a4d01dfaa68bdf94e378c9758e
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Jan 17 17:05:17 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7918fd33ee2351a4d01dfaa68bdf94e378c9758e [^]

Related to Issue 32729. Code Review changes

Improvmentes in automated tests:
* Set more meaningful names
* Avoid Dal refresh when possible
* Set final to parameters in methods when possible

---
M src-test/src/org/openbravo/test/costing/TestCosting.java
---
(0102662)
hudsonbot (viewer)
2018-02-22 18:18

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test
(0102663)
hudsonbot (viewer)
2018-02-22 18:18

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2016-04-20 14:07 maite New Issue
2016-04-20 14:07 maite Assigned To => Triage Finance
2016-04-20 14:07 maite OBNetwork customer => Yes
2016-04-20 14:07 maite Modules => Core
2016-04-20 14:07 maite Support ticket => 41411
2016-04-20 14:07 maite Resolution time => 1463263200
2016-04-20 14:07 maite Triggers an Emergency Pack => No
2016-04-20 14:08 maite Issue Monitored: networkb
2016-04-21 10:18 aferraz Assigned To Triage Finance => AtulOpenbravo
2016-04-21 18:08 maite File Added: c_invoice_create.diff
2016-04-27 04:24 AtulOpenbravo Status new => scheduled
2016-04-27 04:24 AtulOpenbravo Note Added: 0086004
2016-05-02 14:23 psanjuan Note Added: 0086122
2016-05-02 15:25 psanjuan Note Edited: 0086122 View Revisions
2016-05-02 15:25 psanjuan Note Edited: 0086004 View Revisions
2016-05-02 15:27 psanjuan Note Added: 0086123
2016-05-02 15:27 psanjuan Note Edited: 0086123 View Revisions
2016-05-02 15:35 psanjuan Note Edited: 0086123 View Revisions
2016-05-02 18:25 psanjuan Note Edited: 0086123 View Revisions
2016-05-02 18:28 psanjuan Note Added: 0086134
2016-05-03 15:10 hgbot Checkin
2016-05-03 15:10 hgbot Note Added: 0086157
2016-05-03 15:10 hgbot Status scheduled => resolved
2016-05-03 15:10 hgbot Resolution open => fixed
2016-05-03 15:10 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0a36e7951257c2ce31f550721c3bf1ed748fa95a [^]
2016-05-03 15:10 aferraz Review Assigned To => aferraz
2016-05-03 15:10 aferraz Note Added: 0086158
2016-05-03 15:10 aferraz Status resolved => closed
2016-05-03 15:10 aferraz Fixed in Version => 3.0PR16Q3
2016-06-17 19:37 hudsonbot Checkin
2016-06-17 19:37 hudsonbot Note Added: 0087513
2018-01-17 17:08 hgbot Checkin
2018-01-17 17:08 hgbot Note Added: 0101761
2018-01-17 17:08 hgbot Checkin
2018-01-17 17:08 hgbot Note Added: 0101762
2018-02-22 18:18 hudsonbot Checkin
2018-02-22 18:18 hudsonbot Note Added: 0102662
2018-02-22 18:18 hudsonbot Checkin
2018-02-22 18:18 hudsonbot Note Added: 0102663
2018-04-13 09:21 aferraz Relationship added related to 0038238

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker