Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0032579
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Z. Othersmajoralways2016-04-04 12:372016-06-17 19:37
ReporterngarciaView Statuspublic 
Assigned Tomarkmm82 
PriorityurgentResolutionfixedFixed in Version3.0PR16Q3
StatusclosedFix in branchFixed in SCM revision75af2f16cdb3
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toaferraz
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0032579: Generated credit is set as used although it is not possible to process the payment that uses it

DescriptionGenerated credit is set as used although it is not possible to process the payment that uses it
Steps To ReproduceAs group admin role:
   Create a Payment In for a Business Partner and an amount of 100
   When adding details, do not select any invoice or GL item and select the leave the credit to be used later option in the Overpayment Action field
   Create a new Payment In for the same Business partner and an amount of -100
   When adding details, do not select any invoice or GL item and select the previously created credit to be used
   Check the following error is raised:
      It is not possible to process a Payment without line
   Check the Used Credit field of the payment remains as 0. This is correct
   Check the Used Credit Source field of the Payment has been filled with the credit used. This is wrong
   Check the Used Credit of the payment where the credit was generated has been updated. This is wrong
   The credit will not be available any more as the Used Credit of the first payment is not updated even when you delete the second one
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0030086 scheduledAtulOpenbravo Error in the log when refunding a credit in Add Payment process 
related to defect 0027182 closededuardo_Argal Wrong source payment selected when refunding credit to the customer 
related to defect 0027155 closededuardo_Argal Cannot return the credit to a customer 
related to defect 0029615 closedumartirena Wrong amount in Used Credit Source tab when paying an invoice with credit and refunding the difference to the customer 

-  Notes
(0085412)
ngarcia (developer)
2016-04-04 12:37

 Incorrect data should be corrected
(0085539)
markmm82 (developer)
2016-04-08 21:49

 Test plan 1 (for issue 32579):
As group admin role:
    Create a new Business Partner.
      Check the Current Balance is 0.
    Create a Payment In for the Business Partner and amount 100
      When adding details, do not select any invoice or GL item and select the leave the credit to be later option in the Overpayment action field.
      Check the Current Balance for the BP is -100.
    Create a new Payment In for the same BP and an amount of -100.
      When adding details, do not select any invoice or GL item and select the previously created credit to be used.
    Check the following error is raised:
     It is not possible to process a Payment without line.
    Check the Used Credit field of the Payment remains as 0.
    Check the Used Credit Source field of the Payment is empty.
    Check the Used Credit of the Payment where the credit was generated it was not updated and still 0.
    Check the credit is available and can be used.
          Check the Current Balance for the BP still -100.

Test plan 2 (for related issue 27182):
As group admin role:
    Generate credit for the same BP in two different Payment In for instance:
      Create a new Business Partner.
        Check the Current Balance is 0 for the BP.
      Create a Payment In for the Business Partner and amount 100
        When adding details, do not select any invoice or GL item and select the leave the credit to be later option in the Overpayment action field.
        Check the Current Balance for the BP is -100.
      Create a Payment In for the Business Partner and amount 200
        When adding details, do not select any invoice or GL item and select the leave the credit to be later option in the Overpayment action field.
        Check the Current Balance for the BP is -300.
      Create a Payment In for the Business Partner
        When adding details, Select the credit generated in the second payment and the option 'Refund amount to customer'
      Check that new refunded payment is created, and the credit has been consumed from the second payment as expected (it is referenced in the Used Credit Source tab)
      Check the Current Balance for the BP decrease in the amount refunded.

Test plan 3 (for related issue 27155):
Create a Payment In for Restaurantes Luna Llena, S.A. and an amount of 100
   When Adding details do not select any document
   Select Leave the credit to be used later as the Overpayment action
   Create another Payment In for Restaurantes Luna Llena, S.A. and an amount of 0
   When Adding details select the previously generated credit and
     Set the Payment amount to 100
     Select Refund amount to customer as the Overpayment action
   Refund amount to customer option was made succesfully.
   Used credit is 100 for the payment from the credit was used.

Test plan 4 (for related issue 29615):
As group admin role:
    Create a new Business Partner.
        Check the Current Balance is 0 for the BP.
    Create a Payment In where you leave 100 EUR as credit to the previously created Business Partner
        Check the Current Balance is -100 for the BP.
       Create a Sales Invoice of 74.05 EUR for the same Business Partner and complete it. (Add 40 Units of Agua sin gas product for instance)
        Check the Current Balance is -25.95 for the BP.
    Create a new Payment In, select the credit to use 74.05, the invoice to pay previous created and Refund the amount to the Customer
    Check two payments are created:
            One with the refund that having one record in the Used Credit tab with the difference refunded -25.95 and the payment selected
          One with the invoice payment that has a record of 74.05 EUR in the Used Credit Source tab
    Check Post of this last payment is the expected.
    Check the Current Balance is 0, as 74.05 was consumed by the invoice and 25.95 refunded.
(0085851)
hgbot (developer)
2016-04-21 19:28

 Repository: erp/devel/pi
Changeset: 75af2f16cdb33231deb9d7f55c5e97fa7d4f0ac2
Author: Mark <m.molina <at> nectus.com>
Date: Fri Apr 08 15:28:54 2016 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/75af2f16cdb33231deb9d7f55c5e97fa7d4f0ac2 [^]

Fixes issue 32579: Generated credit set as used when it should not

Generated credit was set as used although it is not possible to process the payment that uses it, when an exception is thrown the payment processing aborts and can't be created or updated the credits.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddPaymentActionHandler.java
---
(0085854)
aferraz (manager)
2016-04-21 19:29

 Code review + Testing OK
(0087480)
hudsonbot (developer)
2016-06-17 19:37

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2016-04-04 12:37 ngarcia New Issue
2016-04-04 12:37 ngarcia Assigned To => Triage Finance
2016-04-04 12:37 ngarcia Modules => Core
2016-04-04 12:37 ngarcia Resolution time => 1462658400
2016-04-04 12:37 ngarcia Triggers an Emergency Pack => No
2016-04-04 12:37 ngarcia Issue Monitored: networkb
2016-04-04 12:37 ngarcia Note Added: 0085412
2016-04-04 14:55 eugeni Issue Monitored: eugeni
2016-04-05 12:17 aferraz Assigned To Triage Finance => markmm82
2016-04-07 09:59 aferraz Relationship added related to 0030086
2016-04-07 10:49 aferraz Relationship added related to 0027182
2016-04-07 10:49 aferraz Relationship added related to 0027155
2016-04-07 10:55 aferraz Relationship added related to 0029615
2016-04-07 13:43 markmm82 Status new => scheduled
2016-04-08 21:49 markmm82 Note Added: 0085539
2016-04-21 19:28 hgbot Checkin
2016-04-21 19:28 hgbot Note Added: 0085851
2016-04-21 19:28 hgbot Status scheduled => resolved
2016-04-21 19:28 hgbot Resolution open => fixed
2016-04-21 19:28 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/75af2f16cdb33231deb9d7f55c5e97fa7d4f0ac2 [^]
2016-04-21 19:29 aferraz Review Assigned To => aferraz
2016-04-21 19:29 aferraz Note Added: 0085854
2016-04-21 19:29 aferraz Status resolved => closed
2016-04-21 19:29 aferraz Fixed in Version => 3.0PR16Q3
2016-06-17 19:37 hudsonbot Checkin
2016-06-17 19:37 hudsonbot Note Added: 0087480

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker