Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0031744
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Localization Pack: Spain] Multi Dimensional Tax Report Cash VATmajoralways2015-12-17 15:262016-02-09 11:38
ReporterngarciaView Statuspublic 
Assigned Tomarkmm82 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision14458e7d4766
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Tovmromanos
Support ticket39850
OBNetwork customerOBPS
Regression introduced in release
Summary

0031744: Multidimensional Tax Report Cash VAT is empty report if the Tax Rate filter is used

DescriptionMultidimensional Tax Report Cash VAT is empty report if the Tax Rate filter is used. The tax rate name is passed as parameter instead of the ID
Steps To ReproduceAs group admin role:
   Launch the Multidimensinal Tax Report Cash VAT, configure the filters in order to get some values there
   Select one of the tax rates shown there
   Launch the report again with the same filters but adding the tax rate in the Tax Rate filter
   Check the report is empty
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0031890 closedmarkmm82 Multidimensional Tax Report is empty report if the Tax Rate filter is used 

-  Notes
(0083013)
markmm82 (viewer)
2015-12-28 15:00

 Fixes Issue 31744: Fixed options of the autogenerated Tax Rate combo.
Each time the Organization combo fire the onchange event, the Tax Rate combo is populated with Tax Rates for this organization. The HTML source code for the combo was incorrect: inside the option the value attribute was setted with the text of the Tax Rate instead of the tax rate ID.
For this reason when the report was used filtering by the Tax rate, an incorrect parameter was submitted and no results obtained.

Several changes was made to return not only the names of the Tax Rates, also the IDs inside
modules\org.openbravo.module.invoiceTaxReportEnhanced30.cashvat\src\org\openbravo\module\invoiceTaxReportEnhanced30\cashvat\ad_reports\OBMTRCV_InvoiceTaxReportJR.java

Test Plan
As group admin role:
   Launch the Multidimensinal Tax Report Cash VAT, configure the filters in order to get some values there
    From Date: 24-12-2014
    To Date: today
    Organization: F&B International Group
    Tax Rate: blank
    Click the HTML format button.
    Notice report have several rows and Tax rates.
   Select one of the tax rates shown there
    Tax Rate: Sales Exempt
   Launch the report again with the same filters but adding the tax rate in the Tax Rate filter
   Check the report return only results for the selected tax rate.
(0083295)
hgbot (developer)
2016-01-14 13:03

 Repository: erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30.cashvat
Changeset: 14458e7d47664ae57c8789a6c49b4bb92b02b1aa
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Jan 14 11:25:33 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30.cashvat/rev/14458e7d47664ae57c8789a6c49b4bb92b02b1aa [^]

Fixed bug 31744: Tax and Withholding combo doesn't filter

Solution partially based on m.molina@nectus.com one.

Each time the Organization combo fire the onchange event, the Tax Rate combo is populated with Tax Rates for this organization. The HTML source code for the combo was incorrect: inside the option the value attribute was setted with the text of the Tax Rate instead of the tax rate ID.
For this reason when the report was used filtering by the Tax rate, an incorrect parameter was submitted and no results obtained.


The fixes properly populates the tax rate and withholding combos with ID and name.
It uses ScrollableResults and session clears to avoid running out of memory.
It uses LinkedHashMap to store the id-value in the right order.

---
M src-db/database/sourcedata/AD_MODULE.xml
M src/org/openbravo/module/invoiceTaxReportEnhanced30/cashvat/ad_reports/OBMTRCV_InvoiceTaxReportJR.java
---
(0083297)
vmromanos (viewer)
2016-01-14 13:05

 Solution based on markmm82 one.

Code review + testing OK.

Available in Multidimensional Tax Report Cash VAT 1.0.100 (or higher)

- Issue History
Date Modified Username Field Change
2015-12-17 15:26 ngarcia New Issue
2015-12-17 15:26 ngarcia Regression date => 2016-01-21
2015-12-17 15:26 ngarcia Support ticket => 39850
2015-12-17 15:26 ngarcia OBNetwork customer => Yes
2015-12-17 15:27 ngarcia Assigned To => Triage Finance
2015-12-17 15:28 ngarcia Issue Monitored: networkb
2015-12-17 15:34 ngarcia Description Updated View Revisions
2015-12-18 10:45 ngarcia Regression date 2016-01-21 =>
2015-12-18 10:45 ngarcia Resolution time => 1453330800
2015-12-23 16:02 markmm82 Status new => scheduled
2015-12-28 15:00 markmm82 Note Added: 0083013
2015-12-31 13:12 vmromanos Assigned To Triage Finance => markmm82
2016-01-14 12:57 vmromanos Issue cloned 0031890
2016-01-14 12:57 vmromanos Relationship added related to 0031890
2016-01-14 13:03 hgbot Checkin
2016-01-14 13:03 hgbot Note Added: 0083295
2016-01-14 13:03 hgbot Status scheduled => resolved
2016-01-14 13:03 hgbot Resolution open => fixed
2016-01-14 13:03 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30.cashvat/rev/14458e7d47664ae57c8789a6c49b4bb92b02b1aa [^]
2016-01-14 13:05 vmromanos Review Assigned To => vmromanos
2016-01-14 13:05 vmromanos Note Added: 0083297
2016-01-14 13:05 vmromanos Status resolved => closed
2016-01-14 13:07 ngarcia Issue cloned 0031891
2016-02-09 11:38 eugeni Issue Monitored: eugeni

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker