0031617: When a conflict is detected reading terminal authentication preference the user should be Informed

Description

If you define to preference which create a conflict, the system use always 'N' but user is not informed about this situation

Steps To Reproduce

Create a new preference identical to the one which is in the module. If you add a breakpoint in below catch, you will see that there is an exception when preference is read.

file: LoginUtilsServlet.java
Code:

try {
      value = Preferences.getPreferenceValue("OBPOS_TerminalAuthentication", true, null, null,
          null, null, (String) null);
    } catch (PropertyException e) {
      result.put("terminalAuthentication", "Y");
      return result;
    }

Proposed Solution

1. Because preference will be yes by defaut starting from 16Q1, in case of conflict the system should return Y.
2. Apart from that the user should realize that there is a confirguration problem and it should be shown.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0082456) hgbot (developer) 2015-11-30 08:48	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 6ffb30587007e7deaf8131bbe00ffcd7588f9d37 Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com> Date: Fri Nov 27 13:46:39 2015 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6ffb30587007e7deaf8131bbe00ffcd7588f9d37 [^] Fixed issue 31617: When conflict is detected reading terminal authentication preference the system will inform to the user --- M src-db/database/sourcedata/AD_MESSAGE.xml M src/org/openbravo/retail/posterminal/CheckTerminalAuth.java M src/org/openbravo/retail/posterminal/LoginUtilsServlet.java M web/org.openbravo.retail.posterminal/js/login/model/login-model.js ---

(0082704) migueldejuana (viewer) 2015-12-14 11:55	Tested and reviewed in d1d27a88215b

Issue History
Date Modified	Username	Field	Change
2015-11-27 13:39	guilleaer	New Issue
2015-11-27 13:39	guilleaer	Assigned To	=> guilleaer
2015-11-27 13:39	guilleaer	OBNetwork customer	=> No
2015-11-27 13:39	guilleaer	Triggers an Emergency Pack	=> No
2015-11-27 13:39	guilleaer	Status	new => scheduled
2015-11-30 08:48	hgbot	Checkin
2015-11-30 08:48	hgbot	Note Added: 0082456
2015-11-30 08:48	hgbot	Status	scheduled => resolved
2015-11-30 08:48	hgbot	Resolution	open => fixed
2015-11-30 08:48	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6ffb30587007e7deaf8131bbe00ffcd7588f9d37 [^]
2015-12-09 10:13	Orekaria	Review Assigned To	=> marvintm
2015-12-14 09:04	mtaal	Review Assigned To	marvintm => migueldejuana
2015-12-14 11:55	migueldejuana	Note Added: 0082704
2015-12-14 11:55	migueldejuana	Status	resolved => closed