Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0030739 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 02. Master data management | minor | have not tried | 2015-09-02 12:49 | 2016-06-28 16:06 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | Sanjota | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR16Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 4ca0c8b4d182 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | aferraz | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0030739: pl function m_copy_product_template has datatype bug (storing number in a varchar(32) variable) | |||||||
| Description | That pl function defines a variable like this: v_Discount VARCHAR2(32); The assigned it like this, with all ride-side being numeric values. v_Discount:=(v_Pricelist - v_Pricestd) /v_Pricelist; Then stores the result into c_orderline.discount which again is numeric. So it looks like that variable definition is wrong and should be some numeric type also | |||||||
| Steps To Reproduce | Read code of that pl-function or run plpgsql_check analyzer | |||||||
| Proposed Solution | change datatype of v_discount from varchar(32) to numeric | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0087161) Sanjota (developer) 2016-06-10 14:25 |
Test Plan: Run the pl function m_copy_product_template and check that v_discount will accept only numeric values |
|
(0087975) hgbot (developer) 2016-06-27 12:38 |
Repository: erp/devel/pi Changeset: 4ca0c8b4d18299c26c73e652580b6a4124d0da3d Author: Sanjota <sanjota.nelagi <at> promantia.com> Date: Fri Jun 10 17:52:55 2016 +0530 URL: http://code.openbravo.com/erp/devel/pi/rev/4ca0c8b4d18299c26c73e652580b6a4124d0da3d [^] Fixes issue 30739: pl function m_copy_product_template has datatype bug Changed the datatype of v_documentNo from var char(30) to Numeric. --- M src-db/database/model/functions/M_COPY_PRODUCT_TEMPLATE.xml --- |
|
(0087978) aferraz (manager) 2016-06-27 12:43 |
Code review OK |
|
(0088054) hudsonbot (developer) 2016-06-28 16:06 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/865878a5d292 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-09-02 12:49 | shuehner | New Issue | |
| 2015-09-02 12:49 | shuehner | Assigned To | => Triage Finance |
| 2015-09-02 12:49 | shuehner | Modules | => Core |
| 2015-09-02 12:49 | shuehner | Triggers an Emergency Pack | => No |
| 2015-09-02 12:49 | shuehner | Relationship added | related to 0017329 |
| 2016-06-06 18:36 | aferraz | Assigned To | Triage Finance => Sanjota |
| 2016-06-10 14:24 | Sanjota | Status | new => scheduled |
| 2016-06-10 14:25 | Sanjota | Note Added: 0087161 | |
| 2016-06-27 12:38 | hgbot | Checkin | |
| 2016-06-27 12:38 | hgbot | Note Added: 0087975 | |
| 2016-06-27 12:38 | hgbot | Status | scheduled => resolved |
| 2016-06-27 12:38 | hgbot | Resolution | open => fixed |
| 2016-06-27 12:38 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/4ca0c8b4d18299c26c73e652580b6a4124d0da3d [^] |
| 2016-06-27 12:43 | aferraz | Review Assigned To | => aferraz |
| 2016-06-27 12:43 | aferraz | Note Added: 0087978 | |
| 2016-06-27 12:43 | aferraz | Status | resolved => closed |
| 2016-06-27 12:43 | aferraz | Fixed in Version | => 3.0PR16Q3 |
| 2016-06-28 16:06 | hudsonbot | Checkin | |
| 2016-06-28 16:06 | hudsonbot | Note Added: 0088054 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |