0030668: Instance cannot be upgraded to 3.0PR15Q3 if the Check Printing module is installed (included in US Localization Pack)

Description

Instance cannot be upgraded to 3.0PR15Q3 if the Check Printing module is installed (included in US Localization Pack)

Steps To Reproduce

As group admin role:
   Install the US Localization Pack in an instance previous to 3.0PR15Q3
   Upgrade Core to a version higher or equal 3.0PR15Q3
   Check the compilation fails with errors like: ...modules/org.openbravo.localization.us.checkprinting/src/org/openbravo/localization/us/checkprinting/ad_forms/CheckManagement.java:1201: error: method setParameters in class JRAbstractExporter<RC,C,O,E> cannot be applied to given types;
    [javac] exporter.setParameters(exportParameters);

Tags

No tags attached.

Attached Files

usLocalizationPackReports.diff [^] (11,009 bytes) 2015-09-04 11:34 [Show Content] [Hide Content]

diff --git a/modules/org.openbravo.localization.us.checkprinting/src/org/openbravo/localization/us/checkprinting/ad_forms/CheckManagement.java b/modules/org.openbravo.localization.us.checkprinting/src/org/openbravo/localization/us/checkprinting/ad_forms/CheckManagement.java
--- a/modules/org.openbravo.localization.us.checkprinting/src/org/openbravo/localization/us/checkprinting/ad_forms/CheckManagement.java
+++ b/modules/org.openbravo.localization.us.checkprinting/src/org/openbravo/localization/us/checkprinting/ad_forms/CheckManagement.java
@@ -12,6 +12,8 @@
  */
 
 package org.openbravo.localization.us.checkprinting.ad_forms;
+
+import java.io.File;
 import java.io.IOException;
 import java.io.PrintWriter;
 import java.math.BigDecimal;
@@ -42,9 +44,6 @@
 import net.sf.jasperreports.engine.JasperFillManager;
 import net.sf.jasperreports.engine.JasperPrint;
 import net.sf.jasperreports.engine.JasperReport;
-import net.sf.jasperreports.engine.export.JExcelApiExporter;
-import net.sf.jasperreports.engine.export.JExcelApiExporterParameter;
-import net.sf.jasperreports.engine.export.JRHtmlExporter;
 import net.sf.jasperreports.engine.export.JRHtmlExporterParameter;
 
 import org.hibernate.Query;
@@ -52,6 +51,8 @@
 import org.openbravo.base.filter.IsIDFilter;
 import org.openbravo.base.secureApp.HttpSecureAppServlet;
 import org.openbravo.base.secureApp.VariablesSecureApp;
+import org.openbravo.client.application.report.ReportingUtils;
+import org.openbravo.client.application.report.ReportingUtils.ExportType;
 import org.openbravo.dal.core.OBContext;
 import org.openbravo.dal.core.SessionHandler;
 import org.openbravo.dal.service.OBDal;
@@ -1192,14 +1193,10 @@
 
               response.setHeader("Content-disposition", "inline" + "; filename=" + strFileName + "."
                                 + strOutputType);
-              final JRHtmlExporter exporter = new JRHtmlExporter();
-              exportParameters.put(JRHtmlExporterParameter.JASPER_PRINT, jasperPrint);
               exportParameters.put(JRHtmlExporterParameter.IS_USING_IMAGES_TO_ALIGN, Boolean.FALSE);
               exportParameters.put(JRHtmlExporterParameter.SIZE_UNIT,
 	       JRHtmlExporterParameter.SIZE_UNIT_POINT);
-              exportParameters.put(JRHtmlExporterParameter.OUTPUT_STREAM, os);
-              exporter.setParameters(exportParameters);
-              exporter.exportReport();
+              ReportingUtils.saveReport(jasperPrint, ExportType.HTML, exportParameters, os);
               os.close();
            }
            else if (strOutputType.equals("pdf") || strOutputType.equalsIgnoreCase("xls"))
@@ -1277,15 +1274,7 @@
   	    if (reportType.equalsIgnoreCase("pdf")) {
   	      JasperExportManager.exportReportToPdfFile(jp, outputFile);
   	    } else if (reportType.equalsIgnoreCase("xls")) {
-  	      JExcelApiExporter exporter = new JExcelApiExporter();
-  	      exportParameters.put(JExcelApiExporterParameter.JASPER_PRINT, jp);
-  	      exportParameters.put(JExcelApiExporterParameter.OUTPUT_FILE_NAME, outputFile);
-  	      exportParameters.put(JExcelApiExporterParameter.IS_ONE_PAGE_PER_SHEET, Boolean.FALSE);
-  	      exportParameters.put(JExcelApiExporterParameter.IS_REMOVE_EMPTY_SPACE_BETWEEN_ROWS,
-  	          Boolean.TRUE);
-  	      exportParameters.put(JExcelApiExporterParameter.IS_DETECT_CELL_TYPE, true);
-  	      exporter.setParameters(exportParameters);
-  	      exporter.exportReport();
+              ReportingUtils.saveReport(jp, ExportType.XLS, null, new File(outputFile));
   	    } else {
   	      throw new JRException("Report type not supported");
   	    }
diff --git a/modules/org.openbravo.localization.us.checkprinting/src/org/openbravo/localization/us/checkprinting/ad_forms/CheckPrintedCategory.java b/modules/org.openbravo.localization.us.checkprinting/src/org/openbravo/localization/us/checkprinting/ad_forms/CheckPrintedCategory.java
--- a/modules/org.openbravo.localization.us.checkprinting/src/org/openbravo/localization/us/checkprinting/ad_forms/CheckPrintedCategory.java
+++ b/modules/org.openbravo.localization.us.checkprinting/src/org/openbravo/localization/us/checkprinting/ad_forms/CheckPrintedCategory.java
@@ -12,6 +12,8 @@
  */
 
 package org.openbravo.localization.us.checkprinting.ad_forms;
+
+import java.io.File;
 import java.io.IOException;
 import java.io.PrintWriter;
 import java.sql.Connection;
@@ -36,15 +38,14 @@
 import net.sf.jasperreports.engine.JasperPrint;
 import net.sf.jasperreports.engine.JasperPrintManager;
 import net.sf.jasperreports.engine.JasperReport;
-import net.sf.jasperreports.engine.export.JExcelApiExporter;
-import net.sf.jasperreports.engine.export.JExcelApiExporterParameter;
-import net.sf.jasperreports.engine.export.JRHtmlExporter;
 import net.sf.jasperreports.engine.export.JRHtmlExporterParameter;
 import net.sf.jasperreports.view.JasperViewer;
 
 import org.openbravo.base.filter.IsIDFilter;
 import org.openbravo.base.secureApp.HttpSecureAppServlet;
 import org.openbravo.base.secureApp.VariablesSecureApp;
+import org.openbravo.client.application.report.ReportingUtils;
+import org.openbravo.client.application.report.ReportingUtils.ExportType;
 import org.openbravo.dal.service.OBDal;
 import org.openbravo.data.FieldProvider;
 import org.openbravo.database.ConnectionProvider;
@@ -787,13 +788,9 @@
 
               response.setHeader("Content-disposition", "inline" + "; filename=" + strFileName + "."
                                 + strOutputType);
-              final JRHtmlExporter exporter = new JRHtmlExporter();
-              exportParameters.put(JRHtmlExporterParameter.JASPER_PRINT, jasperPrint);
               exportParameters.put(JRHtmlExporterParameter.IS_USING_IMAGES_TO_ALIGN, Boolean.FALSE);
               exportParameters.put(JRHtmlExporterParameter.SIZE_UNIT, JRHtmlExporterParameter.SIZE_UNIT_POINT);
-              exportParameters.put(JRHtmlExporterParameter.OUTPUT_STREAM, os);
-              exporter.setParameters(exportParameters);
-              exporter.exportReport();
+              ReportingUtils.saveReport(jasperPrint, ExportType.HTML, exportParameters, os);
               os.close();
            }
            else if (strOutputType.equals("pdf") || strOutputType.equalsIgnoreCase("xls"))
@@ -872,15 +869,7 @@
   	    if (reportType.equalsIgnoreCase("pdf")) {
   	      JasperExportManager.exportReportToPdfFile(jp, outputFile);
   	    } else if (reportType.equalsIgnoreCase("xls")) {
-  	      JExcelApiExporter exporter = new JExcelApiExporter();
-  	      exportParameters.put(JExcelApiExporterParameter.JASPER_PRINT, jp);
-  	      exportParameters.put(JExcelApiExporterParameter.OUTPUT_FILE_NAME, outputFile);
-  	      exportParameters.put(JExcelApiExporterParameter.IS_ONE_PAGE_PER_SHEET, Boolean.FALSE);
-  	      exportParameters.put(JExcelApiExporterParameter.IS_REMOVE_EMPTY_SPACE_BETWEEN_ROWS,
-  	          Boolean.TRUE);
-  	      exportParameters.put(JExcelApiExporterParameter.IS_DETECT_CELL_TYPE, true);
-  	      exporter.setParameters(exportParameters);
-  	      exporter.exportReport();
+  	      ReportingUtils.saveReport(jp, ExportType.XLS, null, new File(outputFile));
   	    } else {
   	      throw new JRException("Report type not supported");
   	    }
diff --git a/modules/org.openbravo.localization.us.checkprinting/src/org/openbravo/localization/us/checkprinting/ad_forms/CheckPrintingCategory.java b/modules/org.openbravo.localization.us.checkprinting/src/org/openbravo/localization/us/checkprinting/ad_forms/CheckPrintingCategory.java
--- a/modules/org.openbravo.localization.us.checkprinting/src/org/openbravo/localization/us/checkprinting/ad_forms/CheckPrintingCategory.java
+++ b/modules/org.openbravo.localization.us.checkprinting/src/org/openbravo/localization/us/checkprinting/ad_forms/CheckPrintingCategory.java
@@ -11,6 +11,8 @@
  ************************************************************************************
  */
 package org.openbravo.localization.us.checkprinting.ad_forms;
+
+import java.io.File;
 import java.io.IOException;
 import java.io.PrintWriter;
 import java.sql.Connection;
@@ -33,15 +35,14 @@
 import net.sf.jasperreports.engine.JasperFillManager;
 import net.sf.jasperreports.engine.JasperPrint;
 import net.sf.jasperreports.engine.JasperReport;
-import net.sf.jasperreports.engine.export.JExcelApiExporter;
-import net.sf.jasperreports.engine.export.JExcelApiExporterParameter;
-import net.sf.jasperreports.engine.export.JRHtmlExporter;
 import net.sf.jasperreports.engine.export.JRHtmlExporterParameter;
 
 import org.openbravo.base.filter.IsIDFilter;
 import org.openbravo.base.provider.OBProvider;
 import org.openbravo.base.secureApp.HttpSecureAppServlet;
 import org.openbravo.base.secureApp.VariablesSecureApp;
+import org.openbravo.client.application.report.ReportingUtils;
+import org.openbravo.client.application.report.ReportingUtils.ExportType;
 import org.openbravo.dal.core.OBContext;
 import org.openbravo.dal.service.OBDal;
 import org.openbravo.data.FieldProvider;
@@ -1021,14 +1022,10 @@
   	          log4j.debug("JR: Print HTML");
   	        response.setHeader("Content-disposition", "inline" + "; filename=" + strFileName + "."
   	            + strOutputType);
-  	        final JRHtmlExporter exporter = new JRHtmlExporter();
-  	        exportParameters.put(JRHtmlExporterParameter.JASPER_PRINT, jasperPrint);
   	        exportParameters.put(JRHtmlExporterParameter.IS_USING_IMAGES_TO_ALIGN, Boolean.FALSE);
   	        exportParameters.put(JRHtmlExporterParameter.SIZE_UNIT,
   	            JRHtmlExporterParameter.SIZE_UNIT_POINT);
-  	        exportParameters.put(JRHtmlExporterParameter.OUTPUT_STREAM, os);
-  	        exporter.setParameters(exportParameters);
-  	        exporter.exportReport();
+  	        ReportingUtils.saveReport(jasperPrint, ExportType.HTML, exportParameters, os);
   	      os.close();
   	      } else if (strOutputType.equals("pdf") || strOutputType.equalsIgnoreCase("xls")) {
   	        reportId = UUID.randomUUID();
@@ -1085,15 +1082,7 @@
   	    if (reportType.equalsIgnoreCase("pdf")) {
   	      JasperExportManager.exportReportToPdfFile(jp, outputFile);
   	    } else if (reportType.equalsIgnoreCase("xls")) {
-  	      JExcelApiExporter exporter = new JExcelApiExporter();
-  	      exportParameters.put(JExcelApiExporterParameter.JASPER_PRINT, jp);
-  	      exportParameters.put(JExcelApiExporterParameter.OUTPUT_FILE_NAME, outputFile);
-  	      exportParameters.put(JExcelApiExporterParameter.IS_ONE_PAGE_PER_SHEET, Boolean.FALSE);
-  	      exportParameters.put(JExcelApiExporterParameter.IS_REMOVE_EMPTY_SPACE_BETWEEN_ROWS,
-  	          Boolean.TRUE);
-  	      exportParameters.put(JExcelApiExporterParameter.IS_DETECT_CELL_TYPE, true);
-  	      exporter.setParameters(exportParameters);
-  	      exporter.exportReport();
+  	      ReportingUtils.saveReport(jp, ExportType.XLS, null, new File(outputFile));
   	    } else {
   	      throw new JRException("Report type not supported");
   	    }

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	defect	0029882	closed	caristu	Openbravo ERP	API changes required for Jasper library upgrade to version 6.0.0
related to	defect	0030672	closed	psanjuan	Openbravo Localizations	Instance cannot be upgraded to 3.0PR15Q3 if the TDS Business Forms pack is installed (included in US Localization Pack)
related to	design defect	0030766	closed		Openbravo Localizations	US Localization pack needs to be adjusted to support new Jasper Libraries.

Notes
(0079752) psanjuan (manager) 2015-08-26 12:05	Check Printing module that belongs to US Localization needs to be updated to support new Jasper Library.

(0080092) psanjuan (manager) 2015-09-04 11:33	patch attached provided through support ticket.

Issue History
Date Modified	Username	Field	Change
2015-08-25 15:15	ngarcia	New Issue
2015-08-25 15:15	ngarcia	Issue Monitored: networkb
2015-08-25 15:16	ngarcia	Relationship added	related to 0029882
2015-08-25 15:17	ngarcia	Resolution time	=> 1443304800
2015-08-25 15:17	ngarcia	Assigned To	=> psanjuan
2015-08-26 10:45	ngarcia	Issue cloned	0030672
2015-08-26 10:45	ngarcia	Relationship added	related to 0030672
2015-08-26 12:05	psanjuan	Note Added: 0079752
2015-09-04 09:07	vmromanos	Status	new => acknowledged
2015-09-04 11:33	psanjuan	Note Added: 0080092
2015-09-04 11:33	psanjuan	Status	acknowledged => scheduled
2015-09-04 11:33	psanjuan	Status	scheduled => resolved
2015-09-04 11:33	psanjuan	Resolution	open => fixed
2015-09-04 11:33	psanjuan	Status	resolved => closed
2015-09-04 11:34	psanjuan	File Added: usLocalizationPackReports.diff
2015-11-18 17:31	ngarcia	Relationship added	related to 0030766