Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0030648
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementmajoralways2015-08-24 13:402015-08-28 20:08
ReporterngarciaView Statuspublic 
Assigned ToAtulOpenbravo 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionb5f54c463299
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket36307
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0030648: Tax Payment process is taken into account the Invoices Tax Date hidden field and it is not updated with the accounting date

DescriptionTax Payment process is taken into account the Invoices Tax Date hidden field and it is not updated with the accounting date. The taxdate column is being filled by some processes such as:

C_COMMISSIONRUN_PROCESS
C_INVOICE_CREATE
M_INOUT_CREATEINVOICE
C_CREATE_PINVOICE_FROM_OUTS
M_RAPPEL_INVOICE_CREATE
ExpenseAPInvoice
Steps To ReproduceAs group admin role:
   Create a Tax Register Type
   Set it as Sales Transaction
   Add Entregas IVA 21% and AR Invoice to its Lines
   Create a Sales Order for a BP and set that tax rate and Invoice Terms Immediate
   Generate the associated invoice by the Generate Invoices process
   Reactivate the automatically created sales invoice and check its invoice and accounting date to a date in the next month (check through database the taxdate field has not been updated)
   Process it again
   Create a record in the Tax Payment window for a date range that includes the current accounting date of the invoice. Check the invoice is not included in the lines
   Create a record in the Tax Payment window for a date range that includes the current taxdate (checked in the DB) of the invoice. Check the invoice is included in the lines
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0015443 closededuardo_Argal 3.0RC3: Tax Payment can not be executed because the Tax Date field is hidden in 3.0RC3 

-  Notes
(0079732)
vmromanos (viewer)
2015-08-26 09:55

 A callout will be implemented over the Invoice's accounting date.

The Tax date will be updated to the accounting date only in the case the Tax Date is not null. This way we can control this typical scenario of reactivating an invoice without affecting the normal flows
(0079737)
AtulOpenbravo (viewer)
2015-08-26 10:02

 Test Plan
- Login as Group Admin role.
- Create a Tax Register Type
   Set it as Sales Transaction
   Add Entregas IVA 21% and AR Invoice to its Lines
- Create a Sales Order for a BP and set that tax rate and Invoice Terms as Immediate
- Generate the associated invoice by the Generate Invoices process
- Reactivate the automatically created sales invoice and change its invoice and accounting date to a date in the next month (check through database the taxdate field has been updated as per accounting date).
- Process it again.
- Create a record in the Tax Payment window for a date range that includes the current accounting date/ tax date of the invoice. Check the invoice is included in the lines.
(0079773)
hgbot (developer)
2015-08-27 11:39

 Repository: erp/devel/pi
Changeset: 839a7b06657e934a4cbe75fb3c3f676264c468af
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Wed Aug 26 13:35:04 2015 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/839a7b06657e934a4cbe75fb3c3f676264c468af [^]

Fixes Issue 30648:Tax Payment process is taken into account the Invoices Tax
Date hidden field and it is not updated with the accounting date

Callout is implemented on Invoice Accounting Date to update Tax Date only if
Tax Date is not null and not equal to Accounting Date

---
M src-db/database/sourcedata/AD_CALLOUT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
A src/org/openbravo/erpCommon/ad_callouts/SE_Invoice_TaxDate.java
---
(0079774)
hgbot (developer)
2015-08-27 11:39

 Repository: erp/devel/pi
Changeset: b5f54c463299daa47860c45d8bb98937c76313c7
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Aug 27 10:29:20 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b5f54c463299daa47860c45d8bb98937c76313c7 [^]

Fixed bug 30648: code review. Avoid NullPointerException

---
M src/org/openbravo/erpCommon/ad_callouts/SE_Invoice_TaxDate.java
---
(0079775)
vmromanos (viewer)
2015-08-27 11:42

 Alternative test plan:

Go to Sales Invoice window
Create a new record
Fill mandatory fields.
Save the record.
Verify in database that tax date is null.
Change invoice date.
Save the record.
Verify in database that tax date is null.
Update the tax date directly in database to today.
Refresh the record in the UI.
Change accounting date to tomorrow.
Save the record.
Verify in database that the tax date is changed to tomorrow (same as accounting date)
(0079776)
vmromanos (viewer)
2015-08-27 11:44

 Code review + testing OK
(0079803)
hudsonbot (viewer)
2015-08-28 20:08

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0b503a8b6697 [^]
Maturity status: Test
(0079804)
hudsonbot (viewer)
2015-08-28 20:08

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0b503a8b6697 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2015-08-24 13:40 ngarcia New Issue
2015-08-24 13:40 ngarcia Assigned To => Triage Finance
2015-08-24 13:40 ngarcia OBNetwork customer => Yes
2015-08-24 13:40 ngarcia Modules => Core
2015-08-24 13:40 ngarcia Support ticket => 36307
2015-08-24 13:40 ngarcia Resolution time => 1440540000
2015-08-24 13:40 ngarcia Triggers an Emergency Pack => No
2015-08-24 13:41 ngarcia Relationship added related to 0015443
2015-08-25 22:22 AtulOpenbravo Assigned To Triage Finance => AtulOpenbravo
2015-08-26 09:55 vmromanos Note Added: 0079732
2015-08-26 10:02 AtulOpenbravo Status new => scheduled
2015-08-26 10:02 AtulOpenbravo Note Added: 0079737
2015-08-27 11:39 hgbot Checkin
2015-08-27 11:39 hgbot Note Added: 0079773
2015-08-27 11:39 hgbot Status scheduled => resolved
2015-08-27 11:39 hgbot Resolution open => fixed
2015-08-27 11:39 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/839a7b06657e934a4cbe75fb3c3f676264c468af [^]
2015-08-27 11:39 hgbot Checkin
2015-08-27 11:39 hgbot Note Added: 0079774
2015-08-27 11:39 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/839a7b06657e934a4cbe75fb3c3f676264c468af [^] => http://code.openbravo.com/erp/devel/pi/rev/b5f54c463299daa47860c45d8bb98937c76313c7 [^]
2015-08-27 11:42 vmromanos Note Added: 0079775
2015-08-27 11:44 vmromanos Review Assigned To => vmromanos
2015-08-27 11:44 vmromanos Note Added: 0079776
2015-08-27 11:44 vmromanos Status resolved => closed
2015-08-28 20:08 hudsonbot Checkin
2015-08-28 20:08 hudsonbot Note Added: 0079803
2015-08-28 20:08 hudsonbot Checkin
2015-08-28 20:08 hudsonbot Note Added: 0079804

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker