0030528: Potential full c_orderline scan in M_Reservation_trg

Description

Trigger on M_Reservation table does a count on all order lines without any filtering.

If this code is executed in an environment with a decent amount of orders, it can take ages to complete.

Steps To Reproduce

I have not reproduced it, but just read the code in M_RESERVATION_TRG.xml :

https://code.openbravo.com/erp/devel/pi/rev/b4be2e4511445d578fc7f8a2175c3a6114e52583#l1.28 [^]

select count (*) into v_count from c_orderline;

it looks like some missing debug code forgotten to remove as it is never used

Tags

Approved

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0030516

closed

AtulOpenbravo

Potential full c_orderline scan in M_Reservation_trg

Notes
(0079269) hgbot (developer) 2015-08-10 09:11	Repository: erp/backports/3.0PR15Q3 Changeset: 1861f239c670b09737ef7359e7a74068622d205b Author: Atul Gaware <atul.gaware <at> openbravo.com> Date: Mon Aug 10 10:23:33 2015 +0530 URL: http://code.openbravo.com/erp/backports/3.0PR15Q3/rev/1861f239c670b09737ef7359e7a74068622d205b [^] Fixes Issue 30528:Potential full c_orderline scan in M_Reservation_trg Removed unwanted line in code which fully scans c_orderline. --- M src-db/database/model/triggers/M_RESERVATION_TRG.xml ---

Issue History
Date Modified	Username	Field	Change
2015-08-10 06:51	AtulOpenbravo	Type	defect => backport
2015-08-10 06:51	AtulOpenbravo	Target Version	=> 3.0PR15Q3
2015-08-10 09:11	hgbot	Checkin
2015-08-10 09:11	hgbot	Note Added: 0079269
2015-08-10 09:11	hgbot	Status	scheduled => resolved
2015-08-10 09:11	hgbot	Resolution	open => fixed
2015-08-10 09:11	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/backports/3.0PR15Q3/rev/1861f239c670b09737ef7359e7a74068622d205b [^]
2015-08-10 09:11	vmromanos	Tag Attached: Approved
2015-08-10 09:12	vmromanos	Review Assigned To	=> vmromanos
2015-08-10 09:12	vmromanos	Status	resolved => closed