Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0030475
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] SEPA Credit Transfer Customer-to-Bankmajoralways2015-07-31 13:312015-09-08 12:29
ReporterngarciaView Statuspublic 
Assigned Todmiguelez 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision80b459549382
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket36373
OBNetwork customerOBPS
Regression introduced in release
Summary

0030475: Business Partner Generic Account should not be mandatory for creating Remittance File

DescriptionBusiness Partner Generic Account should not be mandatory for creating Remittance File
Steps To ReproduceAs group admin role:
   Create a Sales Invoice with SEPA Credit Transfer Customer-to-Bank Payment Method
   Define the Bank Account of the Business Partner of the invoice as:
      Bank Account Format: Use IBAN
      Generic Account No.: empty
      IBAN: ES8023100001180000012345
      SWIFT Code: DABAIE2D
      Country: Spain
   Check the GENERATE_BUSINESSPARTNER_IBAN parameter is set to N to SEPA Credit Transfer Customer-to-Bank (pain.001.001.03) remittance type
   Create a Remittance with that type and add the previously created invoice
   Process it
   Check the following error message is shown when clicking on Create Remittance File:
      Missing bank account for business partner ES-PR/0001 - Bebidas Alegres, S.L. in line no. 10
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0079992)
psanjuan (viewer)
2015-09-01 13:49
edited on: 2015-09-08 12:16

 Test Plan:

Organization's Financial Account needs to be setup as "Use IBAN" in the field "Bank Account Format". Enter a valid IBAN.

Create a Vendor, Vendor A, with below setup:
- PO Payment Method = SEPA Credit Transfer Customer to Bank
- PO Payment Terms = Treinta dias
- PO Financial Account = Bank

Create a purchase invoice for Vendor A above. Complete and Post the invoice.

Create a Remittance with below setup:
- Remittance Type: SEPA Credit Transfer Customer to Bank (pain.001.001.03)
Select the purchase invoice just created.

Every time you process the remittance change below setup in "Bank Account" tab of "Business Partner" window:
(1) Test Scenario:
Bank Account Format = Use Generic Account Nº
Generic Account Nº = 23100001180000012345
IBAN = empty
SWIFT = DABAIE2D
Go to Remittance Type window and search by "SEPA Credit Transfer Customer to Bank (pain.001.001.003). Go to Parameters tab and set "Generate_BusinessPartner_IBAN" to Y.
Process Remittance.
Check that the Generic Account Nº is filled in the Bank Instruction tab.
Create Remittance File.
Check that the remittance file is created properly and an IBAN is shown at the end for the Vendor.

(2) Test Scenario:
Go back to Remittance Type window and search by "SEPA Credit Transfer Customer to Bank (pain.001.001.003). Go to Parameters tab and set "Generate_BusinessPartner_IBAN" to N.

Go to remittance window and reactivate the remittance.
Process Remittance once more.

Check that the Generic Account Nº is filled in the Bank Instruction tab.
Create Remittance File.
An error is shown which is correct as there is no IBAN for the BP.

(3) Test Scenario:
Go back to the Bank Account tab of Vendor A and enter below setup:
Bank Account Format = Use Generic Account Nº
Generic Account Nº = 23100001180000012345
IBAN = ES8023100001180000012345
SWIFT = DABAIE2D

Go to the Remittance window and reactivate the remittance.
Process the remittance once again.

Check that the Generic Account Nº is filled in the Bank Instruction tab.
Create Remittance File.
Check that the remittance file is created properly and an IBAN is shown at the end for the Vendor.

(4) Test Scenario:
Go back to the Bank Account tab of Vendor A and enter below setup:
Bank Account Format = Use IBAN
Generic Account Nº = 23100001180000012345
IBAN = ES8023100001180000012345
SWIFT = DABAIE2D

Go to the Remittance window and reactivate the remittance.
Process the remittance once again.

Check that the Generic Account Nº is filled in the Bank Instruction tab.
Create Remittance File.
Check that the remittance file is created properly and an IBAN is shown at the end for the Vendor.

(5) Test Scenario:
Go back to the Bank Account tab of Vendor A and enter below setup:
Bank Account Format = Use IBAN
Generic Account Nº = empty
IBAN = ES8023100001180000012345
SWIFT = DABAIE2D

Go to the Remittance window and reactivate the remittance.
Process the remittance once again.

Check that IBAN is filled in the Bank Instruction tab.
Create Remittance File.
Check that the remittance file is created properly and an IBAN is shown at the end for the Vendor.

(6) Test Scenario:
Go back to the Bank Account tab of Vendor A and enter below setup:
Bank Account Format = Use SWIFT + Generic Account
Generic Account Nº = 23100001180000012345
IBAN = empty
SWIFT = DABAIE2D

Go back to Remittance Type window and search by "SEPA Credit Transfer Customer to Bank (pain.001.001.003). Go to Parameters tab and set "Generate_BusinessPartner_IBAN" to Y.

Go to Remittance window and Reactivate the remittance.
Process the remittance.
Check that the Generic Account is shown in Bank Instructions tab.
Create Remittance File.
Check that the remittance file is created properly and an IBAN is shown at the end for the Vendor.

(7) Test Scenario:
Go back to the Bank Account tab of Vendor A and enter below setup:
Bank Account Format = Use SWIFT + Generic Account
Generic Account Nº = 23100001180000012345
IBAN = empty
SWIFT = DABAIE2D

Go back to Remittance Type window and search by "SEPA Credit Transfer Customer to Bank (pain.001.001.003). Go to Parameters tab and set "Generate_BusinessPartner_IBAN" to N.

Go to Remittance window and Reactivate the remittance.
Process the remittance.
Check that the Generic Account is shown in Bank Instructions tab.
Create Remittance File.
An error is shown as there is no IBAN for BP Bank Account, this is correct.

(8) Test Scenario:
Go back to the Bank Account tab of Vendor A and enter below setup:
Bank Account Format = Use SWIFT + Generic Account
Generic Account Nº = 23100001180000012345
IBAN = ES8023100001180000012345
SWIFT = DABAIE2D

Go to Remittance window and Reactivate the remittance.
Process the remittance.
Check that the Generic Account is shown in Bank Instructions tab.
Create Remittance File.
Check that the remittance file is created properly and an IBAN is shown at the end for the Vendor.

Repeat all steps above for below remittance types related to Sales.
Core Direct Debit
Direct Debit B2B

For doing that create two Customers one of them link to "SEPA B2B Direct Debit Customer to Bank" payment method, and the other one related to "SEPA Core Direct Debit Customer to Bank" Payment Method.
Create also two sales invoices to include in each remittance type.
After that change "Bank Account" setup of each Customer.
(0080209)
hgbot (developer)
2015-09-07 18:30

 Repository: erp/mods/org.openbravo.module.remittance
Changeset: 80b459549382c43308dd01eeef61b9bc4e7553ef
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Sep 07 12:06:43 2015 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/80b459549382c43308dd01eeef61b9bc4e7553ef [^]

Fixes Issue 30475. When Processing the Remmitance, in the Bank Instruction,
if the Business Partner has no Generic Bank Account defined and is configured
to use an IBAN, and the IBAN is filled, it sets the IBAN as the Account No.

---
M src-db/database/sourcedata/AD_MODULE.xml
M src/org/openbravo/module/remittance/process/REM_RemittanceProcess.java
---
(0080210)
hgbot (developer)
2015-09-07 18:30

 Repository: erp/pmods/org.openbravo.sepa.iso20022
Changeset: d907aadefb24c64d9be53690d1a8458feb665cb2
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Sep 07 12:15:43 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.sepa.iso20022/rev/d907aadefb24c64d9be53690d1a8458feb665cb2 [^]

Related to Issue 30475. When generating the SEPA file, support the
possibility that a Business Partner may have an IBAN defined but not
a Generic Account.

---
M src-db/database/sourcedata/AD_MODULE.xml
M src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M src/org/openbravo/sepa/iso20022/util/SEPAUtil.java
---
(0080211)
hgbot (developer)
2015-09-07 18:31

 Repository: erp/pmods/org.openbravo.sepa.iso20022.coredirectdebit.customertobank
Changeset: 05e3c9a6b9a3ca0ebca3c89c3f25ed58260566d2
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Sep 03 16:39:48 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.sepa.iso20022.coredirectdebit.customertobank/rev/05e3c9a6b9a3ca0ebca3c89c3f25ed58260566d2 [^]

Related to Issue 30475. Updated dependency to SEPA Infrastructure Module.

---
M src-db/database/sourcedata/AD_MODULE.xml
M src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
---
(0080212)
hgbot (developer)
2015-09-07 18:31

 Repository: erp/pmods/org.openbravo.sepa.iso20022.credittransfer.customertobank
Changeset: ca9a2fbd4bddce6213111db542ac06a545c18a0f
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Sep 03 16:40:42 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.sepa.iso20022.credittransfer.customertobank/rev/ca9a2fbd4bddce6213111db542ac06a545c18a0f [^]

Related to Issue 30475. Updated dependency to SEPA Infrastructure Module.

---
M src-db/database/sourcedata/AD_MODULE.xml
M src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
---
(0080237)
vmromanos (viewer)
2015-09-08 09:16

 Code review OK
(0080242)
psanjuan (viewer)
2015-09-08 12:28
edited on: 2015-09-08 12:29

 All scenarios above verified for Credit Transfer and Direct Debit (Core and B2B).

Issue solved in below versions of the modules:

SEPA Credit Transfer 1.0.8
SEPA Direct Debit (Core and B2B) 1.0.8
SEPA Framework and Utililiest 1.0.5
Remittance Infrastructure 3.2.23

Issue Closed.

- Issue History
Date Modified Username Field Change
2015-07-31 13:31 ngarcia New Issue
2015-07-31 13:31 ngarcia Assigned To => Triage Finance
2015-07-31 13:31 ngarcia OBNetwork customer => Yes
2015-07-31 13:31 ngarcia Issue Monitored: networkb
2015-07-31 13:35 ngarcia Resolution time => 1442181600
2015-07-31 13:35 ngarcia Support ticket => 36373
2015-08-10 11:25 eugeni Issue Monitored: eugeni
2015-08-31 10:51 dmiguelez Assigned To Triage Finance => dmiguelez
2015-09-01 13:49 psanjuan Note Added: 0079992
2015-09-01 14:11 psanjuan Note Edited: 0079992 View Revisions
2015-09-01 14:16 psanjuan Note Edited: 0079992 View Revisions
2015-09-01 14:20 psanjuan Note Edited: 0079992 View Revisions
2015-09-01 14:23 psanjuan Note Edited: 0079992 View Revisions
2015-09-02 10:06 psanjuan Note Edited: 0079992 View Revisions
2015-09-02 16:56 dmiguelez Status new => scheduled
2015-09-07 18:30 hgbot Checkin
2015-09-07 18:30 hgbot Note Added: 0080209
2015-09-07 18:30 hgbot Status scheduled => resolved
2015-09-07 18:30 hgbot Resolution open => fixed
2015-09-07 18:30 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/80b459549382c43308dd01eeef61b9bc4e7553ef [^]
2015-09-07 18:30 hgbot Checkin
2015-09-07 18:30 hgbot Note Added: 0080210
2015-09-07 18:31 hgbot Checkin
2015-09-07 18:31 hgbot Note Added: 0080211
2015-09-07 18:31 hgbot Checkin
2015-09-07 18:31 hgbot Note Added: 0080212
2015-09-08 09:16 vmromanos Note Added: 0080237
2015-09-08 12:16 psanjuan Note Edited: 0079992 View Revisions
2015-09-08 12:28 psanjuan Note Added: 0080242
2015-09-08 12:29 psanjuan Note Edited: 0080242 View Revisions
2015-09-08 12:29 psanjuan Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker