0029903: Performance improvement in EntityAccessChecker.initialize

127913 [pool-5-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Pre-1 cnt: 100 avg millis: 14
Timings for Pre-1 cnt: 100 avg millis: 14
127995 [pool-5-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Pre-2 cnt: 100 avg millis: 100
Timings for Pre-2 cnt: 100 avg millis: 100
200934 [pool-5-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Pre-1 cnt: 200 avg millis: 12
Timings for Pre-1 cnt: 200 avg millis: 12
201000 [pool-5-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Pre-2 cnt: 200 avg millis: 94
Timings for Pre-2 cnt: 200 avg millis: 94
271120 [pool-5-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Pre-1 cnt: 300 avg millis: 12
Timings for Pre-1 cnt: 300 avg millis: 12
271190 [pool-5-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Pre-2 cnt: 300 avg millis: 91
Timings for Pre-2 cnt: 300 avg millis: 91
286035 [pool-5-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Pre-rollback cnt: 400 avg millis: 0
Timings for Pre-rollback cnt: 400 avg millis: 0
286039 [pool-5-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Pre-Process cnt: 400 avg millis: 73
Timings for Pre-Process cnt: 400 avg millis: 73
286611 [pool-5-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for processPayments cnt: 400 avg millis: 41
Timings for processPayments cnt: 400 avg millis: 41
286619 [pool-5-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for orderLoader cnt: 400 avg millis: 136
Timings for orderLoader cnt: 400 avg millis: 136
286629 [pool-5-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Order cnt: 400 avg millis: 222
Timings for Order cnt: 400 avg millis: 222
309957 [DefaultQuartzScheduler_Worker-8] INFO  org.openbravo.scheduling.ProcessMonitor - There's another instance running, so leavingAcct Server Process 
338021 [pool-11-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Pre-rollback cnt: 500 avg millis: 0
Timings for Pre-rollback cnt: 500 avg millis: 0
338115 [pool-11-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Pre-Process cnt: 500 avg millis: 70
Timings for Pre-Process cnt: 500 avg millis: 70
340273 [pool-10-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for processPayments cnt: 500 avg millis: 41
Timings for processPayments cnt: 500 avg millis: 41
340278 [pool-10-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for orderLoader cnt: 500 avg millis: 133
Timings for orderLoader cnt: 500 avg millis: 133
340291 [pool-10-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Order cnt: 500 avg millis: 218
Timings for Order cnt: 500 avg millis: 218

129811 [pool-7-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Pre-rollback cnt: 100 avg millis: 0
Timings for Pre-rollback cnt: 100 avg millis: 0
129835 [pool-7-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Pre-Process cnt: 100 avg millis: 24
Timings for Pre-Process cnt: 100 avg millis: 24
130983 [pool-8-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for processPayments cnt: 100 avg millis: 53
Timings for processPayments cnt: 100 avg millis: 53
130989 [pool-8-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for orderLoader cnt: 100 avg millis: 156
Timings for orderLoader cnt: 100 avg millis: 156
131008 [pool-8-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Order cnt: 100 avg millis: 199
Timings for Order cnt: 100 avg millis: 199
147797 [pool-8-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Pre-1 cnt: 100 avg millis: 18
Timings for Pre-1 cnt: 100 avg millis: 18
147809 [pool-8-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Pre-2 cnt: 100 avg millis: 29
Timings for Pre-2 cnt: 100 avg millis: 29
190942 [pool-9-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Pre-rollback cnt: 200 avg millis: 0
Timings for Pre-rollback cnt: 200 avg millis: 0
190963 [pool-9-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Pre-Process cnt: 200 avg millis: 22
Timings for Pre-Process cnt: 200 avg millis: 22
192812 [pool-6-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for processPayments cnt: 200 avg millis: 49
Timings for processPayments cnt: 200 avg millis: 49
192817 [pool-6-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for orderLoader cnt: 200 avg millis: 145
Timings for orderLoader cnt: 200 avg millis: 145
192830 [pool-6-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Order cnt: 200 avg millis: 184
Timings for Order cnt: 200 avg millis: 184
221900 [pool-8-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Pre-1 cnt: 200 avg millis: 15
Timings for Pre-1 cnt: 200 avg millis: 15
221926 [pool-8-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Pre-2 cnt: 200 avg millis: 25
Timings for Pre-2 cnt: 200 avg millis: 25
253661 [pool-7-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Pre-rollback cnt: 300 avg millis: 0
Timings for Pre-rollback cnt: 300 avg millis: 0
253663 [pool-7-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Pre-Process cnt: 300 avg millis: 21
Timings for Pre-Process cnt: 300 avg millis: 21
253913 [pool-7-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for processPayments cnt: 300 avg millis: 46
Timings for processPayments cnt: 300 avg millis: 46
253919 [pool-7-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for orderLoader cnt: 300 avg millis: 137
Timings for orderLoader cnt: 300 avg millis: 137
253939 [pool-7-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Order cnt: 300 avg millis: 176
Timings for Order cnt: 300 avg millis: 176
296803 [pool-8-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Pre-1 cnt: 300 avg millis: 14
Timings for Pre-1 cnt: 300 avg millis: 14
296815 [pool-8-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Pre-2 cnt: 300 avg millis: 23
Timings for Pre-2 cnt: 300 avg millis: 23
312679 [pool-6-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Pre-rollback cnt: 400 avg millis: 0
Timings for Pre-rollback cnt: 400 avg millis: 0
312697 [pool-6-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Pre-Process cnt: 400 avg millis: 20
Timings for Pre-Process cnt: 400 avg millis: 20
313819 [pool-7-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for processPayments cnt: 400 avg millis: 44
Timings for processPayments cnt: 400 avg millis: 44
313828 [pool-7-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for orderLoader cnt: 400 avg millis: 136
Timings for orderLoader cnt: 400 avg millis: 136
313843 [pool-7-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Order cnt: 400 avg millis: 173
Timings for Order cnt: 400 avg millis: 173
367967 [pool-8-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Pre-1 cnt: 400 avg millis: 13
Timings for Pre-1 cnt: 400 avg millis: 13
367973 [pool-8-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Pre-2 cnt: 400 avg millis: 22
Timings for Pre-2 cnt: 400 avg millis: 22
370253 [pool-7-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Pre-rollback cnt: 500 avg millis: 0
Timings for Pre-rollback cnt: 500 avg millis: 0
370256 [pool-7-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Pre-Process cnt: 500 avg millis: 19
Timings for Pre-Process cnt: 500 avg millis: 19
371039 [pool-8-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for processPayments cnt: 500 avg millis: 43
Timings for processPayments cnt: 500 avg millis: 43
371044 [pool-8-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for orderLoader cnt: 500 avg millis: 135
Timings for orderLoader cnt: 500 avg millis: 135
371063 [pool-8-thread-1] INFO  org.openbravo.service.importprocess.ImportEntryManager - Timings for Order cnt: 500 avg millis: 171
Timings for Order cnt: 500 avg millis: 171
463881 [DefaultQuartzScheduler_Worker-1] INFO  org.openbravo.scheduling.ProcessMonitor - There's another instance running, so leavingAcct Server Process 

diff --git a/src/org/openbravo/dal/security/EntityAccessChecker.java b/src/org/openbravo/dal/security/EntityAccessChecker.java
--- a/src/org/openbravo/dal/security/EntityAccessChecker.java
+++ b/src/org/openbravo/dal/security/EntityAccessChecker.java
@@ -32,13 +32,10 @@
 import org.openbravo.base.model.ModelProvider;
 import org.openbravo.base.model.Property;
 import org.openbravo.base.provider.OBNotSingleton;
-import org.openbravo.dal.core.DalUtil;
 import org.openbravo.dal.core.OBContext;
 import org.openbravo.dal.core.SessionHandler;
 import org.openbravo.model.ad.access.TableAccess;
-import org.openbravo.model.ad.access.WindowAccess;
 import org.openbravo.model.ad.ui.Tab;
-import org.openbravo.model.ad.ui.Window;
 
 /**
  * This class is responsible for determining the allowed read/write access for a combination of user
@@ -106,19 +103,18 @@
       final String userLevel = obContext.getUserLevel();
 
       // Don't use dal because otherwise we can end up in infinite loops
-      String qryStr = "select t from " + Tab.class.getName() + " t"
-          + " join fetch t.window w join fetch w.aDWindowAccessList wa"
+      // there is always only one windowaccess per role due to unique constraints
+      final String qryStr = "select t.table.id, wa.editableField from " + Tab.class.getName()
+          + " t left join t.window w left join w.aDWindowAccessList wa"
           + " where wa.role.id= :roleId";
       final Query qry = SessionHandler.getInstance().createQuery(qryStr);
       qry.setParameter("roleId", getRoleId());
       @SuppressWarnings("unchecked")
-      final List<Tab> tabs = qry.list();
-      for (final Tab t : tabs) {
-        final Window w = t.getWindow();
-        // Guaranteed that there's only one record because of unique constraint
-        final WindowAccess wa = w.getADWindowAccessList().get(0);
-        final boolean writeAccess = wa.isEditableField();
-        String tableId = (String) DalUtil.getId(t.getTable());
+      final List<Object> tabData = qry.list();
+      for (final Object o : tabData) {
+        final Object[] os = (Object[]) o;
+
+        final String tableId = (String) os[0];
         final Entity e = mp.getEntityByTableId(tableId);
         if (e == null) { // happens for AD_Client_Info and views
           continue;
@@ -129,6 +125,7 @@
           continue;
         }
 
+        final boolean writeAccess = (Boolean) os[1];
         if (writeAccess) {
           writableEntities.add(e);
           readableEntities.add(e);