Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0029160
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminoralways2015-03-06 09:302015-03-13 13:02
ReporteraaroncaleroView Statuspublic 
Assigned Toaaroncalero 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision6223f8155593
ProjectionnoneETAnoneTarget VersionRR15Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toadrianromero
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0029160: The BarcodeActionHandler component should be refactored to allow more specific extensions

DescriptionThe BarcodeActionHandler component should be refactored to allow more specific extensions.
The way it is now, if an external module requires to extend the OB.UI.BarcodeActionHandler component to do a custom search, it must override the findProductByBarcode function and all the callbacks inside it, thus duplicating code.
It is not possible to override just one callback.
Steps To ReproduceCheck the web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js on the org.openbravo.retail.posterminal module and verify that the component contains only the functions addWhereFilter and findProductByBarcode.
Proposed SolutionAll callbacks should be 'public' functions of the component, so external modules can override them independently
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0035812 closedSandrahuguet Upc filter is wrong built in remote query for products 
blocks defect 0029161RR15Q2 closedaaroncalero [MultiUPC] Refactor the Retail MultiUPC module to use the new BarcodeHandler componen structure 

-  Notes
(0075237)
hgbot (developer)
2015-03-06 11:06

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6223f8155593fe908e1e5437816bd16a78ca32c4
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Fri Mar 06 11:04:38 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6223f8155593fe908e1e5437816bd16a78ca32c4 [^]

Fixed issue 29160: The BarcodeActionHandler component should be refactored to allow more specific extensions

Refactored the OB.UI.BarcodeActionHandler component:
Split the search flow into several independent functions: findProductByBarcode, searchProduct, searchProductCallback and successCallbackProducts
Changed the OB.Dal.query into an OB.Dal.find for better performance
The product UPC is now upper'd on the master data query instead of on the client
Removed the addWhereFilter function as it's no longer used

---
M src/org/openbravo/retail/posterminal/master/ProductProperties.java
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
---
(0075551)
adrianromero (manager)
2015-03-13 13:02

 Verified

- Issue History
Date Modified Username Field Change
2015-03-06 09:30 aaroncalero New Issue
2015-03-06 09:30 aaroncalero Assigned To => aaroncalero
2015-03-06 09:30 aaroncalero Triggers an Emergency Pack => No
2015-03-06 09:38 aaroncalero Relationship added blocks 0029161
2015-03-06 11:06 hgbot Checkin
2015-03-06 11:06 hgbot Note Added: 0075237
2015-03-06 11:06 hgbot Status new => resolved
2015-03-06 11:06 hgbot Resolution open => fixed
2015-03-06 11:06 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6223f8155593fe908e1e5437816bd16a78ca32c4 [^]
2015-03-13 13:02 adrianromero Review Assigned To => adrianromero
2015-03-13 13:02 adrianromero Note Added: 0075551
2015-03-13 13:02 adrianromero Status resolved => closed
2017-04-20 16:51 Sandrahuguet Relationship added related to 0035812

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker