Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0028979
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Z. Othersmajoralways2015-02-18 13:112015-02-25 21:22
ReporterngarciaView Statuspublic 
Assigned Toaferraz 
PriorityimmediateResolutionfixedFixed in Version3.0PR15Q2
StatusclosedFix in branchFixed in SCM revision92405876894e
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customerOBPS
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket34352
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0028979: UpdateCustomerBalance modulescript is wrongly calculating the Current Balance

DescriptionUpdateCustomerBalance modulescript is wrongly calculating the Current Balance. It does not take into account partial payments and credit is wrongly added: Credit for receipts (payment in) should be negative while credit for payments (payment out) should be positive
Steps To ReproduceAs group admin role:
   Create a Business Partner set as Customer
   Add a Payment In to it where a credit of 100 is generated
   Check the Current Balance in the Business Partner window is -100. This is correct
   Create a Business Partner set as Vendor
   Generate a Purchase Invoice for it
   Check its Current Balance is for the whole amount of the invoice (but negative). This is correct
   Add a partial payment out to it
   Check its Current Balance is for the pending amount of the invoice (but negative). This is correct
As system admin role:
   Delete the IsCustomerBalanceRestored preference

Launch ant smartbuild -Dlocal=No in order the modulescript to be applied and restart tomcat

As group admin role:
   Check the Current Balance in the Business Partner window for the Customer is 100. This is incorrect, it should be negative
   Check the Current Balance in the Business Partner window for the Vendor is the whole amount of the invoice (but negative). This is incorrect, it should be the outstanding amount (but negative)
TagsNo tags attached.
Attached Filesdiff file icon 28979.diff [^] (1,619 bytes) 2015-02-18 13:35 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00248663.0PR14Q2 closedAtulOpenbravo Preference "IsCustomerBalanceRestored" should be created in UpdateCustomerBalance modulescript 

-  Notes
(0074663)
aferraz (viewer)
2015-02-19 14:45
edited on: 2015-02-19 14:46

 Test plan:

As group admin role:

   Create a Business Partner set as Customer
   Add a Payment In to it where a credit of 100 is generated
   Check the Current Balance in the Business Partner window is -100. This is correct
   Create a Business Partner set as Vendor
   Generate a Purchase Invoice for it
   Check its Current Balance is for the whole amount of the invoice (but negative). This is correct
   Add a partial payment out to it
   Check its Current Balance is for the pending amount of the invoice (but negative). This is correct
As system admin role:
   Delete the IsCustomerBalanceRestored preference

Launch ant smartbuild -Dlocal=No in order the modulescript to be applied and restart tomcat

As group admin role:
   Check the Current Balance in the Business Partner window for the Customer is 100 (but negative).
   Check the Current Balance in the Business Partner window for the Vendor is the outstanding amount of the invoice (but negative).
(0074900)
hgbot (developer)
2015-02-25 10:09

 Repository: erp/devel/pi
Changeset: 92405876894e532479d9de83244806ee1436dda5
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Feb 25 09:53:23 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/92405876894e532479d9de83244806ee1436dda5 [^]

Fixes issue 28979: UpdateCustomerBalance is wrongly calculating CurrentBalance

UpdateCustomerBalance modulescript has been modified in order to get credit for receipts as negative and credit for payments as positive. Also, it now takes into account partial payments.

---
M modules/org.openbravo.advpaymentmngt/build/classes/org/openbravo/advpaymentmngt/modulescript/UpdateCustomerBalanceData.class
M modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/org/openbravo/advpaymentmngt/modulescript/UpdateCustomerBalance_data.xsql
M modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/src/org/openbravo/advpaymentmngt/modulescript/UpdateCustomerBalanceData.java
---
(0074902)
Sandrahuguet (viewer)
2015-02-25 10:13

 Code review + testing ok
(0074947)
hudsonbot (viewer)
2015-02-25 21:22

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/96ba7b028cb7 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2015-02-18 13:11 ngarcia New Issue
2015-02-18 13:11 ngarcia Assigned To => Sandrahuguet
2015-02-18 13:11 ngarcia OBNetwork customer => Yes
2015-02-18 13:11 ngarcia Modules => Advanced Payables and Receivables Mngmt
2015-02-18 13:11 ngarcia Support ticket => 34352
2015-02-18 13:11 ngarcia Resolution time => 1426806000
2015-02-18 13:11 ngarcia Triggers an Emergency Pack => No
2015-02-18 13:15 ngarcia Relationship added related to 0024866
2015-02-18 13:15 ngarcia Issue Monitored: networkb
2015-02-18 13:16 ngarcia File Added: 28979.diff
2015-02-18 13:34 ngarcia File Deleted: 28979.diff
2015-02-18 13:35 ngarcia File Added: 28979.diff
2015-02-19 12:18 Sandrahuguet Assigned To Sandrahuguet => ngarcia
2015-02-19 12:18 Sandrahuguet Assigned To ngarcia => aferraz
2015-02-19 13:35 aferraz Steps to Reproduce Updated View Revisions
2015-02-19 14:45 aferraz Note Added: 0074663
2015-02-19 14:46 aferraz Note Edited: 0074663 View Revisions
2015-02-24 15:41 ngarcia Steps to Reproduce Updated View Revisions
2015-02-25 10:09 hgbot Checkin
2015-02-25 10:09 hgbot Note Added: 0074900
2015-02-25 10:09 hgbot Status new => resolved
2015-02-25 10:09 hgbot Resolution open => fixed
2015-02-25 10:09 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/92405876894e532479d9de83244806ee1436dda5 [^]
2015-02-25 10:13 Sandrahuguet Review Assigned To => Sandrahuguet
2015-02-25 10:13 Sandrahuguet Note Added: 0074902
2015-02-25 10:13 Sandrahuguet Status resolved => closed
2015-02-25 10:13 Sandrahuguet Fixed in Version => 3.0PR15Q2
2015-02-25 21:22 hudsonbot Checkin
2015-02-25 21:22 hudsonbot Note Added: 0074947

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker