Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0028768 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | major | have not tried | 2015-01-26 14:49 | 2015-01-29 17:56 | |||
| Reporter | mtaal | View Status | public | |||||
| Assigned To | migueldejuana | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | RR15Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 025fcecf9446 | ||||
| Projection | none | ETA | none | Target Version | RR15Q1 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | marvintm | |||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | Pre packaging ( pi ) | |||||||
| Regression date | 2014-11-07 | |||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/195fc620eeb2fcb3b44ba1bb1540ea43ecabe330 [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0028768: Cashup date is wrong, it is set to the cashup creation date and time and not the date/time when the cashup is finally done | |||||||
| Description | See the attached screenshot. The cashup date/time is equal to the creation time of the cashup, the time the till/session started. This is however not equal to the date/time the cashup was finally done/completed. See the screenshot, the first ticket of this cashup was done on the 21st of Jan, the cashup was finally done on te 26th, the cashup date/time is wrong. | |||||||
| Steps To Reproduce | - start a fresh cashup in the client - create some tickets - wait a few minutes - do a cashup - check in the backend that the cashup has a cashup date/time equal to the cashup creation time and not equal to the time the cashup was done | |||||||
| Proposed Solution | Set the cashup date/time equal to the time the cashup was finalized on the client. (note should be the client side time, not the server side creation/update time) Check the causing commit: https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/195fc620eeb2fcb3b44ba1bb1540ea43ecabe330#l14.35 [^] this commit sets the cashup date at the time the cashup record is created. While the previous version set the cashup date/time at the time the cashup report was shown: https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/195fc620eeb2fcb3b44ba1bb1540ea43ecabe330#l19.200 [^] The latter approach is correct. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  Selection_096.png [^] (84,337 bytes) 2015-01-26 14:49
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0073781) mtaal (viewer) 2015-01-26 15:16 |
Probably the fix is to set the current date/time at this line: https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/74be63e9a638/web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js#l593 [^] Note that other code uses the toISOString, check if this works here to: (new Date()).toISOString() |
|
(0073851) hgbot (developer) 2015-01-28 10:27 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 025fcecf94460e0dd9781cb3f1d6b1a1c8d821ae Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Wed Jan 28 10:27:09 2015 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/025fcecf94460e0dd9781cb3f1d6b1a1c8d821ae [^] Fixed issue 0028768: Cashup date is wrong, it is set to the cashup creation date and time and not the date/time when the cashup is finally done Update cashup date every time we update cashup info --- M src/org/openbravo/retail/posterminal/ProcessCashClose.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-01-26 14:49 | mtaal | New Issue | |
| 2015-01-26 14:49 | mtaal | Assigned To | => migueldejuana |
| 2015-01-26 14:49 | mtaal | File Added: Selection_096.png | |
| 2015-01-26 14:49 | mtaal | OBNetwork customer | => No |
| 2015-01-26 14:49 | mtaal | Regression level | => Pre packaging ( pi ) |
| 2015-01-26 14:49 | mtaal | Regression date | => 2014-11-07 |
| 2015-01-26 14:49 | mtaal | Regression introduced by commit | => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/195fc620eeb2fcb3b44ba1bb1540ea43ecabe330 [^] |
| 2015-01-26 14:49 | mtaal | Triggers an Emergency Pack | => No |
| 2015-01-26 15:16 | mtaal | Note Added: 0073781 | |
| 2015-01-28 10:27 | hgbot | Checkin | |
| 2015-01-28 10:27 | hgbot | Note Added: 0073851 | |
| 2015-01-28 10:27 | hgbot | Status | new => resolved |
| 2015-01-28 10:27 | hgbot | Resolution | open => fixed |
| 2015-01-28 10:27 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/025fcecf94460e0dd9781cb3f1d6b1a1c8d821ae [^] |
| 2015-01-29 17:56 | marvintm | Review Assigned To | => marvintm |
| 2015-01-29 17:56 | marvintm | Status | resolved => closed |
| 2015-01-29 17:56 | marvintm | Fixed in Version | => RR15Q1 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |