Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0027553
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Z. Othersminoralways2014-09-08 14:202014-12-30 23:22
ReporterngarciaView Statuspublic 
Assigned Toreinaldoguerra 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision3d7c11cf422d
ProjectionnoneETAnoneTarget Version3.0PR15Q1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket30883
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0027553: Wrong error message shown when reactivating a payment whose payment method does not belong to the financial account

DescriptionWrong error message shown when reactivating a payment whose payment method does not belong to the financial account
Steps To ReproduceAs group admin role:
   Create a Payment In
   Remove the Payment Method from the Financial Account
   Try to reactivate the Payment In
   The following error message is shown:
      'For input string: "N"'
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0070529)
reinaldoguerra (viewer)
2014-09-30 05:58

 Test plan used:
1- Login into Openbravo ERP
2- Create a Payment In
3- Remove the Payment Method from the Financial Account
4- Try to reactivate the Payment In
5- A personalizad error message will be shown.

6- Also create another Payment In
7- Remove the Payment Method from the Financial Account
8- Go to tab transaction, select created payment and try to reactivate it
9- A personalizad error message will be shown.
(0070839)
hgbot (developer)
2014-10-09 12:45

 Repository: erp/devel/pi
Changeset: bee471407691773c0406b40c751cb73584fa7742
Author: Reinaldo Guerra <reinaldo.guerra <at> peoplewalking.com>
Date: Mon Sep 29 12:06:31 2014 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/bee471407691773c0406b40c751cb73584fa7742 [^]

Fixed bug 27553: Wrong error message shown when reactivating a payment.

Payment process was modified to manage the option of reactivating a payment whose payment method does not belong to the financial account.
Now a personalized error message is shown.
Transaction process in Transaction tab of the Finantial Account window also was modified for the same cause.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_TransactionProcess.java
---
(0070840)
hgbot (developer)
2014-10-09 12:45

 Repository: erp/devel/pi
Changeset: 3d7c11cf422d741b803488a2a86052b2c5383b98
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Oct 09 12:42:53 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3d7c11cf422d741b803488a2a86052b2c5383b98 [^]

Fixed bug 27553: Code review improvements

Message provides more context info, which is specially important when reactivating the transaction.

In the case of reactivating a transaction, this validation has been moved close to other validations executed before reactivating the transaction.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_TransactionProcess.java
---
(0070841)
vmromanos (viewer)
2014-10-09 12:47

 Code review + testing OK
(0072922)
hudsonbot (viewer)
2014-12-30 23:22

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test
(0072923)
hudsonbot (viewer)
2014-12-30 23:22

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2014-09-08 14:20 ngarcia New Issue
2014-09-08 14:20 ngarcia Assigned To => jonalegriaesarte
2014-09-08 14:20 ngarcia OBNetwork customer => Yes
2014-09-08 14:20 ngarcia Modules => Core
2014-09-08 14:20 ngarcia Support ticket => 30883
2014-09-08 14:20 ngarcia Resolution time => 1416524400
2014-09-08 14:20 ngarcia Triggers an Emergency Pack => No
2014-09-08 15:09 ngarcia Issue Monitored: networkb
2014-09-22 16:36 jonalegriaesarte Target Version => 3.0PR15Q1
2014-09-27 05:23 reinaldoguerra Assigned To jonalegriaesarte => reinaldoguerra
2014-09-27 05:23 reinaldoguerra Status new => scheduled
2014-09-30 05:58 reinaldoguerra Note Added: 0070529
2014-10-09 12:45 hgbot Checkin
2014-10-09 12:45 hgbot Note Added: 0070839
2014-10-09 12:45 hgbot Status scheduled => resolved
2014-10-09 12:45 hgbot Resolution open => fixed
2014-10-09 12:45 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/bee471407691773c0406b40c751cb73584fa7742 [^]
2014-10-09 12:45 hgbot Checkin
2014-10-09 12:45 hgbot Note Added: 0070840
2014-10-09 12:45 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/bee471407691773c0406b40c751cb73584fa7742 [^] => http://code.openbravo.com/erp/devel/pi/rev/3d7c11cf422d741b803488a2a86052b2c5383b98 [^]
2014-10-09 12:47 vmromanos Review Assigned To => vmromanos
2014-10-09 12:47 vmromanos Note Added: 0070841
2014-10-09 12:47 vmromanos Status resolved => closed
2014-12-30 23:22 hudsonbot Checkin
2014-12-30 23:22 hudsonbot Note Added: 0072922
2014-12-30 23:22 hudsonbot Checkin
2014-12-30 23:22 hudsonbot Note Added: 0072923

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker