Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0025837
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 05. Production managementtrivialalways2014-02-25 22:252014-03-12 14:59
ReporterchelipfView Statuspublic 
Assigned Todmiguelez 
PrioritylowResolutionopenFixed in Version
StatusnewFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava version1.6.0_27
OS VersionDebian WheezyDatabase version9.1Ant version1.8.2
Product Version2.50MP51SCM revision 
Review Assigned To
Web browserMozilla Firefox
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0025837: Generate production costs is not calculated properly

DescriptionThe order in which Openbravo computes the production cost is wrong. It is based on 2.40 version and below when primary key was an autonumeric type.
Steps To ReproduceExecute generate production cost process.
Proposed SolutionCheck out the attached patch.
TagsNo tags attached.
Attached Filesdiff file icon MA_PRODUCTION_COST_GENERATE.diff [^] (772 bytes) 2014-02-25 22:25 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0065089)
dmiguelez (developer)
2014-03-12 10:16

Dear Partner,

We appreciate your contribution by reporting an Issue and also by giving the solution to it, and we will include it in our Product as soon as we can.

But we've changed the severity status of the Issue from critical to trivial and the priority from high to low, and this is the reason why.

Although what you report is an Issue, and we will fix it, it is a minor Issue. It is true that using the Id column to order the data is not the best option, since it is an auto generated value and it is random.
But, please realize that we first order the query by movement date. And that is the only important column to order the query by.
The reason we also order by another column is that, if two records have the same movement date, it is not important which one comes first, but is important that they always return in the same order, no matter how many time the query is executed, that is why we added an additional column to the order clause, to maintain consistency.
As you report, this is not the best option due to the random nature of the id, and we will fix it with the document number as you propose. But, also keep in mind that the id is generated once when the record is inserted, so in with the same set of data, you will get the same order of records for the query all the times.

Thanks you four your contribution.
Regards.
(0065097)
chelipf (reporter)
2014-03-12 14:59

Hi dminguelez, you are right in the context where you have not accounting process for goods receipt and goods shipments (m_inout) that is the case of Spain, but when you must post that kind of documents (the case of Ecuador), if yo don't use this fix and this other one[1] the accounting and the module data don't match. That's the reason why I set the priority to high and the severity to critical.


Thanks

[1]https://issues.openbravo.com/view.php?id=25717 [^]

- Issue History
Date Modified Username Field Change
2014-02-25 22:25 chelipf New Issue
2014-02-25 22:25 chelipf Assigned To => dmiguelez
2014-02-25 22:25 chelipf File Added: MA_PRODUCTION_COST_GENERATE.diff
2014-02-25 22:25 chelipf Web browser => Mozilla Firefox
2014-02-25 22:25 chelipf Modules => Core
2014-02-25 22:25 chelipf Triggers an Emergency Pack => No
2014-03-12 10:16 dmiguelez Web browser Mozilla Firefox => Mozilla Firefox
2014-03-12 10:16 dmiguelez Note Added: 0065089
2014-03-12 10:16 dmiguelez Priority high => low
2014-03-12 10:16 dmiguelez Severity critical => trivial
2014-03-12 14:59 chelipf Note Added: 0065097


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker