0025717: Generate production costs doesn't take into account inventory adjustments.

Description

Generate production costs doesn't take into account inventory adjustments because of it doesn't take into account when m_productionline_id column of m_transaction table is null.

Steps To Reproduce

-Create a inventory adjustement.
-Execute generate production costs process.
-The process sets v_qty without taking into account inventory adjustments.

Proposed Solution

Check out the attached patch.

Tags

Sidesoft

Attached Files

MA_PRODUCTION_COST.diff [^] (2,250 bytes) 2014-02-12 23:34 [Show Content] [Hide Content]

--- /home/cheli/mercurial250/OpenbravoERP-2.50MP51/src-db/database/model/functions/MA_PRODUCTION_COST.xml	2014-02-10 16:47:29.208196526 -0500
+++ src-db/database/model/functions/MA_PRODUCTION_COST.xml	2014-02-12 17:24:36.881505582 -0500
@@ -438,14 +438,14 @@
                       FROM M_TRANSACTION
                       WHERE M_PRODUCT_ID = Cur_ProductionLine.M_PRODUCT_ID
                         AND MOVEMENTDATE < v_ProductionDate
-                        AND M_PRODUCTIONLINE_ID <> Cur_ProductionLine.M_PRODUCTIONLINE_ID
+                        AND (M_PRODUCTIONLINE_ID <> Cur_ProductionLine.M_PRODUCTIONLINE_ID OR M_PRODUCTIONLINE_ID IS NULL)
                       UNION
                       SELECT MT.M_PRODUCTIONLINE_ID, MT.MOVEMENTQTY
                       FROM M_TRANSACTION MT, M_PRODUCTIONLINE MP
                       WHERE MT.M_PRODUCT_ID = Cur_ProductionLine.M_PRODUCT_ID
                         AND MT.MOVEMENTDATE = v_ProductionDate
                         AND MT.M_PRODUCTIONLINE_ID = MP.M_PRODUCTIONLINE_ID
-                        AND MT.M_PRODUCTIONLINE_ID <> Cur_ProductionLine.M_PRODUCTIONLINE_ID
+                        AND (MT.M_PRODUCTIONLINE_ID <> Cur_ProductionLine.M_PRODUCTIONLINE_ID OR MT.M_PRODUCTIONLINE_ID IS NULL)
                         AND MP.CALCULATED = 'Y') T ;
                 --LEFT JOIN M_PRODUCTIONLINE ON T.M_PRODUCTIONLINE_ID = M_PRODUCTIONLINE.M_PRODUCTIONLINE_ID
                 --AND CALCULATED = 'Y';
@@ -478,7 +478,7 @@
                       FROM M_TRANSACTION
                       WHERE M_PRODUCT_ID = Cur_ProductionLine.M_PRODUCT_ID
                         AND MOVEMENTDATE <= v_ProductionDate
-                        AND M_PRODUCTIONLINE_ID <> Cur_ProductionLine.M_PRODUCTIONLINE_ID ) T LEFT JOIN M_PRODUCTIONLINE ON T.M_PRODUCTIONLINE_ID = M_PRODUCTIONLINE.M_PRODUCTIONLINE_ID AND CALCULATED = 'Y';
+                        AND (M_PRODUCTIONLINE_ID <> Cur_ProductionLine.M_PRODUCTIONLINE_ID OR M_PRODUCTIONLINE_ID IS NULL)) T LEFT JOIN M_PRODUCTIONLINE ON T.M_PRODUCTIONLINE_ID = M_PRODUCTIONLINE.M_PRODUCTIONLINE_ID AND CALCULATED = 'Y';
 
                 --Insert new calculated cost
                 Ad_Sequence_Next('M_Costing', Cur_ProductionLine.AD_ORG_ID, v_NextNo);

MA_PRODUCTION_COST2.diff [^] (2,238 bytes) 2014-03-08 04:43 [Show Content] [Hide Content]

--- /opt/OpenbravoERP-2.50MP51/src-db/database/model/functions/MA_PRODUCTION_COST.xml
+++ /home/cheli/mercurial250/OpenbravoERP-2.50MP51/src-db/database/model/functions/MA_PRODUCTION_COST.xml
@@ -438,14 +438,14 @@
                       FROM M_TRANSACTION
                       WHERE M_PRODUCT_ID = Cur_ProductionLine.M_PRODUCT_ID
                         AND MOVEMENTDATE < v_ProductionDate
-                        AND (M_PRODUCTIONLINE_ID <> Cur_ProductionLine.M_PRODUCTIONLINE_ID OR M_PRODUCTIONLINE_ID IS NULL)
-                      UNION ALL
+                        AND M_PRODUCTIONLINE_ID <> Cur_ProductionLine.M_PRODUCTIONLINE_ID
+                      UNION
                       SELECT MT.M_PRODUCTIONLINE_ID, MT.MOVEMENTQTY
                       FROM M_TRANSACTION MT, M_PRODUCTIONLINE MP
                       WHERE MT.M_PRODUCT_ID = Cur_ProductionLine.M_PRODUCT_ID
                         AND MT.MOVEMENTDATE = v_ProductionDate
                         AND MT.M_PRODUCTIONLINE_ID = MP.M_PRODUCTIONLINE_ID
-                        AND (MT.M_PRODUCTIONLINE_ID <> Cur_ProductionLine.M_PRODUCTIONLINE_ID OR MT.M_PRODUCTIONLINE_ID IS NULL)
+                        AND MT.M_PRODUCTIONLINE_ID <> Cur_ProductionLine.M_PRODUCTIONLINE_ID
                         AND MP.CALCULATED = 'Y') T ;
                 --LEFT JOIN M_PRODUCTIONLINE ON T.M_PRODUCTIONLINE_ID = M_PRODUCTIONLINE.M_PRODUCTIONLINE_ID
                 --AND CALCULATED = 'Y';
@@ -478,7 +478,7 @@
                       FROM M_TRANSACTION
                       WHERE M_PRODUCT_ID = Cur_ProductionLine.M_PRODUCT_ID
                         AND MOVEMENTDATE <= v_ProductionDate
-                        AND (M_PRODUCTIONLINE_ID <> Cur_ProductionLine.M_PRODUCTIONLINE_ID OR M_PRODUCTIONLINE_ID IS NULL)) T LEFT JOIN M_PRODUCTIONLINE ON T.M_PRODUCTIONLINE_ID = M_PRODUCTIONLINE.M_PRODUCTIONLINE_ID AND CALCULATED = 'Y';
+                        AND M_PRODUCTIONLINE_ID <> Cur_ProductionLine.M_PRODUCTIONLINE_ID ) T LEFT JOIN M_PRODUCTIONLINE ON T.M_PRODUCTIONLINE_ID = M_PRODUCTIONLINE.M_PRODUCTIONLINE_ID AND CALCULATED = 'Y';
 
                 --Insert new calculated cost
                 Ad_Sequence_Next('M_Costing', Cur_ProductionLine.AD_ORG_ID, v_NextNo);

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0064966) chelipf (reporter) 2014-03-08 04:45	The new patch fixes the problem when there are two or more entries in the m_transaction table with the same values.

(0065275) chelipf (reporter) 2014-03-18 18:18	What were I thinking about? the right patch is the reverse one of MA_PRODUCTION_COST2.diff.

Issue History
Date Modified	Username	Field	Change
2014-02-12 23:34	chelipf	New Issue
2014-02-12 23:34	chelipf	Assigned To	=> dmiguelez
2014-02-12 23:34	chelipf	File Added: MA_PRODUCTION_COST.diff
2014-02-12 23:34	chelipf	Web browser	=> Mozilla Firefox
2014-02-12 23:34	chelipf	Modules	=> Core
2014-02-12 23:34	chelipf	Triggers an Emergency Pack	=> No
2014-02-12 23:35	chelipf	Tag Attached: Sidesoft
2014-03-08 04:43	chelipf	File Added: MA_PRODUCTION_COST2.diff
2014-03-08 04:45	chelipf	Note Added: 0064966
2014-03-18 18:18	chelipf	Note Added: 0065275