Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0025569

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

always

2014-01-27 18:46

2014-01-31 13:49

Reporter

jecharri

View Status

public

Assigned To

malsasua

Priority

immediate

Resolution

fixed

Fixed in Version

RMP31

Status

closed

Fix in branch

pi

Fixed in SCM revision

Projection

none

ETA

none

Target Version

RMP31

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

RMP30.1

SCM revision

Merge Request Status

Review Assigned To

guilleaer

OBNetwork customer

OBPS

Support ticket

26119

Regression level

Production - Confirmed Stable

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Yes

Summary

0025569: Impossible to do a cash up

Description

Impossible to do a cash up

Steps To Reproduce

-Log in in https://livebuilds.openbravo.com/retail_pi_pgsql [^]

-Go to "Pos terminal type" window and choose "VBS POS Terminal Type"
-Go to payment method tab and uncheck in all methods the checkbox "Automated movement to other account"

-Go to Web POS and verify that it is impossible to do a cash up. You will see that the system never move the quantity to cash up financial account.

Proposed Solution

It seems that we should change the following lines
if (model.get('paymentMethod').automatemovementtoother === false) {
model.set('qtyToKeep', null);

in file modules/org.openbravo.retail.posterminal/web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js

We may set to 0 instead of null

Tags

No tags attached.

issue25569.diff [^] (1,887 bytes) 2014-01-29 13:42 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js b/web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js
--- a/web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js
+++ b/web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js
@@ -121,7 +121,7 @@
     var result = null;
     _.each(this.get('paymentList').models, function (model) {
       if (model.get('paymentMethod').automatemovementtoother === false) {
-        model.set('qtyToKeep', null);
+        model.set('qtyToKeep', '0');
         if (result !== false) {
           result = true;
         }
@@ -239,7 +239,8 @@
         }
       }, 0),
       totalQtyToDepo: _.reduce(this.get('paymentList').models, function (total, model) {
-        if (model.get('qtyToKeep') !== null && model.get('qtyToKeep') !== undf) {
+        if (model.get('qtyToKeep') !== null && model.get('qtyToKeep') !== undf && 
+            model.get('foreignCounted') !== null && model.get('foreignCounted') !== undf) {
           return OB.DEC.add(total, OB.DEC.mul(OB.DEC.sub(model.get('foreignCounted'), model.get('qtyToKeep')), model.get('rate')));
         } else {
           return total;
diff --git a/web/org.openbravo.retail.posterminal/js/closecash/view/tabcashtokeep.js b/web/org.openbravo.retail.posterminal/js/closecash/view/tabcashtokeep.js
--- a/web/org.openbravo.retail.posterminal/js/closecash/view/tabcashtokeep.js
+++ b/web/org.openbravo.retail.posterminal/js/closecash/view/tabcashtokeep.js
@@ -181,6 +181,9 @@
           },
           renderBody: function (modelToDraw) {
             var paymentMethod = modelToDraw.get('paymentMethod');
+            if (!paymentMethod.automatemovementtoother){
+              return true;
+            }
             this.disableControls();
             //draw
             this.renderFixedAmount(modelToDraw);

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

RR14Q2.1

closed

Cash up is not working fine if you have a payment method with checkbox automated movement unchecked

Notes
(0063828) malsasua (viewer) 2014-01-31 13:46	fixed by commits: https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4cf8ba2457c5 [^] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a12cdbd42c37 [^]

(0063829) guilleaer (viewer) 2014-01-31 13:49	Verified and ready to be included in RMP31

Issue History
Date Modified	Username	Field	Change
2014-01-27 18:46	jecharri	New Issue
2014-01-27 18:46	jecharri	Assigned To	=> marvintm
2014-01-27 18:46	jecharri	OBNetwork customer	=> Yes
2014-01-27 18:46	jecharri	Support ticket	=> 26119
2014-01-27 18:46	jecharri	Resolution time	=> 1391295600
2014-01-27 18:46	jecharri	Triggers an Emergency Pack	=> No
2014-01-27 18:47	jecharri	Regression level	=> Production - Confirmed Stable
2014-01-27 18:47	jecharri	Triggers an Emergency Pack	No => Yes
2014-01-28 18:21	malsasua	File Added: issue25569.diff
2014-01-29 13:42	malsasua	File Deleted: issue25569.diff
2014-01-29 13:42	malsasua	File Added: issue25569.diff
2014-01-31 10:17	mtaal	Assigned To	marvintm => malsasua
2014-01-31 13:46	malsasua	Status	new => scheduled
2014-01-31 13:46	malsasua	fix_in_branch	=> pi
2014-01-31 13:46	malsasua	Note Added: 0063828
2014-01-31 13:46	malsasua	Status	scheduled => resolved
2014-01-31 13:46	malsasua	Fixed in Version	=> RMP31
2014-01-31 13:46	malsasua	Resolution	open => fixed
2014-01-31 13:49	guilleaer	Review Assigned To	=> guilleaer
2014-01-31 13:49	guilleaer	Note Added: 0063829
2014-01-31 13:49	guilleaer	Status	resolved => closed
2014-05-08 19:25	dmitry_mezentsev	Relationship added	related to 0026469

Copyright © 2000 - 2009 MantisBT Group