Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0025455
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminoralways2014-01-09 18:552014-02-12 18:29
ReportercaristuView Statuspublic 
Assigned Toshankarb 
PriorityhighResolutionfixedFixed in Version3.0PR14Q2
StatusclosedFix in branchpiFixed in SCM revision7b6a2eecd1fa
ProjectionnoneETAnoneTarget Version3.0PR14Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket25455
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0025455: Problem when setting an email template as default

DescriptionThe behavior for selecting the default email template is not working fine. Is not filtering by template definition
Steps To Reproduce1) Go to the [Document Type] window and look for an already created document, for example AR Invoice
2) Navigate to the [Email Definitions tab]
3) Un-check the default checkbox for the already existing record
4) Try to check it again. The following error message appears: "There is more than one record set as default."
Proposed SolutionThe callout SL_IsDefault is not retrieving the parent record properly. It is using String parentColumn = vars.getStringParameter("inpParentKeyColumnId"); but that parameter doesn't exists

Thus, the the query to check if other default values exists is not generated properly.

Use KernelUtils.getInstance().getParentRecord() to retrieve the parent record.

Note: this callout is also used in the Module window

TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0063365)
hgbot (developer)
2014-01-13 07:08

 Repository: erp/devel/pi
Changeset: f49878862cba0675e9f26dba390455d4320179fc
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Mon Jan 13 11:36:10 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/f49878862cba0675e9f26dba390455d4320179fc [^]

Fixes Issue 0025455: Problem when setting an email template as default

The parent key column is computed based on tableId instead of runtime parameters as it is null in few cases.

---
M src/org/openbravo/erpCommon/ad_callouts/SL_IsDefault.java
---
(0063493)
hudsonbot (viewer)
2014-01-17 15:49

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9669102eb541 [^]
Maturity status: Test
(0063537)
AugustoMauch (administrator)
2014-01-20 14:09

 Reopened because the fix is not proper. Several columns of a table can have the linktoparentcolumn property set to true. This code is getting and arbitrary column that has the linktoparentcolumn, but it might not be the proper one

OBCriteria<Column> columnCriteria = OBDal.getInstance().createCriteria(Column.class);
columnCriteria.add(Restrictions.eq(Column.PROPERTY_TABLE, currentTable));
columnCriteria.add(Restrictions.eq(Column.PROPERTY_LINKTOPARENTCOLUMN, true));
for (Column column : columnCriteria.list()) {
  parentColumn = column.getDBColumnName();
}

An alternate way of getting the parent column should only be used if the inpParentKeyColumn parameter is null.
(0063563)
hgbot (developer)
2014-01-21 10:35

 Repository: erp/devel/pi
Changeset: 8b00b87d54e27f263cb24e5a5926ca7446886e74
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Tue Jan 21 15:05:08 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/8b00b87d54e27f263cb24e5a5926ca7446886e74 [^]

Backout Issue 0025455: Problem when setting an email template as default

The fix has been backed out as it does not handle cases where multiple columns are set as linkToParentColumn.

---
M src/org/openbravo/erpCommon/ad_callouts/SL_IsDefault.java
---
(0063740)
hgbot (developer)
2014-01-28 10:32

 Repository: erp/devel/pi
Changeset: 7b6a2eecd1fa0a73da98b46c597027d4a1e0bdcd
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Wed Jan 22 15:14:29 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/7b6a2eecd1fa0a73da98b46c597027d4a1e0bdcd [^]

Fixes Issue 0025455: Problem when setting an email template as default

Added new method getParentColumnName in kernel utils.
Modified the logic in getParentRecord, the issue was parentTab.getEntity() always returns ADTab and not the actual entity.
Modified logic in SL_IsDefault callout to handle cases where parentColumn is not provided in parameters.

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelUtils.java
M src/org/openbravo/erpCommon/ad_callouts/SL_IsDefault.java
---
(0063752)
AugustoMauch (administrator)
2014-01-28 13:08

 Code reviewed and verified in pi@7b6a2eecd1fa
(0064097)
hudsonbot (viewer)
2014-02-12 18:29

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d1a5bb862230 [^]
Maturity status: Test
(0064124)
hudsonbot (viewer)
2014-02-12 18:29

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d1a5bb862230 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2014-01-09 18:55 caristu New Issue
2014-01-09 18:55 caristu Assigned To => caristu
2014-01-09 18:55 caristu Modules => Core
2014-01-09 18:55 caristu OBNetwork customer => Yes
2014-01-09 18:55 caristu Support ticket => 25455
2014-01-09 18:55 caristu Resolution time => 1394060400
2014-01-09 18:55 caristu Triggers an Emergency Pack => No
2014-01-09 18:56 caristu Issue Monitored: networkb
2014-01-09 19:19 caristu Assigned To caristu => AugustoMauch
2014-01-09 19:20 caristu Proposed Solution updated
2014-01-10 08:12 caristu Steps to Reproduce Updated View Revisions
2014-01-12 11:04 shankarb Issue Monitored: AugustoMauch
2014-01-13 07:06 shankarb Assigned To AugustoMauch => shankarb
2014-01-13 07:06 shankarb Review Assigned To => AugustoMauch
2014-01-13 07:08 hgbot Checkin
2014-01-13 07:08 hgbot Note Added: 0063365
2014-01-13 07:08 hgbot Status new => resolved
2014-01-13 07:08 hgbot Resolution open => fixed
2014-01-13 07:08 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f49878862cba0675e9f26dba390455d4320179fc [^]
2014-01-17 15:49 hudsonbot Checkin
2014-01-17 15:49 hudsonbot Note Added: 0063493
2014-01-20 14:09 AugustoMauch Note Added: 0063537
2014-01-20 14:09 AugustoMauch Status resolved => new
2014-01-20 14:09 AugustoMauch Resolution fixed => open
2014-01-21 10:35 hgbot Checkin
2014-01-21 10:35 hgbot Note Added: 0063563
2014-01-27 07:20 shankarb Status new => scheduled
2014-01-27 07:20 shankarb fix_in_branch => pi
2014-01-28 10:32 hgbot Checkin
2014-01-28 10:32 hgbot Note Added: 0063740
2014-01-28 10:32 hgbot Status scheduled => resolved
2014-01-28 10:32 hgbot Resolution open => fixed
2014-01-28 10:32 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/f49878862cba0675e9f26dba390455d4320179fc [^] => http://code.openbravo.com/erp/devel/pi/rev/7b6a2eecd1fa0a73da98b46c597027d4a1e0bdcd [^]
2014-01-28 13:08 AugustoMauch Note Added: 0063752
2014-01-28 13:08 AugustoMauch Status resolved => closed
2014-01-28 13:08 AugustoMauch Fixed in Version => 3.0MP32
2014-02-12 18:29 hudsonbot Checkin
2014-02-12 18:29 hudsonbot Note Added: 0064097
2014-02-12 18:29 hudsonbot Checkin
2014-02-12 18:29 hudsonbot Note Added: 0064124

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker