0024934: Columns with reference Time are not displayed/stored properly

Description

Define a field in postgresql of type 'timestamp without time zone' and in Openbravo define the reference of the column as 'Time'

In a window, if for example in the database the value is "2013-10-11 18:00:05" the value displayed in Openbravo is "22:00:05" but if we edit the record and change the value for example to "22:00:10", save, and reload then the value displayed is now "2:00:10" and in the database "2013-10-11 22:00:10"

This behaviour makes columns of time "Time" completely unusable.

Steps To Reproduce

In description.

Proposed Solution

It seems that the problem is related to a bad management of time zones.

IMHO If value in database is "2013-10-11 18:00:05" it should display "18:00:05" In Openbravo and the other way the value edited in Openbravo is "18:00:05" it should store in the database "2013-10-11 18:00:05" (the date part is not important).

Tags

No tags attached.

Attached Files

solve_time.diff [^] (1,663 bytes) 2013-10-24 11:32 [Show Content] [Hide Content]

diff --git a/modules/org.openbravo.service.json/src/org/openbravo/service/json/DataToJsonConverter.java b/modules/org.openbravo.service.json/src/org/openbravo/service/json/DataToJsonConverter.java
--- a/modules/org.openbravo.service.json/src/org/openbravo/service/json/DataToJsonConverter.java
+++ b/modules/org.openbravo.service.json/src/org/openbravo/service/json/DataToJsonConverter.java
@@ -66,8 +66,8 @@
   private final SimpleDateFormat xmlDateFormat = JsonUtils.createDateFormat();
   private final SimpleDateFormat xmlDateTimeFormat = JsonUtils.createDateTimeFormat();
   // private final static SimpleDateFormat xmlTimeFormat = JsonUtils.createTimeFormat();
-  private final static SimpleDateFormat xmlTimeFormatWithoutMTOffset = JsonUtils
-      .createTimeFormatWithoutGMTOffset();
+  // private final static SimpleDateFormat xmlTimeFormatWithoutMTOffset = JsonUtils
+  // .createTimeFormatWithoutGMTOffset();
 
   // additional properties to return as a flat list
   private List<String> additionalProperties = new ArrayList<String>();
@@ -313,7 +313,9 @@
         Timestamp localTime = (Timestamp) value;
         Date UTCTime = convertToUTC(localTime);
 
-        return xmlTimeFormatWithoutMTOffset.format(UTCTime.getTime());
+        // Smartclient expects a datetime because we set this property in the client:
+        // isc.DataSource.serializeTimeAsDatetime = true;
+        return xmlDateTimeFormat.format(UTCTime);
       } else if (property.isDatetime() || Timestamp.class.isAssignableFrom(clz)) {
         final String formattedValue = xmlDateTimeFormat.format(value);
         return JsonUtils.convertToCorrectXSDFormat(formattedValue);

Relationships [ Relation Graph ] [ Dependency Graph ]

duplicate of	defect	0025274		closed	AugustoMauch	The time fields are not working properly
related to	defect	0020684		closed	AugustoMauch	Incorrect time in process request with different timezones in client/server

Notes
(0061883) mtaal (manager) 2013-10-24 11:31	The attached diff will solve the reported issue. There is another requirement to store absolute times (so the user enters 10:00 am, the database also shows 10:00 am). This is a separate topic for which a separate solution is planned to be done.

(0061966) ioritzCia (developer) 2013-10-30 10:52	There is an End Client suffering this issue and therefore, it becomes an obps issue.

Issue History
Date Modified	Username	Field	Change
2013-10-11 17:13	adrianromero	New Issue
2013-10-11 17:13	adrianromero	Assigned To	=> AugustoMauch
2013-10-11 17:13	adrianromero	Modules	=> Core
2013-10-11 17:13	adrianromero	Triggers an Emergency Pack	=> No
2013-10-11 17:17	adrianromero	Description Updated	View Revisions
2013-10-11 17:17	adrianromero	Steps to Reproduce Updated	View Revisions
2013-10-11 17:17	adrianromero	Proposed Solution updated
2013-10-24 11:30	mtaal	Relationship added	related to 0020684
2013-10-24 11:31	mtaal	Note Added: 0061883
2013-10-24 11:32	mtaal	File Added: solve_time.diff
2013-10-30 10:52	ioritzCia	Note Added: 0061966
2013-11-15 10:00	xabiermerino	version	=> 3.0MP28.2
2013-11-15 10:00	xabiermerino	Target Version	=> 3.0MP31
2013-12-17 10:46	alostale	Relationship added	duplicate of 0025274
2013-12-17 10:46	alostale	Status	new => closed
2013-12-17 10:46	alostale	Resolution	open => duplicate