Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0024687
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Openbravo ERP] A. Platformminoralways2013-09-04 10:392013-11-19 19:07
ReporteralostaleView Statuspublic 
Assigned Todbaz 
PrioritynormalResolutionfixedFixed in Version3.0MP30
StatusclosedFix in branchFixed in SCM revisioncd5e1a38c069
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toalostale
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0024687: Double DataSource request when there using a saved view

DescriptionWhenever a window's default view is a saved view, double request to DataSource is performed when the window is opened.
Steps To ReproduceIn a professional instance:

 -Open Sales Invoice window
 -Sort by Order Date column
 -Move Order Date column to the first position in grid
 -Remove all the columns in grid but Order Date and Document No.
 -Add "10000" (without the quotes) as the filter of the Document No. column
 -Save current view
 -Set saved view as default
 -Reopen Sales Invoice window
   -> Notice how 2 requests are done to Invoice DataSource
   -> Notice how the grid is opened in standard view and after that redrawn with saved view
Proposed SolutionThe problem, similarly to described in issue 0024684, comes because initially standard view is opened and after that saved view is applied.

Unlike grid configuration, saved views are not stored locally in client, they are requested to backed and applied in the callback.

The solution might be to store locally if not the whole set of saved views which could be huge, at least which are the windows that have one applied by default. For these ones, don't do any request until saved view request callback.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0024684 closedalostale Double DataSource request when there is grid configuration 
related to defect 00256363.0PR14Q2 closedalostale Saved view filter reapplied after adding a column in grid 
causes defect 00282423.0PR15Q1 closedAugustoMauch First request to load the window data is not done under some circumnstances 

-  Notes
(0062048)
dbaz (developer)
2013-11-07 13:08

 The fix of this issue should ensure that doesn't break these two:

https://issues.openbravo.com/view.php?id=22730 [^]
https://issues.openbravo.com/view.php?id=23333 [^]
(0062049)
dbaz (developer)
2013-11-07 13:17

 Actually, the default saved views for the current user/role/org/client are stored in the preferences 'OBUIAPP_DefaultSavedView_xx'

This preference has two lacks that need to be fixed:
a) If a view is deleted, and it is the default one for the current logged user/role/org/client, the preference should be removed from the browser to avoid problems if the user closes and opens the window again
b) If a view is deleted, it should also be deleted all the preferences using this view (for any user/role/org/client).
(0062051)
hgbot (developer)
2013-11-07 13:23

 Repository: erp/devel/pi
Changeset: cd5e1a38c069995d64d183c4e4e6d41259f5bed9
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Thu Nov 07 13:23:04 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/cd5e1a38c069995d64d183c4e4e6d41259f5bed9 [^]

Fixed issue 24687: Removed double DataSource request in grid
when there is using a default saved view

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/personalization/PersonalizationActionHandler.java
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-manage-views.js
---
(0062132)
alostale (manager)
2013-11-15 07:48

 Code reviewed and tested
(0062243)
hudsonbot (developer)
2013-11-19 19:07

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ab71e0273dc1 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2013-09-04 10:39 alostale New Issue
2013-09-04 10:39 alostale Assigned To => AugustoMauch
2013-09-04 10:39 alostale Modules => Core
2013-09-04 10:39 alostale Triggers an Emergency Pack => No
2013-09-04 10:39 alostale Relationship added related to 0024684
2013-11-07 13:06 dbaz Assigned To AugustoMauch => dbaz
2013-11-07 13:07 dbaz Steps to Reproduce Updated View Revisions
2013-11-07 13:08 dbaz Note Added: 0062048
2013-11-07 13:17 dbaz Note Added: 0062049
2013-11-07 13:18 dbaz Review Assigned To => alostale
2013-11-07 13:18 dbaz Issue Monitored: alostale
2013-11-07 13:23 hgbot Checkin
2013-11-07 13:23 hgbot Note Added: 0062051
2013-11-07 13:23 hgbot Status new => resolved
2013-11-07 13:23 hgbot Resolution open => fixed
2013-11-07 13:23 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/cd5e1a38c069995d64d183c4e4e6d41259f5bed9 [^]
2013-11-15 07:48 alostale Note Added: 0062132
2013-11-15 07:48 alostale Status resolved => closed
2013-11-15 07:48 alostale Fixed in Version => 3.0MP30
2013-11-19 19:07 hudsonbot Checkin
2013-11-19 19:07 hudsonbot Note Added: 0062243
2014-02-04 15:26 alostale Relationship added related to 0025636
2014-11-21 13:54 AugustoMauch Relationship added causes 0028242

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker