Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0024507
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] A. Platformminorhave not tried2013-08-07 15:582013-08-16 20:32
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in Version3.0MP27
StatusclosedFix in branchFixed in SCM revision1fb4fef1d70b
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0024507: Add debugging code to OBDal flush() method to help debugging performance+memory usage problems

DescriptionSometimes calls to flush() are very slow and the time spent is not directly related to the needed dml calls in the database but rather spent on just iterating over all the entities in the hibernate session just to find out which objects in there have been modified.

To help debugging those problems 4 infos are useful
- time spent in flush, who called flush
- numbers of entities/collections in the hibernate session
- list of entities in the hibernate session.
Steps To ReproduceAdd the proposed items to the flush() method.
They should not do anything by default, but provide that info the log4j debug level logging is enabled for the OBDal class.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0060540)
hgbot (developer)
2013-08-07 18:56

 Repository: erp/devel/pi
Changeset: 1fb4fef1d70b3c004d63887bc4f1dbeaaab7e98e
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Wed Aug 07 18:55:26 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1fb4fef1d70b3c004d63887bc4f1dbeaaab7e98e [^]

Fixed 24507: Add performance debugging cdoe to OBDal.flush().

Now with debug level logging for the OBDal class active every flush
call will log following extra into:
- stacktrace of caller of flush
- time taken in flush
- number of entities + collections in hibernate session
- list of all entries in hibernate session

This info allows to debug slow flush calls by analyzing the list of entities
loaded into that hibernate session

---
M src/org/openbravo/dal/service/OBDal.java
---
(0060546)
alostale (viewer)
2013-08-08 15:28

 code reviewed + tested
(0060637)
hudsonbot (viewer)
2013-08-16 20:32

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/59a1180e7f4f [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2013-08-07 15:58 shuehner New Issue
2013-08-07 15:58 shuehner Assigned To => shuehner
2013-08-07 15:58 shuehner Modules => Core
2013-08-07 15:58 shuehner OBNetwork customer => No
2013-08-07 15:58 shuehner Triggers an Emergency Pack => No
2013-08-07 15:59 shuehner Review Assigned To => alostale
2013-08-07 18:56 hgbot Checkin
2013-08-07 18:56 hgbot Note Added: 0060540
2013-08-07 18:56 hgbot Status new => resolved
2013-08-07 18:56 hgbot Resolution open => fixed
2013-08-07 18:56 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1fb4fef1d70b3c004d63887bc4f1dbeaaab7e98e [^]
2013-08-08 15:28 alostale Note Added: 0060546
2013-08-08 15:28 alostale Status resolved => closed
2013-08-08 15:28 alostale Fixed in Version => 3.0MP27
2013-08-16 20:32 hudsonbot Checkin
2013-08-16 20:32 hudsonbot Note Added: 0060637

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker