Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0023068
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajoralways2013-02-13 12:312013-03-06 19:42
ReportercaristuView Statuspublic 
Assigned ToAugustoMauch 
PriorityimmediateResolutionfixedFixed in Version3.0MP21
StatusclosedFix in branchFixed in SCM revision57378b7ff2bd
ProjectionnoneETAnoneTarget Version3.0MP21
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Merge Request Status
Review Assigned Toshankarb
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket19331
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0023068: Sorting by computed column is lost after saving a record with errors

DescriptionWhen we have a window sorted by a computed column, and we save a record in grid view with errors, and after that we correct it, the sorting is lost. If we scroll down the records are not sorted.
Steps To Reproduce1) Create the computed column defined here http://wiki.openbravo.com/wiki/How_to_create_a_Computed_Column [^] in the sales order window
2) Sort the window using that computed column
3) Edit a record in grid view and save it with an error
4) Correct it and save. Check that the sort icon has disappeared from the computed column and if you scroll down the window is not sorted anymore.

Note: in some environments step 4) is not necessary
TagsNo tags attached.
Attached Filesdiff file icon issue23068.diff [^] (2,595 bytes) 2013-02-15 12:06 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0023154 closedAugustoMauch Read only logic not working as expected. 
related to defect 00232203.0MP21 closedAugustoMauch When calculating the display logic null values are not converted to '' 

-  Notes
(0056488)
hgbot (developer)
2013-02-15 12:08

 Repository: erp/devel/pi
Changeset: 57378b7ff2bd78d52d69b051cd7683e540e47f87
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Feb 15 12:04:59 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/57378b7ff2bd78d52d69b051cd7683e540e47f87 [^]

Fixes issue 23068: Sorting is not reset after saving a record with errors

This problem was caused because the value of the computed column changed from null to an empty string. This caused the sorting of the grid to be cleared, due to [1]. The change from null to an empty string is done in the fixNull250 function. This functions is needed for evaluating properly the display logic of the field, but it should not be called using the record itself, but with a clone of the record, so that the record itself is not changed.


[1] https://code.openbravo.com/erp/mods/org.openbravo.userinterface.smartclient.dev/file/8c2bc26694da/web/org.openbravo.userinterface.smartclient/isomorphic/client/widgets/ListGrid.js#l28665 [^]

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-action-button.js
---
(0056608)
hudsonbot (viewer)
2013-02-20 04:50

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d828167a9e83 [^]

Maturity status: Test
(0056664)
shankarb (viewer)
2013-02-21 08:03

 Code reviewed and tested in pi changeset 9f692840db92
(0056741)
hgbot (developer)
2013-02-25 11:08

 Repository: erp/devel/pi
Changeset: 51672575b04f50fb9798ac3dc7a01397d40f7d26
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Feb 25 11:05:03 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/51672575b04f50fb9798ac3dc7a01397d40f7d26 [^]

Fixes issue 23154: Read only logic is working as expected.

In the fix of issue 23068 a change was made so that the current values of the form were not changed to '' if they were originally null. The problem is that the read only logic depended on this to work. This has been fixed by fixing the values inside the onFieldChanged function, the same way it was fixed for the display logc in the issue 23068.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/templates/ob-view-form.js.ftl
---
(0056850)
hudsonbot (viewer)
2013-02-28 16:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8c5cb16254f4 [^]

Maturity status: Test
(0057033)
hgbot (developer)
2013-03-05 10:25

 Repository: erp/devel/pi
Changeset: 9fa4494e366cb04c8fcee0c6e31ba2186cd0bb6c
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Mar 05 10:24:55 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/9fa4494e366cb04c8fcee0c6e31ba2186cd0bb6c [^]

Fixes issue 23220: Display logic works as expected

In the fix of issue 23068 a change was done to prevent all properties of the form being changed from null to ''. This change had to be done on a clone of the record, not on the record itself.

The problem is that at one point the record itself was being used, being taken for granted that its null values would be replaced with an empty string. This has been fixed by replacing the record by the clone that already has had its null values replaced by ''.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-action-button.js
---
(0057110)
hudsonbot (viewer)
2013-03-06 19:42

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/95e36a1b246f [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2013-02-13 12:31 caristu New Issue
2013-02-13 12:31 caristu Assigned To => AugustoMauch
2013-02-13 12:31 caristu Modules => Core
2013-02-13 12:31 caristu OBNetwork customer => Yes
2013-02-13 12:31 caristu Support ticket => 19331
2013-02-13 12:31 caristu Triggers an Emergency Pack => No
2013-02-13 12:31 caristu Issue Monitored: networkb
2013-02-13 12:33 caristu version => pi
2013-02-13 12:39 caristu Description Updated View Revisions
2013-02-14 14:26 AugustoMauch Steps to Reproduce Updated View Revisions
2013-02-15 11:56 AugustoMauch Issue Monitored: shankarb
2013-02-15 11:56 AugustoMauch Review Assigned To => shankarb
2013-02-15 12:06 AugustoMauch File Added: issue23068.diff
2013-02-15 12:08 hgbot Checkin
2013-02-15 12:08 hgbot Note Added: 0056488
2013-02-15 12:08 hgbot Status new => resolved
2013-02-15 12:08 hgbot Resolution open => fixed
2013-02-15 12:08 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/57378b7ff2bd78d52d69b051cd7683e540e47f87 [^]
2013-02-20 04:50 hudsonbot Checkin
2013-02-20 04:50 hudsonbot Note Added: 0056608
2013-02-21 08:03 shankarb Note Added: 0056664
2013-02-21 08:03 shankarb Status resolved => closed
2013-02-21 08:03 shankarb Fixed in Version => 3.0MP21
2013-02-25 10:55 AugustoMauch Relationship added related to 0023154
2013-02-25 11:08 hgbot Checkin
2013-02-25 11:08 hgbot Note Added: 0056741
2013-02-28 16:39 hudsonbot Checkin
2013-02-28 16:39 hudsonbot Note Added: 0056850
2013-03-05 10:22 AugustoMauch Relationship added related to 0023220
2013-03-05 10:25 hgbot Checkin
2013-03-05 10:25 hgbot Note Added: 0057033
2013-03-06 19:42 hudsonbot Checkin
2013-03-06 19:42 hudsonbot Note Added: 0057110

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker