0022994: error to post a transaction with a determined conversion rate

Description

. if you have a conversion rate very low (ex: 0.01399) and the amount of transaction is low (ex: 0.06) , when you try post this transaction, error is returned

Steps To Reproduce

. in F&B
. go to currency window - USD
. conversion rate -> to EUR (from 01-07-2013 to 30-09-2013)
          change "Divide Rate By" to 0.01399
. go to currency window - EUR
. conversion rate -> to USD (from 01-07-2013 to 30-09-2013)
          change "Multiple Rate By" to 0.01399

. go to financial account: usd- bank account 1
. go to payment method: transferencia
  . select: receive payments in multiple currencies

. go to pricelist "tarifa de ventas"
. change org: *

. go to product "cerveza ale 0.5"
. change org: *

. create new sales order
. org: F&B US, Inc.
. order date: 06-07-2013
. bp: moon light
. price list: tarifa de venta
. invoice terms inmediate
. new line:
  . product: cerveza ale 0.5
  . qty: 1
  . net unit price , net list price: 1,541,827.00
  . tax: exento

. create new sales invoice
. org: F&B US, Inc.
. order date: 06-07-2013
. bp: moon light
. price list: tarifa de venta
. create lines from:
  . select previous sales order
. change the amount in line to 1541827.06
.process
. add payment
  . payment date 06/07/2013
  . process & deposit

payment generated should be similar to attachment1.jpg

. go to financial account - > transaction
  . post
error is returned.
if manual post works, you should post with background process

Proposed Solution

see attach diff

Tags

No tags attached.

Attached Files

attachment1.png [^] (150,346 bytes) 2013-02-06 17:49

parche.diff [^] (751 bytes) 2013-02-06 17:50 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/erpCommon/ad_forms/AcctServer.java b/src/org/openbravo/erpCommon/ad_forms/AcctServer.java
--- a/src/org/openbravo/erpCommon/ad_forms/AcctServer.java
+++ b/src/org/openbravo/erpCommon/ad_forms/AcctServer.java
@@ -2431,8 +2431,14 @@
       } else {
         amtTo = new BigDecimal(getConvertedAmt(_amount.toString(), currencyIDFrom, currencyIDTo,
             conversionDate, "", AD_Client_ID, AD_Org_ID, conn));
+        if (amtTo.equals(BigDecimal.ZERO)){
+        	// TODO 
+        }
+        else
+        {
         amtFromSourcecurrency = amtFrom.multiply(_amount).divide(amtTo, conversionRatePrecision,
             BigDecimal.ROUND_HALF_EVEN);
+        }
       }
     }
     amtDiff = (amtTo).subtract(amtFrom);

Relationships [ Relation Graph ] [ Dependency Graph ]

duplicate of

design defect

0023544

new

dmiguelez

It is possible to create a Transaction for 0.00 amount

Notes
(0057882) dmiguelez (developer) 2013-04-15 10:38	It is a design defect. Properly explained in Issue 23544

Issue History
Date Modified	Username	Field	Change
2013-02-06 17:49	malsasua	New Issue
2013-02-06 17:49	malsasua	Assigned To	=> dmiguelez
2013-02-06 17:49	malsasua	File Added: attachment1.png
2013-02-06 17:49	malsasua	Web browser	=> Google Chrome
2013-02-06 17:49	malsasua	Modules	=> Core
2013-02-06 17:49	malsasua	Triggers an Emergency Pack	=> No
2013-02-06 17:50	malsasua	File Added: parche.diff
2013-04-08 09:46	pramakrishnan	Assigned To	dmiguelez => pramakrishnan
2013-04-08 09:46	pramakrishnan	Status	new => scheduled
2013-04-08 09:46	pramakrishnan	fix_in_branch	=> pi
2013-04-15 10:37	dmiguelez	Relationship added	related to 0023544
2013-04-15 10:38	dmiguelez	Relationship replaced	duplicate of 0023544
2013-04-15 10:38	dmiguelez	Note Added: 0057882
2013-04-15 10:38	dmiguelez	Status	scheduled => closed
2013-04-15 10:38	dmiguelez	Resolution	open => duplicate