Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0022805
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Openbravo ERP] 07. Sales managementminorN/A2013-01-16 11:532013-01-21 12:57
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision38af5fb36bd9
ProjectionnoneETAnoneTarget Version3.0MP20
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0022805: Price Adjustments don't update prices while editing lines

DescriptionStarting from 3.0MP17, existent Price Adjustments were extended in order to add the capability to create more powerful rules to create discounts. Existent Price Adjustments were converted in a type of Promotions and Discounts.

Because it is possible to create Promotions and Discounts that are applied based not only in one sales/invoice line but also in the rest of lines in the document, it is not possible anymore to calculate the prices with discounts when creating/editing the line. This is way this calculation was removed and executed only on demand or when posting the document.

Though this changes the existent behavior.
Steps To Reproduce1. Go to Promotions and Discounts
2. Create a new entry that applies to product A (with price list 10€)
3. Discount 10%
4. Create a new Sales Order
5. Add a new line of product A, check Net Unit Price and Line Net Amount are 10€
6. Book the Order, now Net Unit Price and Line Net Amount are 9€ (10€-10%)

Previous to MP17, in step 5 both fields would be 9€ instead of 10€
Proposed SolutionIn order to keep backwards compatibility, only for the case of Price Adjustments, final prices will be calculated while the line is being edited.

Note that before MP17, Price Adjustment lines were also created just after inserting/editing the line. This is *NOT* going to be restored, so Price Adjustment lines will be only created on posting.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0055539)
hgbot (developer)
2013-01-16 11:56

 Repository: erp/devel/pi
Changeset: 38af5fb36bd953a6c62dd057a51c5e66f11b3da3
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Jan 16 11:55:20 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/38af5fb36bd953a6c62dd057a51c5e66f11b3da3 [^]

fixed issue 22805: Price Adjustments don't update prices while editing lines

---
M src-db/database/model/functions/M_PROMOTION_CALCULATE.xml
M src/org/openbravo/erpCommon/ad_callouts/SL_Invoice_Amt.java
M src/org/openbravo/erpCommon/ad_callouts/SL_Invoice_Product.java
M src/org/openbravo/erpCommon/ad_callouts/SL_Order_Amt.java
M src/org/openbravo/erpCommon/ad_callouts/SL_Order_Product.java
A src/org/openbravo/erpCommon/businessUtility/PriceAdjustment.java
---
(0055540)
alostale (viewer)
2013-01-16 12:09

 Updated documentation: http://wiki.openbravo.com/wiki/Discounts_and_Promotions [^]
(0055631)
hudsonbot (viewer)
2013-01-18 20:26

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4cd4a6cc38e0 [^]

Maturity status: Test
(0055670)
dmiguelez (viewer)
2013-01-21 12:57

 Code Review + Testing OK

- Issue History
Date Modified Username Field Change
2013-01-16 11:53 alostale New Issue
2013-01-16 11:53 alostale Assigned To => alostale
2013-01-16 11:53 alostale Modules => Core
2013-01-16 11:53 alostale OBNetwork customer => No
2013-01-16 11:53 alostale Triggers an Emergency Pack => No
2013-01-16 11:54 alostale Review Assigned To => dmiguelez
2013-01-16 11:56 hgbot Checkin
2013-01-16 11:56 hgbot Note Added: 0055539
2013-01-16 11:56 hgbot Status new => resolved
2013-01-16 11:56 hgbot Resolution open => fixed
2013-01-16 11:56 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/38af5fb36bd953a6c62dd057a51c5e66f11b3da3 [^]
2013-01-16 12:09 alostale Note Added: 0055540
2013-01-18 20:26 hudsonbot Checkin
2013-01-18 20:26 hudsonbot Note Added: 0055631
2013-01-21 12:57 dmiguelez Note Added: 0055670
2013-01-21 12:57 dmiguelez Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker