0022463: Incremental build fails if client's name is longer than 50 chars

Description

When doing an incremental build having some client with a name longer than 50 chars, following error is displayed:

[java] 102371 ERROR - SQL error in query: INSERT INTO ad_tree( ad_tree_id, ad_client_id, ad_org_id, created, createdby, updated, updatedby, isactive, name, description, treetype, isallnodes) VALUES (?, ?, '0', now(), '0', now(), '0', 'Y', SUBSTR(?, 1, 60), ?, SUBSTR(?, 1, 60), 'Y')Exception:org.postgresql.util.PSQLException: ERROR: duplicate key value violates unique constraint "ad_tree_name"
     [java] 102375 ERROR - Error executing moduleScript org.openbravo.modulescript.UpdateADClientInfo: @CODE=0@ERROR: duplicate key value violates unique constraint "ad_tree_name"
     [java] 102379 ERROR - Error executing moduleScript: org.openbravo.modulescript.UpdateADClientInfo
     [java] Execution of moduleScript org.openbravo.modulescript.UpdateADClientInfofailed.
     [java] at org.openbravo.modulescript.ModuleScriptHandler.execute(ModuleScriptHandler.java:68)
     [java] at org.openbravo.ddlutils.task.AlterDatabaseDataAll.doExecute(AlterDatabaseDataAll.java:173)
     [java] at org.openbravo.ddlutils.task.BaseDatabaseTask.execute(BaseDatabaseTask.java:86)
     [java] at org.openbravo.ddlutils.task.AlterDatabaseJava.main(AlterDatabaseJava.java:38)
     [java] Exception in thread "main" Execution of moduleScript org.openbravo.modulescript.UpdateADClientInfofailed.
     [java] at org.openbravo.ddlutils.task.AlterDatabaseDataAll.doExecute(AlterDatabaseDataAll.java:248)
     [java] at org.openbravo.ddlutils.task.BaseDatabaseTask.execute(BaseDatabaseTask.java:86)
     [java] at org.openbravo.ddlutils.task.AlterDatabaseJava.main(AlterDatabaseJava.java:38)
     [java] Caused by: Execution of moduleScript org.openbravo.modulescript.UpdateADClientInfofailed.
     [java] at org.openbravo.modulescript.ModuleScriptHandler.execute(ModuleScriptHandler.java:68)
     [java] at org.openbravo.ddlutils.task.AlterDatabaseDataAll.doExecute(AlterDatabaseDataAll.java:173)
     [java] ... 2 more

Steps To Reproduce

1. Create a client with more than 50 chars
2. Launch an incremental build

Proposed Solution

The error is caused by a trim that is being made, having tree names like "User Dimension 1" and "User Dimension 2", the trim results in CustomerName+"User Dimen" in both cases, creating a duplicated name.

The best solution is to get rid of the trim and increase field length to a 255 chars long value.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

feature request

0022403

3.0MP18

closed

vmromanos

Add support for Resource Category tree

Notes
(0054728) hgbot (developer) 2012-12-05 17:01	Repository: erp/devel/pi Changeset: ecbf3f2603a82b143ebe0c027a0e04f21cf79f4f Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com> Date: Wed Dec 05 17:00:28 2012 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/ecbf3f2603a82b143ebe0c027a0e04f21cf79f4f [^] Fixes bug 22463 --- M src-db/database/model/tables/AD_TREE.xml M src-util/modulescript/build/classes/org/openbravo/modulescript/UpdateADClientInfoData.class M src-util/modulescript/src/org/openbravo/modulescript/UpdateADClientInfo_data.xsql ---

(0054741) pramakrishnan (viewer) 2012-12-06 09:33	Testing + Code Review - OK.

(0054757) hudsonbot (viewer) 2012-12-06 15:12	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d438f7014f16 [^] Maturity status: Test

Issue History
Date Modified	Username	Field	Change
2012-12-05 13:29	plujan	New Issue
2012-12-05 13:29	plujan	Assigned To	=> dmiguelez
2012-12-05 13:29	plujan	Triggers an Emergency Pack	=> No
2012-12-05 13:29	plujan	Modules	=> Core
2012-12-05 13:29	plujan	OBNetwork customer	=> No
2012-12-05 13:29	plujan	Relationship added	related to 0022403
2012-12-05 13:40	plujan	Assigned To	dmiguelez => eduardo_Argal
2012-12-05 13:40	plujan	Priority	normal => immediate
2012-12-05 17:00	eduardo_Argal	Status	new => scheduled
2012-12-05 17:00	eduardo_Argal	fix_in_branch	=> pi
2012-12-05 17:01	hgbot	Checkin
2012-12-05 17:01	hgbot	Note Added: 0054728
2012-12-05 17:01	hgbot	Status	scheduled => resolved
2012-12-05 17:01	hgbot	Resolution	open => fixed
2012-12-05 17:01	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/ecbf3f2603a82b143ebe0c027a0e04f21cf79f4f [^]
2012-12-06 09:33	pramakrishnan	Review Assigned To	=> pramakrishnan
2012-12-06 09:33	pramakrishnan	Note Added: 0054741
2012-12-06 09:33	pramakrishnan	Status	resolved => closed
2012-12-06 15:12	hudsonbot	Checkin
2012-12-06 15:12	hudsonbot	Note Added: 0054757