0022445: Customer org validation when synchronizing orders is too strict

Description

-Using an organization tree as follows (you can use White Valley data to reproduce it):
*
  A
    A1
    A2
-Create a Customer in organization A
-Using a role with write access to A1 and without write access privilege to A, in WebPOS create a ticket in organization A1 referencing to the Customer in org A
-The sync fails with a DAL error (requiring the Customer to be in "writtable organizations": A1 or *)

Steps To Reproduce

See above

Proposed Solution

If the ticket is created directly in the back-end with the same role, it does not fail (the validation for the customer

Attached work-around skipping org validation when saving the ticket

Tags

No tags attached.

Attached Files

diffBpartnerOrg.diff [^] (565 bytes) 2012-12-02 10:39 [Show Content] [Hide Content]

diff -r 95f425e84126 src/org/openbravo/retail/posterminal/OrderLoader.java
--- a/src/org/openbravo/retail/posterminal/OrderLoader.java	Thu Nov 29 10:13:12 2012 +0100
+++ b/src/org/openbravo/retail/posterminal/OrderLoader.java	Sat Dec 01 15:56:35 2012 +0100
@@ -127,7 +127,7 @@
 
   public JSONObject saveOrder(JSONArray jsonarray) throws JSONException {
     boolean error = false;
-    OBContext.setAdminMode(true);
+    OBContext.setAdminMode(false);
     try {
       for (int i = 0; i < jsonarray.length(); i++) {
         long t1 = System.currentTimeMillis();

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0054724) hgbot (developer) 2012-12-05 11:08	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: bb09005ab60aabaa300780aeda60392aaaf280f7 Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Wed Dec 05 11:07:15 2012 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bb09005ab60aabaa300780aeda60392aaaf280f7 [^] Fixed issue 22445. Business partner will be modified in admin mode without filtering. --- M src/org/openbravo/retail/posterminal/OrderLoader.java ---

(0054773) guilleaer (viewer) 2012-12-07 13:02	tested and verified

Issue History
Date Modified	Username	Field	Change
2012-12-02 10:39	iciordia	New Issue
2012-12-02 10:39	iciordia	Assigned To	=> marvintm
2012-12-02 10:39	iciordia	File Added: diffBpartnerOrg.diff
2012-12-05 11:08	hgbot	Checkin
2012-12-05 11:08	hgbot	Note Added: 0054724
2012-12-05 11:08	hgbot	Status	new => resolved
2012-12-05 11:08	hgbot	Resolution	open => fixed
2012-12-05 11:08	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bb09005ab60aabaa300780aeda60392aaaf280f7 [^]
2012-12-07 13:02	guilleaer	Note Added: 0054773
2012-12-07 13:02	guilleaer	Status	resolved => closed
2012-12-07 13:02	guilleaer	Fixed in Version	=> RMP17