Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0022025 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Openbravo ERP] A. Platform | major | always | 2012-10-22 12:21 | 2012-10-31 13:30 | |||
Reporter | ngarcia | View Status | public | |||||
Assigned To | shankarb | |||||||
Priority | immediate | Resolution | fixed | Fixed in Version | 3.0MP17 | |||
Status | closed | Fix in branch | Fixed in SCM revision | f786d405627e | ||||
Projection | none | ETA | none | Target Version | 3.0MP17 | |||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | dbaz | |||||||
Web browser | ||||||||
Modules | Core | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0022025: A line of an order cannot be saved in grid view when configuring the 2nd UOM | |||||||
Description | A line of an order cannot be saved in grid view when configuring the 2nd UOM. If you first select a value in the Order UOM field and insert a value in the Order Quantity field and then, change to empty the Order UOM field the record cannot be saved. The obtained error is: Saving failed. You have filled in Quantity order without selecting a corresponding UOM order , or viceversa. Fill in both fields, or leave them empty | |||||||
Steps To Reproduce | As system admin role: Activate the following tabs: Product - UOM Unit of Measure - Conversion and display the following fields: Sales/Purchase Order - Lines - Order UOM Sales/Purchase Order - Lines - Order Quantity As group admin role: Create a new Unit of Measure and configure a conversion to an existing UOM Add this new created UOM to a product with the existing UOM Create a sales or purchase order Display the Order UOM and Order Quantity columns in grid view Add a line to it in grid view: Select the UOM in the Order UOM field and add a value in the Order Quantity field Check that the converted value has been copied in the Quantity field Now, leave empty the Order UOM field (the Order Quantity value will be left empty) Try to save the record and notice that you get an error | |||||||
Tags | No tags attached. | |||||||
Attached Files | 22025_2.diff [^] (2,631 bytes) 2012-10-25 14:04 [Show Content] | |||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | ||||||||
|
Notes | |
(0053668) mtaal (manager) 2012-10-24 23:35 |
I think the diff solves it. The textual value needs to be set explicitly also when the setValue is called. Note: setValue is called when the value is changed programmatically, the FormItem also has an updateValue method, this one is called by the UI when the user changes something, that function again calls the changed method. But this does not apply here (the value is set manually). If you like the patch, can you test it in different windows, to see if anything changes. I also changed 2 other lines from setValue to setItemValue, I think this is correct/better as setItemValue also calls other change notification methods which should also be called if the value is set to null. gr. Martin |
(0053726) hgbot (developer) 2012-10-26 00:59 |
Repository: erp/devel/pi Changeset: f786d405627ea5465bb6a330af5aed800790ca6d Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com> Date: Fri Oct 26 00:58:22 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/f786d405627ea5465bb6a330af5aed800790ca6d [^] Fixes Issue 0022025: Error while saving Order lines. Error occured when null values was set in numeric fields through callouts. The value was not retained on save. Forced retain for the same. Refactored code to use setItemValue() in ob-view-form.js instead of setValue(), so that null values are handled better. --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js --- |
(0053727) shankarb (reporter) 2012-10-26 01:01 |
Hi Martin, The fix works for all the cases that I could think of. I have updated it to pi. Thank you. Shankar |
(0053815) dbaz (developer) 2012-10-30 12:58 |
Reviewed @ changeset: 18367 - 2c82168e2836 |
(0053927) hudsonbot (developer) 2012-10-31 13:30 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9e773cbcb723 [^] Maturity status: Test |
Issue History | |||
Date Modified | Username | Field | Change |
2012-10-22 12:21 | ngarcia | New Issue | |
2012-10-22 12:21 | ngarcia | Assigned To | => AugustoMauch |
2012-10-22 12:21 | ngarcia | Modules | => Core |
2012-10-22 12:21 | ngarcia | Resolution time | => 1356217200 |
2012-10-22 12:22 | ngarcia | Issue Monitored: networkb | |
2012-10-22 13:16 | ngarcia | Resolution time | 1356217200 => 1350943200 |
2012-10-22 17:48 | AugustoMauch | Assigned To | AugustoMauch => shankarb |
2012-10-24 23:32 | mtaal | File Added: 22025.diff | |
2012-10-24 23:35 | mtaal | Note Added: 0053668 | |
2012-10-25 14:03 | mtaal | File Deleted: 22025.diff | |
2012-10-25 14:04 | mtaal | File Added: 22025_2.diff | |
2012-10-26 00:46 | shankarb | Status | new => scheduled |
2012-10-26 00:46 | shankarb | fix_in_branch | => pi |
2012-10-26 00:47 | shankarb | Review Assigned To | => dbaz |
2012-10-26 00:47 | shankarb | fix_in_branch | pi => |
2012-10-26 00:48 | shankarb | Issue Monitored: dbaz | |
2012-10-26 00:59 | hgbot | Checkin | |
2012-10-26 00:59 | hgbot | Note Added: 0053726 | |
2012-10-26 01:00 | hgbot | Status | scheduled => resolved |
2012-10-26 01:00 | hgbot | Resolution | open => fixed |
2012-10-26 01:00 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/f786d405627ea5465bb6a330af5aed800790ca6d [^] |
2012-10-26 01:01 | shankarb | Note Added: 0053727 | |
2012-10-30 12:58 | dbaz | Note Added: 0053815 | |
2012-10-30 12:58 | dbaz | Status | resolved => closed |
2012-10-30 12:58 | dbaz | Fixed in Version | => 3.0MP17 |
2012-10-31 13:30 | hudsonbot | Checkin | |
2012-10-31 13:30 | hudsonbot | Note Added: 0053927 | |
2016-01-19 11:12 | alostale | Relationship added | related to 0031901 |
Copyright © 2000 - 2009 MantisBT Group |