Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0021222

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] 07. Sales management

major

always

2012-07-26 20:49

2012-08-09 13:07

Reporter

jonalegriaesarte

View Status

public

Assigned To

gorkaion

Priority

immediate

Resolution

fixed

Fixed in Version

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

3.0MP14

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

3.0MP13

SCM revision

Merge Request Status

Review Assigned To

OBNetwork customer

OBPS

Web browser

Modules

Core

Support ticket

16371

Regression level

Production - QA Approved

Regression date

Regression introduced in release

Regression introduced by commit

https://code.openbravo.com/erp/devel/pi/rev/cd961154b923 [^]

Triggers an Emergency Pack

yes

Summary

0021222: Price adjustments do not apply in sales order

Description

Price adjustments do not apply in sales order

Steps To Reproduce

- Price adjustments tab: define a price adjustment to category alcoholic, discount 35%, and tarifa ventas
- Create a new sales order
- Add a product from category alcoholic
- The price adjustment is not applied in the price of the sales order (notice that the entry is created correctly in the tab price adjustment)

Tags

No tags attached.

priceadjustments.diff [^] (1,084 bytes) 2012-07-30 18:52 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/erpCommon/ad_callouts/SL_Order_Product.java b/src/org/openbravo/erpCommon/ad_callouts/SL_Order_Product.java
--- a/src/org/openbravo/erpCommon/ad_callouts/SL_Order_Product.java
+++ b/src/org/openbravo/erpCommon/ad_callouts/SL_Order_Product.java
@@ -113,14 +113,15 @@
       log4j.debug("get Offers date: " + dataOrder[0].dateordered + " partner:"
           + dataOrder[0].cBpartnerId + " prod:" + strMProductID + " std:"
           + strPriceStd.replace("\"", ""));
-      if (isTaxIncludedPriceList) {
-        strNetPriceList = "0";
+      if (!isTaxIncludedPriceList) {
+        //strNetPriceList = "0";
         strPriceActual = SLOrderProductData.getOffersPrice(this, dataOrder[0].dateordered,
             dataOrder[0].cBpartnerId, strMProductID, (strPriceStd.equals("undefined") ? "0"
                 : strPriceStd.replace("\"", "")), strQty, dataOrder[0].mPricelistId,
             dataOrder[0].id);
       } else {
         strGrossPriceList = "0";
+	strNetPriceList = "0";
       }
       log4j.debug("get Offers price:" + strPriceActual);

Relationships [ Relation Graph ] [ Dependency Graph ]

depends on

defect

3.0MP13

closed

Add new field "Gross List Price" into Sales/Purchase Order and Sales/Purchase Invoice

Notes
(0051018) jonalegriaesarte (viewer) 2012-07-30 18:52	Attached possible patch

(0051027) hgbot (developer) 2012-07-31 12:19	Repository: erp/devel/pi Changeset: f7250e45857822390690b33f2425ecbb7d62036e Author: Gorka Ion Damián <gorkaion.damian <at> openbravo.com> Date: Tue Jul 31 12:18:51 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/f7250e45857822390690b33f2425ecbb7d62036e [^] Fixed issue 21222.Fix issue in if clause. --- M src/org/openbravo/erpCommon/ad_callouts/SL_Order_Product.java ---

(0051059) maite (viewer) 2012-08-01 13:42	verified

(0051202) hudsonbot (viewer) 2012-08-09 13:07	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ef9a070edd19 [^] Maturity status: Test

Issue History
Date Modified	Username	Field	Change
2012-07-26 20:49	jonalegriaesarte	New Issue
2012-07-26 20:49	jonalegriaesarte	Assigned To	=> jonalegriaesarte
2012-07-26 20:49	jonalegriaesarte	Modules	=> Core
2012-07-26 20:49	jonalegriaesarte	OBNetwork customer	=> Yes
2012-07-26 20:49	jonalegriaesarte	Support ticket	=> 16371
2012-07-26 20:50	jonalegriaesarte	Regression level	=> Production - QA Approved
2012-07-26 20:50	jonalegriaesarte	Regression introduced by commit	=> https://code.openbravo.com/erp/devel/pi/rev/cd961154b923 [^]
2012-07-26 20:50	jonalegriaesarte	Relationship added	depends on 0021077
2012-07-30 18:51	jonalegriaesarte	Assigned To	jonalegriaesarte => gorkaion
2012-07-30 18:52	jonalegriaesarte	File Added: priceadjustments.diff
2012-07-30 18:52	jonalegriaesarte	Note Added: 0051018
2012-07-31 12:19	hgbot	Checkin
2012-07-31 12:19	hgbot	Note Added: 0051027
2012-07-31 12:19	hgbot	Status	new => resolved
2012-07-31 12:19	hgbot	Resolution	open => fixed
2012-07-31 12:19	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/f7250e45857822390690b33f2425ecbb7d62036e [^]
2012-08-01 13:42	maite	Note Added: 0051059
2012-08-01 13:42	maite	Status	resolved => closed
2012-08-09 13:07	hudsonbot	Checkin
2012-08-09 13:07	hudsonbot	Note Added: 0051202

Copyright © 2000 - 2009 MantisBT Group