Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0020853 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | major | always | 2012-06-25 11:55 | 2012-07-10 10:35 | |||
| Reporter | psarobe | View Status | public | |||||
| Assigned To | mtaal | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | 3.0MP12.1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | e88820b22b7a | ||||
| Projection | none | ETA | none | Target Version | 3.0MP13 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Merge Request Status | ||||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Web browser | Mozilla Firefox | |||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | Production - QA Approved | |||||||
| Regression date | 2012-03-12 | |||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | https://code.openbravo.com/erp/devel/pi/rev/1f59bb3c479d [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0020853: Grid view: Call-outs are not working properly in some circumstances | |||||||
| Description | In grid view after changing the value of a field, the corresponding call-out is not being triggered so the values that need to be changed remains the same | |||||||
| Steps To Reproduce | 1. Go to purchase invoice window and fill the mandatory fields 2. Move to lines in grid view. click new 3. Select a product. Notice the focus moves to the quantity field 4. Change the quantity and with the mouse click the Net Unit Price field. The line net amount does not get changed. This is wrong 5. Click Save and then notice the line net amount doesn't get change either so finally you can have something like this: Quantity: 15 Net Unit Price: 2 Line net amount: 2 | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0050064) AugustoMauch (administrator) 2012-06-25 13:47 |
This issue is reproducible in Firefox, but not in Chrome |
|
(0050101) AugustoMauch (administrator) 2012-06-26 17:21 |
The changeset (https://code.openbravo.com/erp/devel/pi/rev/1f59bb3c479d [^]) that caused this issue was introduced in MP12 |
|
(0050337) hgbot (developer) 2012-07-03 14:49 |
Repository: erp/devel/pi Changeset: e88820b22b7a0d019a83111bccbd47186aed102d Author: Martin Taal <martin.taal <at> openbravo.com> Date: Tue Jul 03 14:48:29 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/e88820b22b7a0d019a83111bccbd47186aed102d [^] Fixes issue 20853: Grid view: Call-outs are not working properly in some circumstances Solve callout problem when changing focus using the mouse, instead of disabling the complete form, prevent keyboard and mouse input Select the complete value in grid mode when setting the focus on a numeric field Removed not needed override for selectvalue and ie At cell edit end only do blur if the celleditend is for the current focused item --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-number.js M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js --- |
|
(0050338) mtaal (viewer) 2012-07-03 15:25 |
this issue only occurred in Firefox, first I could solve the issue itself but then noticed an issue with FF, which was this: a form field showed as focused but not selected, but when typing the complete value was replaced. So ff did not show the value as selected. After lots of trial and error I noticed that it had to do with the way we disable the form when doing a FIC call to the server. We disable the form to prevent the user from making changes while the FIC call is done, when the FIC returns the form fields are enabled again. This did not work nicely with FF when restoring the focus and selected values. Part of the form disabling is the disabling of the keyboard input. To solve the focus/select issue I changed the disable of the form to now only disable key and mouse input during the FIC call. This solved the issue and has as a side benefit that it is faster than disabling all inputs. Just disabling the input should be enough for preventing the user from making changes during a fic call. This can be tested by trying some grid editing and form editing with fields with callouts for example in order/invoice header and lines. |
|
(0050346) AugustoMauch (administrator) 2012-07-04 11:09 |
Code reviewed and verified in pi@3e1b145beae8. The fix has been tested in Chrome, Firefox and Internet Explorer 8 |
|
(0050420) hudsonbot (viewer) 2012-07-10 10:35 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9f5eedec4e1a [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2012-06-25 11:55 | psarobe | New Issue | |
| 2012-06-25 11:55 | psarobe | Assigned To | => alostale |
| 2012-06-25 11:55 | psarobe | Modules | => Core |
| 2012-06-25 11:55 | psarobe | OBNetwork customer | => No |
| 2012-06-25 12:04 | marvintm | Assigned To | alostale => AugustoMauch |
| 2012-06-25 13:47 | AugustoMauch | Note Added: 0050064 | |
| 2012-06-26 13:31 | psarobe | Web browser | => Mozilla Firefox |
| 2012-06-26 15:48 | AugustoMauch | Web browser | Mozilla Firefox => Mozilla Firefox |
| 2012-06-26 15:48 | AugustoMauch | Regression level | => Pre packaging ( pi ) |
| 2012-06-26 15:48 | AugustoMauch | Regression date | => 2012-03-12 |
| 2012-06-26 15:48 | AugustoMauch | Regression introduced by commit | => https://code.openbravo.com/erp/devel/pi/rev/1f59bb3c479d [^] |
| 2012-06-26 16:21 | alostale | Web browser | Mozilla Firefox => Mozilla Firefox |
| 2012-06-26 16:21 | alostale | Regression level | Pre packaging ( pi ) => Production - QA Approved |
| 2012-06-26 17:21 | AugustoMauch | Note Added: 0050101 | |
| 2012-06-26 19:36 | shuehner | Issue Monitored: shuehner | |
| 2012-06-28 15:53 | mtaal | Assigned To | AugustoMauch => mtaal |
| 2012-07-03 14:49 | hgbot | Checkin | |
| 2012-07-03 14:49 | hgbot | Note Added: 0050337 | |
| 2012-07-03 14:49 | hgbot | Status | new => resolved |
| 2012-07-03 14:49 | hgbot | Resolution | open => fixed |
| 2012-07-03 14:49 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/e88820b22b7a0d019a83111bccbd47186aed102d [^] |
| 2012-07-03 15:25 | mtaal | Note Added: 0050338 | |
| 2012-07-04 11:09 | AugustoMauch | Note Added: 0050346 | |
| 2012-07-04 11:09 | AugustoMauch | Status | resolved => closed |
| 2012-07-04 11:09 | AugustoMauch | Fixed in Version | => 3.0MP12.1 |
| 2012-07-10 10:35 | hudsonbot | Checkin | |
| 2012-07-10 10:35 | hudsonbot | Note Added: 0050420 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |