Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0018655

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] A. Platform

minor

always

2011-09-30 11:40

2011-10-12 01:59

Reporter

mirurita

View Status

public

Assigned To

marvintm

Priority

normal

Resolution

fixed

Fixed in Version

3.0MP4

Status

closed

Fix in branch

pi

Fixed in SCM revision

Projection

none

ETA

none

Target Version

3.0MP4

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

pi

SCM revision

Merge Request Status

Review Assigned To

OBNetwork customer

No

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0018655: Callout - when FIC returns several MESSAGE objects the last one should be shown

Description

Field A - Launches callout A which returns a message: "Hello I'm the field A" and it changes the Field B.

Field B - Launches callout B which returns a message: "Hello I'm the field B"

In 2.50 the second callout will overwrite the first message and the user will see: "Hello I'm the field B"

In 3.0 the first message is shown "Hello I'm the field A".

Different behavior in 2.50 and 3.0

Steps To Reproduce

1) Create a callout A for field A:
- return a message: "Hello I'm the field A"
- changes the field B

2) Create a callout B for field B that return a message: "Hello I'm the field B"

3) Change field A and notice that the message of callout B (last fired callout) is shown.

Proposed Solution

Make behavior consistent:
I think the last message should be shown.
See attached diff.

Tags

No tags attached.

issue18655.patch [^] (1,111 bytes) 2011-09-30 11:42 [Show Content] [Hide Content]

diff -r 06edd077bff6 modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
--- a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js	Thu Sep 29 17:13:19 2011 +0200
+++ b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js	Fri Sep 30 11:41:22 2011 +0200
@@ -668,9 +668,9 @@
     }
 
     // apparently sometimes an empty string is returned
-    if (calloutMessages && calloutMessages.length > 0 && calloutMessages[0].text !== '') {
+    if (calloutMessages && calloutMessages.length > 0 && calloutMessages[calloutMessages.length-1].text !== '') {
       // TODO: check as what type should call out messages be displayed
-      this.view.messageBar.setMessage(isc.OBMessageBar[calloutMessages[0].severity], null, calloutMessages[0].text);
+      this.view.messageBar.setMessage(isc.OBMessageBar[calloutMessages[calloutMessages.length-1].severity], null, calloutMessages[calloutMessages.length-1].text);
     }
     if (auxInputs) {
       for (prop in auxInputs) {

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0041403) hgbot (developer) 2011-09-30 11:48	Repository: erp/devel/pi Changeset: 29c7f8e120e06dba7809f132400f6a38c8053c1e Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Fri Sep 30 11:48:16 2011 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/29c7f8e120e06dba7809f132400f6a38c8053c1e [^] Fixed issue 18655. If there are several messages, the last one will be shown. --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js ---

(0041729) hudsonbot (viewer) 2011-10-12 01:59	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9bd2b5c2d982 [^] Maturity status: Test

Issue History
Date Modified	Username	Field	Change
2011-09-30 11:40	mirurita	New Issue
2011-09-30 11:40	mirurita	Assigned To	=> marvintm
2011-09-30 11:40	mirurita	Modules	=> Core
2011-09-30 11:40	mirurita	OBNetwork customer	=> No
2011-09-30 11:42	mirurita	File Added: issue18655.patch
2011-09-30 11:47	marvintm	Target Version	=> 3.0MP4
2011-09-30 11:47	marvintm	Status	new => acknowledged
2011-09-30 11:47	marvintm	Status	acknowledged => scheduled
2011-09-30 11:47	marvintm	fix_in_branch	=> pi
2011-09-30 11:48	hgbot	Checkin
2011-09-30 11:48	hgbot	Note Added: 0041403
2011-09-30 11:48	hgbot	Status	scheduled => resolved
2011-09-30 11:48	hgbot	Resolution	open => fixed
2011-09-30 11:48	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/29c7f8e120e06dba7809f132400f6a38c8053c1e [^]
2011-10-04 16:11	dbaz	Status	resolved => closed
2011-10-04 16:11	dbaz	Fixed in Version	=> 3.0MP4
2011-10-12 01:59	hudsonbot	Checkin
2011-10-12 01:59	hudsonbot	Note Added: 0041729

Copyright © 2000 - 2009 MantisBT Group